Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_vpc: Wait for IPv6 association on Create #6394

Merged
merged 1 commit into from
Nov 8, 2018
Merged

resource/aws_vpc: Wait for IPv6 association on Create #6394

merged 1 commit into from
Nov 8, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 8, 2018

Fixes #3398

Changes:

  • resource/aws_vpc: Add IPv6 CIDR block association waiter during VPC creation
  • resource/aws_vpc: Refactor IPv6 CIDR block association waiters into separate functions
  • tests/resource/aws_vpc: Stronger IPv6 checks and general refactoring

Output from acceptance testing:

--- PASS: TestAccAWSVpc_coreMismatchedDiffs (22.74s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (27.42s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (28.19s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (28.40s)
--- PASS: TestAccAWSVpc_basic (28.41s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (36.09s)
--- PASS: TestAccAWSVpc_update (40.07s)
--- PASS: TestAccAWSVpc_tags (45.86s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (64.86s)
--- PASS: TestAccAWSVpc_Tenancy (65.81s)

@bflad
resource/aws_vpc: Wait for IPv6 association on Create
2b41d36 
Changes:
* resource/aws_vpc: Add IPv6 CIDR block association waiter during VPC creation
* resource/aws_vpc: Refactor IPv6 CIDR block association waiters into separate functions
* tests/resource/aws_vpc: Stronger IPv6 checks and general refactoring

```
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (22.74s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (27.42s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (28.19s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (28.40s)
--- PASS: TestAccAWSVpc_basic (28.41s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (36.09s)
--- PASS: TestAccAWSVpc_update (40.07s)
--- PASS: TestAccAWSVpc_tags (45.86s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (64.86s)
--- PASS: TestAccAWSVpc_Tenancy (65.81s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Nov 8, 2018
@bflad bflad requested a review from a team November 8, 2018 00:16
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 8, 2018
@bflad bflad mentioned this pull request Nov 8, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.43.1 milestone Nov 8, 2018
@bflad bflad merged commit d5c454c into master Nov 8, 2018
@bflad bflad deleted the b-aws_vpc-ipv6-on-create branch November 8, 2018 13:33
bflad added a commit that referenced this pull request Nov 8, 2018
@bflad
Update CHANGELOG for #6394
63055f0
@bflad
Copy link
Contributor Author

bflad commented Nov 9, 2018

This has been released in version 1.43.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.43.1
Development

Successfully merging this pull request may close these issues.

Unable to add IPv6 to a VPC and subnets in a single operation
2 participants
@bflad @tombuildsstuff