r/aws_s3_bucket_object: Enable source to be an s3 source

[YakDriver]

Updated Sep 1, 2020
Fixes #3943

Changes proposed in this pull request:

• resource/aws_s3_bucket_object: allow the source attribute to be an s3 URL (instead of just a file)

For example, with this PR, this would be possible (copying object from one s3 bucket to another s3 bucket):

resource "aws_s3_bucket" "source_bucket" {
  bucket = "tf-object-test-bucket-1111"
}

resource "aws_s3_bucket_object" "source_object" {
  bucket  = aws_s3_bucket.source_bucket.id
  key     = "object-to-copy"
  content = "Jelly Bean"
}

resource "aws_s3_bucket" "dest_bucket" {
  bucket = "tf-object-test-bucket-5555"
}

resource "aws_s3_bucket_object" "dest_object" {
  bucket = aws_s3_bucket.dest_bucket.id
  key    = "copied-object"
  source = "s3://${aws_s3_bucket.source_bucket.id}/${aws_s3_bucket_object.source_object.id}"
}

GovCloud acceptance testing (Sep 1 2020):

--- PASS: TestAccAWSS3BucketObject_s3SourceBasic (32.72s)
--- PASS: TestAccAWSS3BucketObject_s3SourceWithContentCharacteristics (32.72s)

Commercial acceptance testing (Sep 1 2020):

--- PASS: TestAccAWSS3BucketObject_s3SourceBasic (29.52s)
--- PASS: TestAccAWSS3BucketObject_s3SourceWithContentCharacteristics (29.62s)

[YakDriver]

Mar 21, 2019: Comment changed due to new development

When copying s3 objects, metadata will also be copied or updated based on arguments provided in config.

For example:
* If the source object has content_language set to en and in the copy, content_language is not set, the copied object will have content_language set to en.
* If the source object has content_language set to en and in the copy, content_language is set to es, the copied object will have content_language set to es (updating the metadata).

[YakDriver]

To address the issue in the previous comment, I've added this note to the docs in this PR:

Note: When copying an S3 object, some attributes will be copied that cannot be changed, such as content_language, cache_control, and content_encoding. To avoid Terraform reporting differences between your configuration and infrastructure when doing a subsequent apply, include these attributes in your configuration with the same values as the copied object.

[YakDriver]

@bflad any chance of getting a look at this? 😃 🦃

[YakDriver]

@bflad This is rebased and ready for a look! 👁

[lorengordon]

Would love to be able to use this. Getting tiresome to have to download every object locally first.

[YakDriver]

Old acceptance tests...

[YakDriver]

Rebased and TF 0.12 issues addressed. Acceptance tests are passing:

[YakDriver]

@bflad @ryndaniels Conflicts resolved. Let me know if you'd like any adjust.

[YakDriver]

@bflad This is a friendly ping 🏓 . We'd love to be able to use this!

[lorengordon]

@bflad @aeschright is this on the radar to review/merge?

[YakDriver]

The main update today was pairing down acceptance tests to functionality that really needed to be tested with the additional functionality. Previous tests were excessive.

GovCloud acceptance testing:

--- PASS: TestAccAWSS3BucketObject_s3SourceBasic (32.72s)
--- PASS: TestAccAWSS3BucketObject_s3SourceWithContentCharacteristics (32.72s)

Commercial acceptance testing:

--- PASS: TestAccAWSS3BucketObject_s3SourceBasic (29.52s)
--- PASS: TestAccAWSS3BucketObject_s3SourceWithContentCharacteristics (29.62s)

[bflad]

Closing in preference of #15461

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!