Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_iam_user: Enable TestAccAWSUser_ForceDestroy_MFADevice #6362

Merged
merged 1 commit into from
Nov 5, 2018
Merged

tests/resource/aws_iam_user: Enable TestAccAWSUser_ForceDestroy_MFADevice #6362

merged 1 commit into from
Nov 5, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 5, 2018

Changes proposed:

  • govendor fetch github.com/pquerna/otp/totp
  • Implement MFA device code generation for acceptance testing

Output from acceptance testing:

--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (9.16s)

@bflad
tests/resource/aws_iam_user: Enable TestAccAWSUser_ForceDestroy_MFADe…
20d3dcd 
…vice

Changes:

* `govendor fetch github.com/pquerna/otp/totp`
* Implement MFA device code generation for acceptance testing

```
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (9.16s)
```
@bflad bflad requested a review from a team November 5, 2018 17:26
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2018
tombuildsstuff
tombuildsstuff approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.43.0 milestone Nov 5, 2018
@bflad bflad merged commit 7187221 into master Nov 5, 2018
@bflad bflad deleted the t-aws_iam_user-mfa branch November 5, 2018 19:46
@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. service/iam Issues and PRs that pertain to the iam service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff