Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parallel running of DX VIF acceptance tests #6342

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #6244.
Acceptance tests:

$ DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxPrivateVirtualInterface_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxPrivateVirtualInterface_basic
=== RUN   TestAccAwsDxPrivateVirtualInterface_dxGateway
=== PAUSE TestAccAwsDxPrivateVirtualInterface_dxGateway
=== RUN   TestAccAwsDxPrivateVirtualInterface_mtuUpdate
=== PAUSE TestAccAwsDxPrivateVirtualInterface_mtuUpdate
=== CONT  TestAccAwsDxPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxPrivateVirtualInterface_mtuUpdate
=== CONT  TestAccAwsDxPrivateVirtualInterface_dxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (514.47s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_dxGateway (525.06s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_mtuUpdate (1181.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1182.206s

$ DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxPublicVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxPublicVirtualInterface_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxPublicVirtualInterface_basic
=== CONT  TestAccAwsDxPublicVirtualInterface_basic
--- PASS: TestAccAwsDxPublicVirtualInterface_basic (45.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.975s

$ DX_HOSTED_VIF_OWNER_ACCOUNT=000000000000 DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_basic
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate
=== CONT  TestAccAwsDxHostedPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_basic (32.75s)
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate (89.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.375s

$ DX_HOSTED_VIF_OWNER_ACCOUNT=000000000000 DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface_'
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxHostedPublicVirtualInterface_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPublicVirtualInterface_basic
=== CONT  TestAccAwsDxHostedPublicVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (35.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.147s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 2, 2018
@bflad bflad added this to the v1.43.0 milestone Nov 5, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ewbankkit, thanks! 🚀

@bflad bflad merged commit 392022a into hashicorp:master Nov 5, 2018
@ewbankkit ewbankkit deleted the issue-6244 branch November 7, 2018 11:48
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/directconnect Issues and PRs that pertain to the directconnect service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_dx_private_virtual_interface: Error running parallel acceptance tests
2 participants