Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_dx_connection: Export bool value of new MTU parameter #6143

Merged
merged 1 commit into from
Oct 14, 2018
Merged

resource/aws_dx_connection: Export bool value of new MTU parameter #6143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions aws/resource_aws_dx_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ func resourceAwsDxConnection() *schema.Resource {
Required: true,
ForceNew: true,
},
"jumbo_frame_capable": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on attribute naming: https://github.com/terraform-providers/terraform-provider-aws/pull/6141/files#r224957129.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to go with jumbo_frame_capable to match the API. I'll make this update to the other PRs where they don't match this convention.

Type: schema.TypeBool,
Computed: true,
},
"tags": tagsSchema(),
},
}
Expand Down Expand Up @@ -111,6 +115,7 @@ func resourceAwsDxConnectionRead(d *schema.ResourceData, meta interface{}) error
d.Set("name", connection.ConnectionName)
d.Set("bandwidth", connection.Bandwidth)
d.Set("location", connection.Location)
d.Set("jumbo_frame_capable", connection.JumboFrameCapable)

if err := getTagsDX(conn, d, arn); err != nil {
return err
Expand Down
1 change: 1 addition & 0 deletions website/docs/r/dx_connection.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ In addition to all arguments above, the following attributes are exported:

* `id` - The ID of the connection.
* `arn` - The ARN of the connection.
* `jumbo_frame_capable` - Boolean value representing if jumbo frames have been enabled for this connection.

## Import

Expand Down