provider: Lift and shift import_*_test.go code into resource_*_test.go files #5891
+3,083
−3,926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
technical-debt
…o files Reference: #4705 Previously and currently: ``` $ go test -list . ./aws | wc -l 2530 ```
bflad
force-pushed
the
td-import-test-files-be-gone
branch
from
5c2f057 to
39e0fd4
Compare
paddycarver
approved these changes
Sep 18, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes, just moved the code. The practice of creating the
import_*_test.gofiles is extraneous and inconsistently applied in this provider. Other than reducing the file count, this should give a little speed improvement to some editors/tooling.At some point we will likely consolidate the
_importtests into their regular test counterparts, but that requires running the acceptance testing after updates (and potentially fixing resource code) to complete each one, which is a much slower process.Closes #4705
Previously and currently: