-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Bump aws-sdk-go to 1.13.32 #4206
Conversation
vendor/vendor.json
Outdated
@@ -39,916 +39,924 @@ | |||
"revisionTime": "2017-07-27T15:54:43Z" | |||
}, | |||
{ | |||
"checksumSHA1": "Fs3DE5rdov9GRx+jUJ7VfG/EBvA=", | |||
"checksumSHA1": "pyVcj3els/KPpbHwCTcsW4jbLrE=", | |||
"path": "github.com/aws/aws-sdk-go", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like this was accidentally vendored without the trailing slash before the ...
-- hence all the extra root SDK files. Probably simpler to just redo this PR again with just govendor fetch github.com/aws/aws-sdk-go/[email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid - @bflad should be good to go with the latest commit. Thanks for looking this over!
eed69a9
to
9346529
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thanks! 🚀
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
After this I plan to make another PR that allows us to use the new
ONEZONE_IA
storage_class