Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Bump aws-sdk-go to 1.13.32 #4206

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Conversation

hwrdprkns
Copy link

@hwrdprkns hwrdprkns commented Apr 14, 2018

govendor fetch github.com/aws/aws-sdk-go/...@=v1.13.32

After this I plan to make another PR that allows us to use the new ONEZONE_IA storage_class

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Apr 14, 2018
@hwrdprkns
Copy link
Author

hwrdprkns commented Apr 14, 2018

Have these ready to PR after this is merged.

94e4c10
4c2ce78

@@ -39,916 +39,924 @@
"revisionTime": "2017-07-27T15:54:43Z"
},
{
"checksumSHA1": "Fs3DE5rdov9GRx+jUJ7VfG/EBvA=",
"checksumSHA1": "pyVcj3els/KPpbHwCTcsW4jbLrE=",
"path": "github.com/aws/aws-sdk-go",
Copy link
Contributor

@bflad bflad Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like this was accidentally vendored without the trailing slash before the ... -- hence all the extra root SDK files. Probably simpler to just redo this PR again with just govendor fetch github.com/aws/aws-sdk-go/[email protected]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid - @bflad should be good to go with the latest commit. Thanks for looking this over!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 17, 2018
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. labels Apr 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks! 🚀

@bflad bflad merged commit 72223eb into hashicorp:master Apr 20, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 20, 2018
@bflad bflad added this to the v1.16.0 milestone Apr 20, 2018
@hwrdprkns hwrdprkns deleted the t-aws-one-zone-ia branch April 29, 2018 05:39
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants