Deprecates some id attributes on Framework resources

[gdavison]

Description

Starts the process of deprecating unneeded id attributes in resource types implemented using Terraform Framework.

Note that regardless of the actual DeprecationMessage on the attribute, Terraform will display, e.g.

│ Warning: Deprecated attribute
│
│ on main.tf line 431, in resource "aws_s3_bucket_policy" "test":
│ 431: bucket = aws_s3_directory_bucket.test.id
│
│ The attribute "id" is deprecated. Refer to the provider documentation for details.

Adds

• framework.IDAttributeDeprecatedWithAlternate when there is an alternate attribute to use
• framework.IDAttributeDeprecatedNoReplacement when these is no replacement attribute

Deprecates id from

• aws_s3_directory_bucket
• aws_route53_cidr_location
• aws_api_gateway_domain_name_access_association

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

[github-actions]

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!