Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_eks_cluster: Fix enablement of EKS Auto Mode on existing clusters without forcing re-creation #40415

Merged

Conversation

bryantbiggs
Copy link
Contributor

Description

  • Fix enablement of EKS Auto Mode on existing clusters without forcing re-creation

Relations

Closes #40411

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented Dec 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/eks Issues and PRs that pertain to the eks service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 3, 2024
@gdavison gdavison self-assigned this Dec 4, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 4, 2024
@bryantbiggs bryantbiggs force-pushed the aws_eks_cluster/auto-mode-opt-in branch from b058e93 to f135067 Compare December 4, 2024 20:38
@gdavison
Copy link
Contributor

gdavison commented Dec 6, 2024

I've separated the three update cases:

  • Change enabled
  • Enable compute_config on an update
  • Change compute_config.node_role_arn

The reason there was an unexpected ForceNew was that bootstrap_self_managed_addons was being changed from the default true to false

@gdavison gdavison marked this pull request as ready for review December 6, 2024 19:44
@gdavison gdavison requested a review from a team as a code owner December 6, 2024 19:44
@gdavison
Copy link
Contributor

gdavison commented Dec 6, 2024

--- PASS: TestAccEKSCluster_tags (558.43s)
--- PASS: TestAccEKSCluster_basic (611.64s)
--- PASS: TestAccEKSCluster_upgradePolicy (616.15s)
--- SKIP: TestAccEKSCluster_Outpost_placement (0.23s)
--- PASS: TestAccEKSCluster_disappears (635.18s)
--- SKIP: TestAccEKSCluster_Outpost_create (0.12s)
--- PASS: TestAccEKSCluster_AccessConfig_create (655.00s)
--- PASS: TestAccEKSCluster_Encryption_create (657.58s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_migrate (688.06s)
--- PASS: TestAccEKSCluster_logging (698.72s)
--- PASS: TestAccEKSCluster_zonalShiftConfig (728.07s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Pod (732.04s)
--- PASS: TestAccEKSCluster_AccessConfig_update (834.65s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1026.90s)
--- PASS: TestAccEKSCluster_ComputeConfig_OnCreate (1055.77s)
--- PASS: TestAccEKSCluster_ComputeConfig_OnUpdate (1103.73s)
--- PASS: TestAccEKSCluster_version (1109.49s)
--- PASS: TestAccEKSCluster_BootstrapSelfManagedAddons_update (1167.38s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1234.84s)
--- PASS: TestAccEKSCluster_RemoteNetwork_Node (692.52s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (662.00s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1369.58s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (847.43s)
--- PASS: TestAccEKSCluster_ComputeConfig_ModifyARN (1537.49s)
--- PASS: TestAccEKSCluster_Encryption_update (1807.46s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1269.95s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1401.17s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDsAndSubnetIDs_update (1524.64s)

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 6, 2024
@gdavison gdavison merged commit 05c76fd into hashicorp:main Dec 6, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 6, 2024
@bryantbiggs
Copy link
Contributor Author

thank you so much @gdavison, really appreciate it!

@bryantbiggs bryantbiggs deleted the aws_eks_cluster/auto-mode-opt-in branch December 6, 2024 20:38
@lorengordon
Copy link
Contributor

I see this is tagged for 5.81.0, but it doesn't look like it is mentioned in the release notes?

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants