Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_record: Fix panic: interface conversion when geolocation_routing_policy is empty #39944

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 30, 2024

Description

Use standard expander for blocks.

Relations

Closes #39936.

Output from Acceptance Testing

--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (221.29s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (220.74s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
--- PASS: TestAccRoute53Record_Alias_change (225.71s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
--- PASS: TestAccRoute53Record_Alias_changeDualstack (243.19s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_nameChange (284.31s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (205.02s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (227.60s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (259.52s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (217.18s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (233.54s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (245.52s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover

@ewbankkit ewbankkit requested a review from a team as a code owner October 30, 2024 14:24
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/route53 Issues and PRs that pertain to the route53 service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 30, 2024
@ewbankkit ewbankkit enabled auto-merge October 30, 2024 14:24
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit fd8e814 into main Oct 30, 2024
30 of 31 checks passed
@ewbankkit ewbankkit deleted the b-aws_route53_record.geolocation_routing_policy-crash branch October 30, 2024 14:33
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 30, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 30, 2024
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
Copy link

github-actions bot commented Dec 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: The terraform-provider-aws_v5.73.0_x5 plugin crashed!
2 participants