Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom single-attribute ImportStateIdFuncs with acctest.AttrImportStateIdFunc #39898

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Replace custom single-attribute ImportStateIdFuncs with acctest.AttrImportStateIdFunc #39898

wants to merge 12 commits into from
+87 −329

Conversation

gdavison
Copy link
Contributor

Description

Replaces custom single-attribute ImportStateIdFuncs with acctest.AttrImportStateIdFunc

@gdavison gdavison requested a review from a team as a code owner October 25, 2024 23:39
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ecs Issues and PRs that pertain to the ecs service. service/ssm Issues and PRs that pertain to the ssm service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/s3control Issues and PRs that pertain to the s3control service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/events Issues and PRs that pertain to the events service. service/rekognition Issues and PRs that pertain to the rekognition service. service/vpc Issues and PRs that pertain to the vpc service. service/chatbot Issues and PRs that pertain to the chatbot service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/chatbot Issues and PRs that pertain to the chatbot service. service/ecs Issues and PRs that pertain to the ecs service. service/events Issues and PRs that pertain to the events service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/rekognition Issues and PRs that pertain to the rekognition service. service/s3control Issues and PRs that pertain to the s3control service. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. service/ssm Issues and PRs that pertain to the ssm service. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gdavison