Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Route 53 Recovery Readiness to AWS SDK v2 #38801

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Migrate Route 53 Recovery Readiness to AWS SDK v2 #38801

merged 8 commits into from
Aug 9, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR migrates the Route 53 Recovery Readiness resources to AWS SDKv2.

Relations

Closes #36205
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAcc' PKG=route53recoveryreadiness
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53recoveryreadiness/... -v -count 1 -parallel 20  -run=TestAcc -timeout 360m
=== RUN   TestAccRoute53RecoveryReadinessCell_basic
=== PAUSE TestAccRoute53RecoveryReadinessCell_basic
=== RUN   TestAccRoute53RecoveryReadinessCell_disappears
=== PAUSE TestAccRoute53RecoveryReadinessCell_disappears
=== RUN   TestAccRoute53RecoveryReadinessCell_nestedCell
=== PAUSE TestAccRoute53RecoveryReadinessCell_nestedCell
=== RUN   TestAccRoute53RecoveryReadinessCell_tags
=== PAUSE TestAccRoute53RecoveryReadinessCell_tags
=== RUN   TestAccRoute53RecoveryReadinessCell_timeout
=== PAUSE TestAccRoute53RecoveryReadinessCell_timeout
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_disappears
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_disappears
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_timeout
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_timeout
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_disappears
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_disappears
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_timeout
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_timeout
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basic
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basic
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_disappears
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_disappears
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_tags
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_tags
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_readinessScope
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_readinessScope
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_timeout
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_timeout
=== CONT  TestAccRoute53RecoveryReadinessCell_basic
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_nestedCell
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_readinessScope
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_timeout
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource
=== CONT  TestAccRoute53RecoveryReadinessCell_nestedCell
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basic
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== CONT  TestAccRoute53RecoveryReadinessCell_disappears
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_timeout
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_disappears
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_disappears
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_timeout
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== CONT  TestAccRoute53RecoveryReadinessCell_tags
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== CONT  TestAccRoute53RecoveryReadinessCell_timeout
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_disappears (35.98s)
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_tags
--- PASS: TestAccRoute53RecoveryReadinessCell_timeout (38.39s)
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_disappears
--- PASS: TestAccRoute53RecoveryReadinessCell_basic (39.59s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_timeout (39.89s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_readinessScope (39.93s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_disappears (40.01s)
--- PASS: TestAccRoute53RecoveryReadinessCell_disappears (40.22s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource (41.01s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_timeout (41.18s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target (41.38s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_timeout (42.66s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basic (43.13s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_nestedCell (45.33s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_basic (46.08s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_basic (53.72s)
--- PASS: TestAccRoute53RecoveryReadinessCell_tags (68.32s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_disappears (31.63s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_tags (72.68s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_tags (76.54s)
--- PASS: TestAccRoute53RecoveryReadinessCell_nestedCell (78.60s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_tags (51.52s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget (252.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	257.714s
...

@DanielRieske DanielRieske requested a review from a team as a code owner August 9, 2024 16:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 9, 2024
@jar-b jar-b added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2024
@jar-b jar-b self-assigned this Aug 9, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 9, 2024
jar-b
jar-b approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=route53recoveryreadiness
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53recoveryreadiness/... -v -count 1 -parallel 20   -timeout 360m

--- PASS: TestAccRoute53RecoveryReadinessResourceSet_disappears (30.60s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_disappears (32.05s)
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_readinessScope
--- PASS: TestAccRoute53RecoveryReadinessCell_basic (33.95s)
--- PASS: TestAccRoute53RecoveryReadinessCell_timeout (34.26s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_timeout (35.27s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_timeout (38.18s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_basic (40.17s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basicDNSTargetResource (40.45s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceR53Target (41.42s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_nestedCell (42.30s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_timeout (46.36s)
--- PASS: TestAccRoute53RecoveryReadinessCell_disappears (16.44s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_disappears (47.63s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_basic (47.73s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basic (49.03s)
--- PASS: TestAccRoute53RecoveryReadinessCell_nestedCell (65.00s)
--- PASS: TestAccRoute53RecoveryReadinessCell_tags (65.37s)
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_tags (69.30s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_tags (69.79s)
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_tags (77.81s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_readinessScope (47.96s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_dnsTargetResourceNLBTarget (224.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness   231.209s

internal/service/route53recoveryreadiness/cell.go
}
if err != nil {
return sdkdiag.AppendErrorf(diags, "waiting for Route 53 Recovery Readiness Cell (%s) deletion: %s", d.Id(), err)
}

return diags
}

func findCellByName(ctx context.Context, conn *route53recoveryreadiness.Client, name string) (*route53recoveryreadiness.GetCellOutput, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And new finders! 🥇 🎉

@jar-b
Copy link
Member

jar-b commented Aug 9, 2024

Thanks for your contribution, @DanielRieske! 👍

@jar-b jar-b merged commit d0982ae into hashicorp:main Aug 9, 2024
54 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 9, 2024
@jar-b jar-b mentioned this pull request Aug 9, 2024
Merged
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.63.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Route 53 Recovery Readiness Service
2 participants
@DanielRieske @jar-b