r/aws_ecs_service: Fix error marshaling prior state: a number is required when upgrading from v5.58.0 to v5.59.0

[ewbankkit]

Description

At v5.58.0 volume_configuration.managed_ebs_volume.throughput was TypeString. #38109 (v5.59.0) changed the attribute to TypeInt but any empty values in state would be "", which cannot be converted to an integer -- hence the error.
The fix is to add a StateUpgrader to convert any empty string values to 0.

Relations

Closes #38475.

References

Output from Acceptance Testing

% AWS_DEFAULT_REGION=us-east-2 make testacc TESTARGS='-run=TestAccECSService_VolumeConfiguration' PKG=ecs              
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20  -run=TestAccECSService_VolumeConfiguration -timeout 360m
=== RUN   TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== RUN   TestAccECSService_VolumeConfiguration_update
=== PAUSE TestAccECSService_VolumeConfiguration_update
=== RUN   TestAccECSService_VolumeConfiguration_throughputTypeChange
=== PAUSE TestAccECSService_VolumeConfiguration_throughputTypeChange
=== CONT  TestAccECSService_VolumeConfiguration_basic
=== CONT  TestAccECSService_VolumeConfiguration_throughputTypeChange
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_VolumeConfiguration_basic (68.17s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (95.32s)
--- PASS: TestAccECSService_VolumeConfiguration_update (101.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	106.256s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=ecs TESTS=TestAccECSService_VolumeConfiguration_throughputTypeChange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_VolumeConfiguration_throughputTypeChange'  -timeout 360m

--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (91.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        97.910s

[github-actions]

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.