Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned] feat: Add delete options for aws_fsx_openzfs_file_system #37651

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 23, 2024

Description

This PR adds the delete_options and final_backup_tags arguments to the aws_fsx_openzfs_file_system resource.

For the acceptance tests, I added a new environment variable FSX_CREATE_FINAL_BACKUP to control whether the test cases that involve taking a final backup on file system deletion is run. The backups would remain after running unit tests so they must be deleted afterwards to avoid storage costs.

Relations

Closes #36399

References

Referred to DeleteFileSystem specs and wordings.

Output from Acceptance Testing

$ export FSX_CREATE_FINAL_BACKUP=true
$ TF_ACC=1 go1.22.2 test ./internal/service/fsx/... -v -count 1 -parallel 3 -run='TestAccFSxOpenZFSFileSystem_basic|TestAccFSxOpenZFSFileSystem_deleteOptions'  -timeout 360m
=== RUN   TestAccFSxOpenZFSFileSystem_basic
=== PAUSE TestAccFSxOpenZFSFileSystem_basic
=== RUN   TestAccFSxOpenZFSFileSystem_deleteOptions
=== PAUSE TestAccFSxOpenZFSFileSystem_deleteOptions
=== CONT  TestAccFSxOpenZFSFileSystem_basic
=== CONT  TestAccFSxOpenZFSFileSystem_deleteOptions
--- PASS: TestAccFSxOpenZFSFileSystem_basic (549.56s)
--- PASS: TestAccFSxOpenZFSFileSystem_deleteOptions (672.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        673.009s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/L Managed by automation to categorize the size of a PR. label May 23, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 23, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. labels May 23, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@acwwat acwwat force-pushed the f-aws_fsx_openzfs_file_system-add_delete_related_args branch from 7eb4260 to 1ce658e Compare May 23, 2024 01:14
@acwwat acwwat force-pushed the f-aws_fsx_openzfs_file_system-add_delete_related_args branch from 1ce658e to 9d56ccf Compare May 23, 2024 01:26
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2024
@acwwat acwwat changed the title feat: Add delete options for aws_fsx_openzfs_file_system [WIP] feat: Add delete options for aws_fsx_openzfs_file_system May 26, 2024
@acwwat acwwat marked this pull request as draft May 26, 2024 18:49
@acwwat acwwat closed this May 26, 2024
@acwwat acwwat changed the title [WIP] feat: Add delete options for aws_fsx_openzfs_file_system [Superceded] feat: Add delete options for aws_fsx_openzfs_file_system May 26, 2024
@acwwat acwwat changed the title [Superceded] feat: Add delete options for aws_fsx_openzfs_file_system [Abandoned] feat: Add delete options for aws_fsx_openzfs_file_system May 26, 2024
@acwwat
Copy link
Contributor Author

acwwat commented May 26, 2024

This PR has been abandoned and the changes are now incorporated into PR #37717 along with similar enhancements to other FSx file system types.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: [FSx] Include options which are used when using delete API
2 participants