-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Abandoned] feat: Add delete options for aws_fsx_openzfs_file_system #37651
[Abandoned] feat: Add delete options for aws_fsx_openzfs_file_system #37651
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
7eb4260
to
1ce658e
Compare
1ce658e
to
9d56ccf
Compare
This PR has been abandoned and the changes are now incorporated into PR #37717 along with similar enhancements to other FSx file system types. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
delete_options
andfinal_backup_tags
arguments to theaws_fsx_openzfs_file_system
resource.For the acceptance tests, I added a new environment variable
FSX_CREATE_FINAL_BACKUP
to control whether the test cases that involve taking a final backup on file system deletion is run. The backups would remain after running unit tests so they must be deleted afterwards to avoid storage costs.Relations
Closes #36399
References
Referred to DeleteFileSystem specs and wordings.
Output from Acceptance Testing