Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vpc resources to AWS SDK V2 (Part 1) #37534

Merged
merged 21 commits into from
May 16, 2024
Merged

Migrate vpc resources to AWS SDK V2 (Part 1) #37534

merged 21 commits into from
May 16, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented May 15, 2024 •
edited
Loading

Description

Migrates VPC endpoint (and by association many other resources sharing various helper functions) to AWS SDK V2. This will be part of a multi-step migration for vpc resources.

Also fixes various acceptance tests which were not passing prior to migration.

Relations

Relates #36219
Relates #35747
Relates #32976

Output from Acceptance Testing

% make testacc PKG=ec2 TESTS=TestAccVPCPrefixListDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCPrefixListDataSource_'  -timeout 360m

--- PASS: TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter (2.52s)
--- PASS: TestAccVPCPrefixListDataSource_basic (10.11s)
--- PASS: TestAccVPCPrefixListDataSource_filter (10.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        15.365s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpoint_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_'  -timeout 360m

--- PASS: TestAccVPCEndpoint_disappears (29.07s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (32.14s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (40.80s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (53.07s)
--- PASS: TestAccVPCEndpoint_tags (53.39s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (55.01s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (91.67s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (242.83s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (262.97s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (281.69s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (330.89s)
--- PASS: TestAccVPCEndpoint_ipAddressType (331.40s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (459.27s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (522.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        527.229s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointDataSource_'  -timeout 360m

--- PASS: TestAccVPCEndpointDataSource_byID (27.48s)
--- PASS: TestAccVPCEndpointDataSource_byTags (27.48s)
--- PASS: TestAccVPCEndpointDataSource_byFilter (27.48s)
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (27.48s)
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (41.96s)
--- PASS: TestAccVPCEndpointDataSource_interface (113.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        119.189s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointPolicy_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointPolicy_'  -timeout 360m

--- PASS: TestAccVPCEndpointPolicy_disappears_endpoint (32.84s)
--- PASS: TestAccVPCEndpointPolicy_disappears (43.06s)
--- PASS: TestAccVPCEndpointPolicy_basic (56.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        61.257s
% make testacc PKG=ec2 TESTS="TestAccVPCRouteDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteDataSource_'  -timeout 360m

=== NAME  TestAccVPCRouteDataSource_localGatewayID
    vpc_route_data_source_test.go:113: skipping since no Outposts found
--- SKIP: TestAccVPCRouteDataSource_localGatewayID (0.82s)
=== NAME  TestAccVPCRouteDataSource_carrierGatewayID
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRouteDataSource_carrierGatewayID (0.87s)
--- PASS: TestAccVPCRouteDataSource_ipv6DestinationCIDR (17.47s)
--- PASS: TestAccVPCRouteDataSource_gatewayVPCEndpoint (31.42s)
--- PASS: TestAccVPCRouteDataSource_destinationPrefixListID (205.15s)
--- PASS: TestAccVPCRouteDataSource_transitGatewayID (323.44s)
--- PASS: TestAccVPCRouteDataSource_basic (328.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        333.378s
% make testacc PKG=ec2 TESTS="TestAccVPCRoute_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRoute_'  -timeout 360m

=== NAME  TestAccVPCRoute_ipv6ToLocalGateway
    vpc_route_test.go:1053: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_ipv6ToLocalGateway (0.83s)
=== CONT  TestAccVPCRoute_prefixListToCarrierGateway
=== NAME  TestAccVPCRoute_ipv4ToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRoute_ipv4ToCarrierGateway (0.86s)
=== CONT  TestAccVPCRoute_IPv6Update_target
=== NAME  TestAccVPCRoute_prefixListToLocalGateway
    vpc_route_test.go:2153: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_prefixListToLocalGateway (1.05s)
=== CONT  TestAccVPCRoute_ipv6ToVPCEndpoint
=== NAME  TestAccVPCRoute_prefixListToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRoute_prefixListToCarrierGateway (0.27s)
=== CONT  TestAccVPCRoute_ipv4ToVPCEndpoint
=== NAME  TestAccVPCRoute_ipv4ToLocalGateway
    vpc_route_test.go:1006: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_ipv4ToLocalGateway (6.32s)
=== CONT  TestAccVPCRoute_IPv6ToNetworkInterface_unattached
--- PASS: TestAccVPCRoute_duplicate (18.14s)
=== CONT  TestAccVPCRoute_prefixListToEgressOnlyInternetGateway
--- PASS: TestAccVPCRoute_localRouteImport (26.34s)
=== CONT  TestAccVPCRoute_ipv4ToInstance
--- PASS: TestAccVPCRoute_localRouteCreateError (28.23s)
=== CONT  TestAccVPCRoute_prefixListToNatGateway
--- PASS: TestAccVPCRoute_basic (28.35s)
=== CONT  TestAccVPCRoute_ipv4ToVPNGateway
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_unattached (29.65s)
=== CONT  TestAccVPCRoute_ipv4ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_prefixListToInternetGateway (33.11s)
=== CONT  TestAccVPCRoute_ipv6ToNatGateway
--- PASS: TestAccVPCRoute_prefixListToVPCPeeringConnection (33.81s)
=== CONT  TestAccVPCRoute_ipv4ToNatGateway
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_unattached (35.52s)
=== CONT  TestAccVPCRoute_ipv6ToVPNGateway
--- PASS: TestAccVPCRoute_doesNotCrashWithVPCEndpoint (39.97s)
=== CONT  TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRoute_IPv6ToNetworkInterface_unattached (34.35s)
=== CONT  TestAccVPCRoute_ipv6ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_ipv4ToVPCPeeringConnection (20.04s)
=== CONT  TestAccVPCRoute_ipv6ToInstance
--- PASS: TestAccVPCRoute_localRouteImportAndUpdate (53.92s)
=== CONT  TestAccVPCRoute_IPv4Update_target
--- PASS: TestAccVPCRoute_prefixListToEgressOnlyInternetGateway (37.13s)
=== CONT  TestAccVPCRoute_ipv6ToInternetGateway
--- PASS: TestAccVPCRoute_ipv6ToVPCPeeringConnection (29.68s)
=== CONT  TestAccVPCRoute_conditionalCIDRBlock
--- PASS: TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway (34.53s)
=== CONT  TestAccVPCRoute_Disappears_routeTable
--- PASS: TestAccVPCRoute_ipv6ToInternetGateway (29.42s)
=== CONT  TestAccVPCRoute_IPv4ToNetworkInterface_attached
--- PASS: TestAccVPCRoute_Disappears_routeTable (17.36s)
=== CONT  TestAccVPCRoute_disappears
--- PASS: TestAccVPCRoute_disappears (17.81s)
=== CONT  TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments
--- PASS: TestAccVPCRoute_conditionalCIDRBlock (41.35s)
--- PASS: TestAccVPCRoute_prefixListToVPNGateway (155.87s)
--- PASS: TestAccVPCRoute_ipv4ToVPNGateway (130.42s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments (67.85s)
--- PASS: TestAccVPCRoute_ipv6ToVPNGateway (180.58s)
--- PASS: TestAccVPCRoute_IPv6Update_target (216.72s)
--- PASS: TestAccVPCRoute_ipv4ToNatGateway (206.60s)
--- PASS: TestAccVPCRoute_ipv6ToNatGateway (217.00s)
--- PASS: TestAccVPCRoute_prefixListToNatGateway (227.67s)
--- PASS: TestAccVPCRoute_ipv6ToTransitGateway (311.78s)
--- PASS: TestAccVPCRoute_ipv4ToTransitGateway (311.92s)
--- PASS: TestAccVPCRoute_prefixListToTransitGateway (312.67s)
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_attached (322.36s)
--- PASS: TestAccVPCRoute_prefixListToInstance (329.05s)
--- PASS: TestAccVPCRoute_ipv4ToInstance (321.53s)
--- PASS: TestAccVPCRoute_ipv4ToVPCEndpoint (354.81s)
--- PASS: TestAccVPCRoute_ipv6ToVPCEndpoint (355.12s)
--- PASS: TestAccVPCRoute_ipv6ToInstance (321.55s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_attached (323.09s)
--- PASS: TestAccVPCRoute_IPv4Update_target (559.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        618.680s
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTable_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTable_'  -timeout 360m

=== NAME  TestAccVPCRouteTable_ipv4ToLocalGateway
    vpc_route_table_test.go:528: skipping since no Outposts found
--- SKIP: TestAccVPCRouteTable_ipv4ToLocalGateway (0.89s)
=== CONT  TestAccVPCRouteTable_tags
=== NAME  TestAccVPCRouteTable_ipv4ToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRouteTable_ipv4ToCarrierGateway (0.92s)
=== CONT  TestAccVPCRouteTable_Disappears_subnetAssociation
--- PASS: TestAccVPCRouteTable_requireRouteTarget (16.17s)
=== CONT  TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRouteTable_Disappears_subnetAssociation (25.59s)
=== CONT  TestAccVPCRouteTable_ipv4ToInternetGateway
--- PASS: TestAccVPCRouteTable_localRoute (27.40s)
=== CONT  TestAccVPCRouteTable_multipleRoutes
--- PASS: TestAccVPCRouteTable_basic (27.66s)
=== CONT  TestAccVPCRouteTable_disappears
--- PASS: TestAccVPCRouteTable_ipv4ToVPCPeeringConnection (29.30s)
=== CONT  TestAccVPCRouteTable_localRouteAdoptUpdate
--- PASS: TestAccVPCRouteTable_prefixListToInternetGateway (34.82s)
--- PASS: TestAccVPCRouteTable_gatewayVPCEndpoint (40.27s)
--- PASS: TestAccVPCRouteTable_IPv6ToNetworkInterface_unattached (41.95s)
--- PASS: TestAccVPCRouteTable_disappears (18.65s)
--- PASS: TestAccVPCRouteTable_vpcMultipleCIDRs (48.75s)
--- PASS: TestAccVPCRouteTable_conditionalCIDRBlock (51.75s)
--- PASS: TestAccVPCRouteTable_tags (51.31s)
--- PASS: TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway (36.87s)
--- PASS: TestAccVPCRouteTable_Route_mode (58.10s)
--- PASS: TestAccVPCRouteTable_ipv4ToInternetGateway (32.69s)
--- PASS: TestAccVPCRouteTable_IPv4ToNetworkInterfaces_unattached (70.76s)
--- PASS: TestAccVPCRouteTable_localRouteAdoptUpdate (49.88s)
--- PASS: TestAccVPCRouteTable_localRouteImportUpdate (80.24s)
--- PASS: TestAccVPCRouteTable_multipleRoutes (155.59s)
--- PASS: TestAccVPCRouteTable_ipv4ToNatGateway (193.55s)
--- PASS: TestAccVPCRouteTable_vgwRoutePropagation (274.41s)
--- PASS: TestAccVPCRouteTable_ipv4ToTransitGateway (312.86s)
--- PASS: TestAccVPCRouteTable_ipv4ToInstance (332.41s)
--- PASS: TestAccVPCRouteTable_requireRouteDestination (338.51s)
--- PASS: TestAccVPCRouteTable_ipv4ToVPCEndpoint (367.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        373.221s
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTableAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableAssociation_'  -timeout 360m

--- PASS: TestAccVPCRouteTableAssociation_disappears (20.24s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (22.13s)
--- PASS: TestAccVPCRouteTableAssociation_Gateway_basic (23.73s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_changeRouteTable (32.20s)
--- PASS: TestAccVPCRouteTableAssociation_Gateway_changeRouteTable (35.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        40.378s
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTableDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableDataSource_'  -timeout 360m

--- PASS: TestAccVPCRouteTableDataSource_main (12.71s)
--- PASS: TestAccVPCRouteTableDataSource_basic (17.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        22.270s
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTablesDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTablesDataSource_'  -timeout 360m

--- PASS: TestAccVPCRouteTablesDataSource_basic (16.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        21.118s
%  make testacc PKG=ec2 TESTS="TestAccVPCDefaultRouteTable_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCDefaultRouteTable_'  -timeout 360m

--- PASS: TestAccVPCDefaultRouteTable_Disappears_vpc (15.78s)
--- PASS: TestAccVPCDefaultRouteTable_basic (23.28s)
--- PASS: TestAccVPCDefaultRouteTable_vpcEndpointAssociation (30.02s)
--- PASS: TestAccVPCDefaultRouteTable_tags (35.38s)
--- PASS: TestAccVPCDefaultRouteTable_prefixListToInternetGateway (37.40s)
--- PASS: TestAccVPCDefaultRouteTable_conditionalCIDRBlock (42.21s)
--- PASS: TestAccVPCDefaultRouteTable_Route_mode (48.90s)
--- PASS: TestAccVPCDefaultRouteTable_swap (57.83s)
--- PASS: TestAccVPCDefaultRouteTable_revokeExistingRules (111.44s)
=== NAME  TestAccVPCDefaultRouteTable_ipv4ToVPCEndpoint
    vpc_default_route_table_test.go:284: Step 1/3 error: Error running apply: exit status 1

        Error: modifying EC2 VPC Endpoint Service (vpce-svc-0182916f82dfce5bc) permissions: InvalidPrincipal: Invalid Principal: 'arn:aws:sts::727561393803:assumed-role/tf_aws_provider3_test-admin/[email protected]'
                status code: 400, request id: 124fc972-f18f-45fc-9cea-d1ba64a98108

          with aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 59, in resource "aws_vpc_endpoint_service" "test":
          59: resource "aws_vpc_endpoint_service" "test" {

--- FAIL: TestAccVPCDefaultRouteTable_ipv4ToVPCEndpoint (193.01s)
--- PASS: TestAccVPCDefaultRouteTable_ipv4ToTransitGateway (317.38s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        322.446s

Note: failing test is due to permissions on the test account user, and does not fail in TeamCity.

% make testacc PKG=ec2 TESTS="TestAccSiteVPNGatewayRoutePropagation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNGatewayRoutePropagation_'  -timeout 360m

--- PASS: TestAccSiteVPNGatewayRoutePropagation_basic (116.87s)
--- PASS: TestAccSiteVPNGatewayRoutePropagation_disappears (117.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        122.456s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointService_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointService_'  -timeout 360m

--- PASS: TestAccVPCEndpointService_basic (222.92s)
--- PASS: TestAccVPCEndpointService_disappears (230.67s)
--- PASS: TestAccVPCEndpointService_tags (237.87s)
--- PASS: TestAccVPCEndpointService_privateDNSName (240.51s)
--- PASS: TestAccVPCEndpointService_allowedPrincipals (257.55s)
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (261.17s)
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (345.01s)
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (424.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        429.837s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServiceDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServiceDataSource_'  -timeout 360m

--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_interface (9.56s)
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (9.56s)
--- PASS: TestAccVPCEndpointServiceDataSource_custom (240.44s)
--- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (246.50s)
--- PASS: TestAccVPCEndpointServiceDataSource_Custom_filter (246.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        251.682s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointRouteTableAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointRouteTableAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointRouteTableAssociation_disappears (27.88s)
--- PASS: TestAccVPCEndpointRouteTableAssociation_basic (29.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        34.605s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointSecurityGroupAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointSecurityGroupAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (89.73s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (110.24s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (114.94s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (121.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        126.457s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointSubnetAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointSubnetAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointSubnetAssociation_basic (232.03s)
--- PASS: TestAccVPCEndpointSubnetAssociation_disappears (236.22s)
--- PASS: TestAccVPCEndpointSubnetAssociation_multiple (396.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        402.119s
% AWS_ALTERNATE_PROFILE=<redacted> make testacc PKG=ec2 TESTS="TestAccVPCEndpointConnectionAccepter_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointConnectionAccepter_'  -timeout 360m
=== RUN   TestAccVPCEndpointConnectionAccepter_crossAccount
--- PASS: TestAccVPCEndpointConnectionAccepter_crossAccount (341.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        346.795s
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServiceAllowedPrincipal_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServiceAllowedPrincipal_'  -timeout 360m

--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (211.30s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_multiple (220.94s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_tags (231.80s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateID (236.87s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag (247.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        252.532s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 15, 2024
@jar-b jar-b force-pushed the td-vpc_endpoint-awssdkv2 branch 2 times, most recently from 29271d0 to 05dba87 Compare May 15, 2024 18:34
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. labels May 15, 2024
@jar-b jar-b force-pushed the td-vpc_endpoint-awssdkv2 branch 4 times, most recently from e4f282e to 126f72f Compare May 16, 2024 15:43
jar-b added 16 commits May 16, 2024 13:53
@jar-b
d/aws_vpc_prefix_list: covert to aws sdk v2
bc17bd6 
```console
% make testacc PKG=ec2 TESTS=TestAccVPCPrefixListDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCPrefixListDataSource_'  -timeout 360m

--- PASS: TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter (2.52s)
--- PASS: TestAccVPCPrefixListDataSource_basic (10.11s)
--- PASS: TestAccVPCPrefixListDataSource_filter (10.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        15.365s
```
@jar-b
r/aws_vpc_endpoint: convert to aws sdk v2
7c3f580 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpoint_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_'  -timeout 360m

--- PASS: TestAccVPCEndpoint_disappears (29.07s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (32.14s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (40.80s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (53.07s)
--- PASS: TestAccVPCEndpoint_tags (53.39s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (55.01s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (91.67s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (242.83s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (262.97s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (281.69s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (330.89s)
--- PASS: TestAccVPCEndpoint_ipAddressType (331.40s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNSNoGateway (459.27s)
--- PASS: TestAccVPCEndpoint_interfacePrivateDNS (522.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        527.229s
```
@jar-b
d/aws_vpc_endpoint: convert to aws sdk v2
eb23ecd 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointDataSource_'  -timeout 360m

--- PASS: TestAccVPCEndpointDataSource_byID (27.48s)
--- PASS: TestAccVPCEndpointDataSource_byTags (27.48s)
--- PASS: TestAccVPCEndpointDataSource_byFilter (27.48s)
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (27.48s)
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (41.96s)
--- PASS: TestAccVPCEndpointDataSource_interface (113.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        119.189s
```
@jar-b
r/aws_vpc_endpoint_policy: convert to aws sdk v2
aeba401 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointPolicy_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointPolicy_'  -timeout 360m

--- PASS: TestAccVPCEndpointPolicy_disappears_endpoint (32.84s)
--- PASS: TestAccVPCEndpointPolicy_disappears (43.06s)
--- PASS: TestAccVPCEndpointPolicy_basic (56.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        61.257s
```
@jar-b
d/aws_vpc_route: convert to aws sdk v2
4aaa59a 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRouteDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteDataSource_'  -timeout 360m

=== NAME  TestAccVPCRouteDataSource_localGatewayID
    vpc_route_data_source_test.go:113: skipping since no Outposts found
--- SKIP: TestAccVPCRouteDataSource_localGatewayID (0.82s)
=== NAME  TestAccVPCRouteDataSource_carrierGatewayID
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRouteDataSource_carrierGatewayID (0.87s)
--- PASS: TestAccVPCRouteDataSource_ipv6DestinationCIDR (17.47s)
--- PASS: TestAccVPCRouteDataSource_gatewayVPCEndpoint (31.42s)
--- PASS: TestAccVPCRouteDataSource_destinationPrefixListID (205.15s)
--- PASS: TestAccVPCRouteDataSource_transitGatewayID (323.44s)
--- PASS: TestAccVPCRouteDataSource_basic (328.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        333.378s
```
@jar-b
r/aws_vpc_route: convert to aws sdk v2
c65ba68 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRoute_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRoute_'  -timeout 360m

=== NAME  TestAccVPCRoute_ipv6ToLocalGateway
    vpc_route_test.go:1053: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_ipv6ToLocalGateway (0.83s)
=== CONT  TestAccVPCRoute_prefixListToCarrierGateway
=== NAME  TestAccVPCRoute_ipv4ToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRoute_ipv4ToCarrierGateway (0.86s)
=== CONT  TestAccVPCRoute_IPv6Update_target
=== NAME  TestAccVPCRoute_prefixListToLocalGateway
    vpc_route_test.go:2153: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_prefixListToLocalGateway (1.05s)
=== CONT  TestAccVPCRoute_ipv6ToVPCEndpoint
=== NAME  TestAccVPCRoute_prefixListToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRoute_prefixListToCarrierGateway (0.27s)
=== CONT  TestAccVPCRoute_ipv4ToVPCEndpoint
=== NAME  TestAccVPCRoute_ipv4ToLocalGateway
    vpc_route_test.go:1006: skipping since no Outposts found
--- SKIP: TestAccVPCRoute_ipv4ToLocalGateway (6.32s)
=== CONT  TestAccVPCRoute_IPv6ToNetworkInterface_unattached
--- PASS: TestAccVPCRoute_duplicate (18.14s)
=== CONT  TestAccVPCRoute_prefixListToEgressOnlyInternetGateway
--- PASS: TestAccVPCRoute_localRouteImport (26.34s)
=== CONT  TestAccVPCRoute_ipv4ToInstance
--- PASS: TestAccVPCRoute_localRouteCreateError (28.23s)
=== CONT  TestAccVPCRoute_prefixListToNatGateway
--- PASS: TestAccVPCRoute_basic (28.35s)
=== CONT  TestAccVPCRoute_ipv4ToVPNGateway
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_unattached (29.65s)
=== CONT  TestAccVPCRoute_ipv4ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_prefixListToInternetGateway (33.11s)
=== CONT  TestAccVPCRoute_ipv6ToNatGateway
--- PASS: TestAccVPCRoute_prefixListToVPCPeeringConnection (33.81s)
=== CONT  TestAccVPCRoute_ipv4ToNatGateway
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_unattached (35.52s)
=== CONT  TestAccVPCRoute_ipv6ToVPNGateway
--- PASS: TestAccVPCRoute_doesNotCrashWithVPCEndpoint (39.97s)
=== CONT  TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRoute_IPv6ToNetworkInterface_unattached (34.35s)
=== CONT  TestAccVPCRoute_ipv6ToVPCPeeringConnection
--- PASS: TestAccVPCRoute_ipv4ToVPCPeeringConnection (20.04s)
=== CONT  TestAccVPCRoute_ipv6ToInstance
--- PASS: TestAccVPCRoute_localRouteImportAndUpdate (53.92s)
=== CONT  TestAccVPCRoute_IPv4Update_target
--- PASS: TestAccVPCRoute_prefixListToEgressOnlyInternetGateway (37.13s)
=== CONT  TestAccVPCRoute_ipv6ToInternetGateway
--- PASS: TestAccVPCRoute_ipv6ToVPCPeeringConnection (29.68s)
=== CONT  TestAccVPCRoute_conditionalCIDRBlock
--- PASS: TestAccVPCRoute_ipv6ToEgressOnlyInternetGateway (34.53s)
=== CONT  TestAccVPCRoute_Disappears_routeTable
--- PASS: TestAccVPCRoute_ipv6ToInternetGateway (29.42s)
=== CONT  TestAccVPCRoute_IPv4ToNetworkInterface_attached
--- PASS: TestAccVPCRoute_Disappears_routeTable (17.36s)
=== CONT  TestAccVPCRoute_disappears
--- PASS: TestAccVPCRoute_disappears (17.81s)
=== CONT  TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments
--- PASS: TestAccVPCRoute_conditionalCIDRBlock (41.35s)
--- PASS: TestAccVPCRoute_prefixListToVPNGateway (155.87s)
--- PASS: TestAccVPCRoute_ipv4ToVPNGateway (130.42s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_twoAttachments (67.85s)
--- PASS: TestAccVPCRoute_ipv6ToVPNGateway (180.58s)
--- PASS: TestAccVPCRoute_IPv6Update_target (216.72s)
--- PASS: TestAccVPCRoute_ipv4ToNatGateway (206.60s)
--- PASS: TestAccVPCRoute_ipv6ToNatGateway (217.00s)
--- PASS: TestAccVPCRoute_prefixListToNatGateway (227.67s)
--- PASS: TestAccVPCRoute_ipv6ToTransitGateway (311.78s)
--- PASS: TestAccVPCRoute_ipv4ToTransitGateway (311.92s)
--- PASS: TestAccVPCRoute_prefixListToTransitGateway (312.67s)
--- PASS: TestAccVPCRoute_PrefixListToNetworkInterface_attached (322.36s)
--- PASS: TestAccVPCRoute_prefixListToInstance (329.05s)
--- PASS: TestAccVPCRoute_ipv4ToInstance (321.53s)
--- PASS: TestAccVPCRoute_ipv4ToVPCEndpoint (354.81s)
--- PASS: TestAccVPCRoute_ipv6ToVPCEndpoint (355.12s)
--- PASS: TestAccVPCRoute_ipv6ToInstance (321.55s)
--- PASS: TestAccVPCRoute_IPv4ToNetworkInterface_attached (323.09s)
--- PASS: TestAccVPCRoute_IPv4Update_target (559.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        618.680s
```
@jar-b
r/aws_vpc_route_table: convert to aws sdk v2
ecd5c82 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTable_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTable_'  -timeout 360m

=== NAME  TestAccVPCRouteTable_ipv4ToLocalGateway
    vpc_route_table_test.go:528: skipping since no Outposts found
--- SKIP: TestAccVPCRouteTable_ipv4ToLocalGateway (0.89s)
=== CONT  TestAccVPCRouteTable_tags
=== NAME  TestAccVPCRouteTable_ipv4ToCarrierGateway
    wavelength_carrier_gateway_test.go:197: skipping since no Wavelength Zones are available
--- SKIP: TestAccVPCRouteTable_ipv4ToCarrierGateway (0.92s)
=== CONT  TestAccVPCRouteTable_Disappears_subnetAssociation
--- PASS: TestAccVPCRouteTable_requireRouteTarget (16.17s)
=== CONT  TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRouteTable_Disappears_subnetAssociation (25.59s)
=== CONT  TestAccVPCRouteTable_ipv4ToInternetGateway
--- PASS: TestAccVPCRouteTable_localRoute (27.40s)
=== CONT  TestAccVPCRouteTable_multipleRoutes
--- PASS: TestAccVPCRouteTable_basic (27.66s)
=== CONT  TestAccVPCRouteTable_disappears
--- PASS: TestAccVPCRouteTable_ipv4ToVPCPeeringConnection (29.30s)
=== CONT  TestAccVPCRouteTable_localRouteAdoptUpdate
--- PASS: TestAccVPCRouteTable_prefixListToInternetGateway (34.82s)
--- PASS: TestAccVPCRouteTable_gatewayVPCEndpoint (40.27s)
--- PASS: TestAccVPCRouteTable_IPv6ToNetworkInterface_unattached (41.95s)
--- PASS: TestAccVPCRouteTable_disappears (18.65s)
--- PASS: TestAccVPCRouteTable_vpcMultipleCIDRs (48.75s)
--- PASS: TestAccVPCRouteTable_conditionalCIDRBlock (51.75s)
--- PASS: TestAccVPCRouteTable_tags (51.31s)
--- PASS: TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway (36.87s)
--- PASS: TestAccVPCRouteTable_Route_mode (58.10s)
--- PASS: TestAccVPCRouteTable_ipv4ToInternetGateway (32.69s)
--- PASS: TestAccVPCRouteTable_IPv4ToNetworkInterfaces_unattached (70.76s)
--- PASS: TestAccVPCRouteTable_localRouteAdoptUpdate (49.88s)
--- PASS: TestAccVPCRouteTable_localRouteImportUpdate (80.24s)
--- PASS: TestAccVPCRouteTable_multipleRoutes (155.59s)
--- PASS: TestAccVPCRouteTable_ipv4ToNatGateway (193.55s)
--- PASS: TestAccVPCRouteTable_vgwRoutePropagation (274.41s)
--- PASS: TestAccVPCRouteTable_ipv4ToTransitGateway (312.86s)
--- PASS: TestAccVPCRouteTable_ipv4ToInstance (332.41s)
--- PASS: TestAccVPCRouteTable_requireRouteDestination (338.51s)
--- PASS: TestAccVPCRouteTable_ipv4ToVPCEndpoint (367.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        373.221s
```
@jar-b
r/aws_vpc_route_table_association: convert to aws sdk v2
0a5584a 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTableAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableAssociation_'  -timeout 360m

--- PASS: TestAccVPCRouteTableAssociation_disappears (20.24s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (22.13s)
--- PASS: TestAccVPCRouteTableAssociation_Gateway_basic (23.73s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_changeRouteTable (32.20s)
--- PASS: TestAccVPCRouteTableAssociation_Gateway_changeRouteTable (35.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        40.378s
```
@jar-b
d/aws_vpc_route_table: convert to aws sdk v2
3b11a74 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTableDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTableDataSource_'  -timeout 360m

--- PASS: TestAccVPCRouteTableDataSource_main (12.71s)
--- PASS: TestAccVPCRouteTableDataSource_basic (17.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        22.270s
```
@jar-b
d/aws_vpc_route_tables: convert to aws sdk v2
785a3b0 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCRouteTablesDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCRouteTablesDataSource_'  -timeout 360m

--- PASS: TestAccVPCRouteTablesDataSource_basic (16.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        21.118s
```
@jar-b
r/aws_vpc_default_route_table: convert to aws sdk v2
02737ad 
```console
%  make testacc PKG=ec2 TESTS="TestAccVPCDefaultRouteTable_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCDefaultRouteTable_'  -timeout 360m

--- PASS: TestAccVPCDefaultRouteTable_Disappears_vpc (15.78s)
--- PASS: TestAccVPCDefaultRouteTable_basic (23.28s)
--- PASS: TestAccVPCDefaultRouteTable_vpcEndpointAssociation (30.02s)
--- PASS: TestAccVPCDefaultRouteTable_tags (35.38s)
--- PASS: TestAccVPCDefaultRouteTable_prefixListToInternetGateway (37.40s)
--- PASS: TestAccVPCDefaultRouteTable_conditionalCIDRBlock (42.21s)
--- PASS: TestAccVPCDefaultRouteTable_Route_mode (48.90s)
--- PASS: TestAccVPCDefaultRouteTable_swap (57.83s)
--- PASS: TestAccVPCDefaultRouteTable_revokeExistingRules (111.44s)
=== NAME  TestAccVPCDefaultRouteTable_ipv4ToVPCEndpoint
    vpc_default_route_table_test.go:284: Step 1/3 error: Error running apply: exit status 1

        Error: modifying EC2 VPC Endpoint Service (vpce-svc-0182916f82dfce5bc) permissions: InvalidPrincipal: Invalid Principal: 'arn:aws:sts::727561393803:assumed-role/tf_aws_provider3_test-admin/[email protected]'
                status code: 400, request id: 124fc972-f18f-45fc-9cea-d1ba64a98108

          with aws_vpc_endpoint_service.test,
          on terraform_plugin_test.tf line 59, in resource "aws_vpc_endpoint_service" "test":
          59: resource "aws_vpc_endpoint_service" "test" {

--- FAIL: TestAccVPCDefaultRouteTable_ipv4ToVPCEndpoint (193.01s)
--- PASS: TestAccVPCDefaultRouteTable_ipv4ToTransitGateway (317.38s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/ec2        322.446s
```

Note: failing test is due to permissions on the test account user, and does not
fail in CI.
@jar-b
r/aws_vpnsite_gateway_route_propagation: convert to aws sdk v2
e0263d0 
```console
% make testacc PKG=ec2 TESTS="TestAccSiteVPNGatewayRoutePropagation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNGatewayRoutePropagation_'  -timeout 360m

--- PASS: TestAccSiteVPNGatewayRoutePropagation_basic (116.87s)
--- PASS: TestAccSiteVPNGatewayRoutePropagation_disappears (117.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        122.456s
```
@jar-b
r/aws_vpc_endpoint_service: convert to aws sdk v2
66367c2 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointService_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointService_'  -timeout 360m

--- PASS: TestAccVPCEndpointService_basic (222.92s)
--- PASS: TestAccVPCEndpointService_disappears (230.67s)
--- PASS: TestAccVPCEndpointService_tags (237.87s)
--- PASS: TestAccVPCEndpointService_privateDNSName (240.51s)
--- PASS: TestAccVPCEndpointService_allowedPrincipals (257.55s)
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (261.17s)
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (345.01s)
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (424.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        429.837s
```
@jar-b
internal/generate/listpages: optional -V2Suffix flag
a81353f 
This flag adds the ability to append a `V2` suffix in cases where both V1 and V2 variants of the generated function name may be required.
@jar-b
d/aws_vpc_endpoint_service: convert to aws sdk v2
033c7ee 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServiceDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServiceDataSource_'  -timeout 360m

--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_interface (9.56s)
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (9.56s)
--- PASS: TestAccVPCEndpointServiceDataSource_custom (240.44s)
--- PASS: TestAccVPCEndpointServiceDataSource_CustomFilter_tags (246.50s)
--- PASS: TestAccVPCEndpointServiceDataSource_Custom_filter (246.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        251.682s
```
@jar-b
r/aws_vpc_endpoint_route_table_association: convert to aws sdk v2
6c9e653 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointRouteTableAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointRouteTableAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointRouteTableAssociation_disappears (27.88s)
--- PASS: TestAccVPCEndpointRouteTableAssociation_basic (29.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        34.605s
```
jar-b added 5 commits May 16, 2024 13:53
@jar-b
r/aws_vpc_endpoint_security_group_association: convert to aws sdk v2
4a6b463 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointSecurityGroupAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointSecurityGroupAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (89.73s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (110.24s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (114.94s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (121.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        126.457s
```
@jar-b
r/aws_vpc_endpoint_subnet_association: convert to aws sdk v2
543bbdc 
```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointSubnetAssociation_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointSubnetAssociation_'  -timeout 360m

--- PASS: TestAccVPCEndpointSubnetAssociation_basic (232.03s)
--- PASS: TestAccVPCEndpointSubnetAssociation_disappears (236.22s)
--- PASS: TestAccVPCEndpointSubnetAssociation_multiple (396.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        402.119s
```
@jar-b
r/aws_vpc_endpoint_connection_accepter: convert to aws sdk v2
e9e418a 
```console
% AWS_ALTERNATE_PROFILE=<redacted> make testacc PKG=ec2 TESTS="TestAccVPCEndpointConnectionAccepter_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointConnectionAccepter_'  -timeout 360m
=== RUN   TestAccVPCEndpointConnectionAccepter_crossAccount
--- PASS: TestAccVPCEndpointConnectionAccepter_crossAccount (341.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        346.795s
```
@jar-b
r/aws_vpc_endpoint_connection_notification: convert to aws sdk v2
8381af5 
Note: acceptance tests fail locally with an IAM permissions issue, but should pass in TeamCity.
@jar-b
r/aws_vpc_endpoint_connection_service_allowed_principal: convert to a…
aac92c3 
…ws sdk v2

```console
% make testacc PKG=ec2 TESTS="TestAccVPCEndpointServiceAllowedPrincipal_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointServiceAllowedPrincipal_'  -timeout 360m

--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_basic (211.30s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_multiple (220.94s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_tags (231.80s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateID (236.87s)
--- PASS: TestAccVPCEndpointServiceAllowedPrincipal_migrateAndTag (247.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        252.532s
```
@jar-b jar-b force-pushed the td-vpc_endpoint-awssdkv2 branch from 126f72f to aac92c3 Compare May 16, 2024 17:53
@jar-b jar-b marked this pull request as ready for review May 16, 2024 18:34
@jar-b jar-b merged commit bd872a3 into main May 16, 2024
55 checks passed
@jar-b jar-b deleted the td-vpc_endpoint-awssdkv2 branch May 16, 2024 18:37
@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
github-actions bot pushed a commit that referenced this pull request May 16, 2024
Update CHANGELOG.md for #37534
6266a34
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jar-b