r/kms_key: add support for rotation_period_in_days

[aristosvo]

Description

rotation_period_in_days enables a custom rotation period when you enable key rotation.

I've included it as an argument instead of using a separate resource, as enablement of key rotation was already included in the aws_kms_key resource.

Edit: I've rebased on main as #37092 is now merged

Relations

Closes #36948

References

RotationPeriodInDays AWS docs

Output from Acceptance Testing

% make testacc TESTS=TestAccKMSKey_rotation PKG=kms 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSKey_rotation'  -timeout 360m
=== RUN   TestAccKMSKey_rotation
=== PAUSE TestAccKMSKey_rotation
=== CONT  TestAccKMSKey_rotation
--- PASS: TestAccKMSKey_rotation (44.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        48.404s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[aristosvo]

Rebased based on main as #37092 is now merged.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKMSKey_' PKG=kms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/kms/... -v -count 1 -parallel 3  -run=TestAccKMSKey_ -timeout 720m
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== RUN   TestAccKMSKey_disappears
=== PAUSE TestAccKMSKey_disappears
=== RUN   TestAccKMSKey_multiRegion
=== PAUSE TestAccKMSKey_multiRegion
=== RUN   TestAccKMSKey_asymmetricKey
=== PAUSE TestAccKMSKey_asymmetricKey
=== RUN   TestAccKMSKey_hmacKey
=== PAUSE TestAccKMSKey_hmacKey
=== RUN   TestAccKMSKey_Policy_basic
=== PAUSE TestAccKMSKey_Policy_basic
=== RUN   TestAccKMSKey_Policy_bypass
=== PAUSE TestAccKMSKey_Policy_bypass
=== RUN   TestAccKMSKey_Policy_bypassUpdate
=== PAUSE TestAccKMSKey_Policy_bypassUpdate
=== RUN   TestAccKMSKey_Policy_iamRole
=== PAUSE TestAccKMSKey_Policy_iamRole
=== RUN   TestAccKMSKey_Policy_iamRoleUpdate
=== PAUSE TestAccKMSKey_Policy_iamRoleUpdate
=== RUN   TestAccKMSKey_Policy_iamRoleOrder
=== PAUSE TestAccKMSKey_Policy_iamRoleOrder
=== RUN   TestAccKMSKey_Policy_iamServiceLinkedRole
=== PAUSE TestAccKMSKey_Policy_iamServiceLinkedRole
=== RUN   TestAccKMSKey_Policy_booleanCondition
=== PAUSE TestAccKMSKey_Policy_booleanCondition
=== RUN   TestAccKMSKey_isEnabled
=== PAUSE TestAccKMSKey_isEnabled
=== RUN   TestAccKMSKey_rotation
=== PAUSE TestAccKMSKey_rotation
=== RUN   TestAccKMSKey_tags
=== PAUSE TestAccKMSKey_tags
=== RUN   TestAccKMSKey_ignoreTags
=== PAUSE TestAccKMSKey_ignoreTags
=== RUN   TestAccKMSKey_updateTagsEmptyValue
=== PAUSE TestAccKMSKey_updateTagsEmptyValue
=== CONT  TestAccKMSKey_basic
=== CONT  TestAccKMSKey_Policy_iamRoleUpdate
=== CONT  TestAccKMSKey_Policy_basic
--- PASS: TestAccKMSKey_basic (38.20s)
=== CONT  TestAccKMSKey_Policy_bypassUpdate
--- PASS: TestAccKMSKey_Policy_basic (41.78s)
=== CONT  TestAccKMSKey_Policy_iamRole
--- PASS: TestAccKMSKey_Policy_iamRoleUpdate (53.85s)
=== CONT  TestAccKMSKey_rotation
--- PASS: TestAccKMSKey_Policy_bypassUpdate (39.18s)
=== CONT  TestAccKMSKey_updateTagsEmptyValue
--- PASS: TestAccKMSKey_Policy_iamRole (37.94s)
=== CONT  TestAccKMSKey_ignoreTags
--- PASS: TestAccKMSKey_rotation (59.19s)
=== CONT  TestAccKMSKey_tags
--- PASS: TestAccKMSKey_updateTagsEmptyValue (43.68s)
=== CONT  TestAccKMSKey_Policy_bypass
--- PASS: TestAccKMSKey_ignoreTags (54.16s)
=== CONT  TestAccKMSKey_Policy_booleanCondition
--- PASS: TestAccKMSKey_Policy_booleanCondition (21.87s)
=== CONT  TestAccKMSKey_isEnabled
--- PASS: TestAccKMSKey_tags (80.34s)
=== CONT  TestAccKMSKey_asymmetricKey
--- PASS: TestAccKMSKey_asymmetricKey (16.75s)
=== CONT  TestAccKMSKey_hmacKey
--- PASS: TestAccKMSKey_hmacKey (16.13s)
=== CONT  TestAccKMSKey_Policy_iamServiceLinkedRole
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (44.01s)
=== CONT  TestAccKMSKey_Policy_iamRoleOrder
--- PASS: TestAccKMSKey_Policy_bypass (153.01s)
=== CONT  TestAccKMSKey_multiRegion
--- PASS: TestAccKMSKey_isEnabled (122.18s)
=== CONT  TestAccKMSKey_disappears
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (54.43s)
--- PASS: TestAccKMSKey_disappears (18.95s)
--- PASS: TestAccKMSKey_multiRegion (23.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	307.830s

[ewbankkit]

@aristosvo Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.