-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_route: Don't fail on Create if there's already a propagated (or local) route to the same destination #36512
Conversation
…te to the same destination.
% make testacc TESTARGS='-run=TestAccVPCRoute_localRouteError' PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCRoute_localRouteError -timeout 360m === RUN TestAccVPCRoute_localRouteError === PAUSE TestAccVPCRoute_localRouteError === CONT TestAccVPCRoute_localRouteError vpc_route_test.go:1687: Step 2/2, expected an error with pattern, no match on: Error running apply: exit status 1 Error: RouteAlreadyExists: Route in Route Table (rtb-05af6f646b345080f) with destination (10.1.0.0/16) already exists with aws_route.test, on terraform_plugin_test.tf line 28, in resource "aws_route" "test": 28: resource "aws_route" "test" { --- FAIL: TestAccVPCRoute_localRouteError (28.74s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 40.395s FAIL make: *** [testacc] Error 1
…ute-duplicate-route-propagation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTARGS='-run=TestAccVPCRoute_localRoute\|TestAccVPCRoute_basic\|TestAccVPCRoute_duplicate' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCRoute_localRoute\|TestAccVPCRoute_basic\|TestAccVPCRoute_duplicate -timeout 360m
=== RUN TestAccVPCRoute_basic
=== PAUSE TestAccVPCRoute_basic
=== RUN TestAccVPCRoute_localRouteCreateError
=== PAUSE TestAccVPCRoute_localRouteCreateError
=== RUN TestAccVPCRoute_localRouteImport
=== PAUSE TestAccVPCRoute_localRouteImport
=== RUN TestAccVPCRoute_localRouteImportAndUpdate
=== PAUSE TestAccVPCRoute_localRouteImportAndUpdate
=== RUN TestAccVPCRoute_duplicate
=== PAUSE TestAccVPCRoute_duplicate
=== CONT TestAccVPCRoute_basic
=== CONT TestAccVPCRoute_localRouteImportAndUpdate
=== CONT TestAccVPCRoute_localRouteImport
=== CONT TestAccVPCRoute_duplicate
=== CONT TestAccVPCRoute_localRouteCreateError
--- PASS: TestAccVPCRoute_duplicate (16.17s)
--- PASS: TestAccVPCRoute_localRouteImport (26.87s)
--- PASS: TestAccVPCRoute_basic (27.38s)
--- PASS: TestAccVPCRoute_localRouteCreateError (29.35s)
--- PASS: TestAccVPCRoute_localRouteImportAndUpdate (55.34s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 57.809s
This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Allow creation of a route if there's already a VGW propagated route (or VPC-local) route to the same destination.
Relations
Closes #36510.
Relates #36326.
Output from Acceptance Testing
Without the fix: