Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enabling primary ipv6 address on EC2 instance #36425

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add support for enabling primary ipv6 address on EC2 instance #36425

wants to merge 8 commits into from
+106 −1

Conversation

arianvp
Copy link
Contributor

@arianvp arianvp commented Mar 16, 2024 •
edited
Loading

Description

This PR adds support for Primary IPv6 Addresses.

When the boolean enable_primary_ipv6 is set; the first ipv6 address of the first interface is marked as the primary address.

Setting this boolean makes sure that the assigned Ipv6 address of the instance never changes. This is a prerequisite to use and instance in an IPv6 subnet with an IPv6 ELB target group (#35010 #36423 )

This option can not be undone. The address stays immutable. Though I'm not sure how to model set-once options in terraform. Feedback appreciated.

Relations

Closes #36424

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@arianvp
ec2/launch_template: add support for enable_primary_ipv6
162a6a3
@arianvp
ec2_instance: Add enable_primary_ipv6 field
d9c6520 
The first ipv6 address will be marked immutable and can not be removed
untill the instance is terminated
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/vpc Issues and PRs that pertain to the vpc service. labels Mar 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2024
@arianvp arianvp changed the title Enable primary ipv6 Add support for enabling primary ipv6 address on EC2 instance Mar 17, 2024
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 17, 2024
@arianvp
Fix launch template nullable bool
d2c1a99
@arianvp
Enable ForceNew for enable_primary_ipv6
d7fd68e 
Once this boolean is set to true it can not be set to false without
recreating the network interface.

IDK how to model it being false by default though
@arianvp
add AtLeastOneOf
c39f0cf
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 18, 2024
@ankon
Copy link
Contributor

ankon commented Apr 11, 2024

@justinretzolk anything we can help to land this?

@ankon ankon mentioned this pull request Apr 29, 2024
Merged
@arianvp
Copy link
Contributor Author

arianvp commented Jun 16, 2024

Any update on this? I really would like this to be in. Anything I can do to make this easier to merge or review? Thanks

@arianvp arianvp mentioned this pull request Jul 17, 2024
Open
@ankon
Copy link
Contributor

ankon commented Aug 7, 2024

Now that #37142 has landed, this one needs to be rebased & adapted to that, and basically is now "do the same thing, for VPC network interfaces & ec2 instances, please"?

@arianvp
Copy link
Contributor Author

arianvp commented Aug 7, 2024

Yep seems like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
3 participants
@arianvp @ankon @justinretzolk