Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified Access: Limit acceptance test concurrency #35769

Merged
merged 14 commits into from
Feb 12, 2024
Merged

Verified Access: Limit acceptance test concurrency #35769

merged 14 commits into from
Feb 12, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 12, 2024 •
edited
Loading

Description

Limits aws_verifiedaccess_* acceptance test concurrency using the same mechanism as Client VPN.
Fixes:

Error: creating Verified Access Instance: operation error EC2: CreateVerifiedAccessInstance, https response error StatusCode: 400, RequestID: ..., api error VerifiedAccessInstanceLimitExceeded: The number of instances you have are exceeding your current defined limit

Relations

Closes #33768.
Relates #35747.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial' PKG=ec2                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccess_serial -timeout 360m
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/Group_tags
=== PAUSE TestAccVerifiedAccess_serial/Group_tags
=== RUN   TestAccVerifiedAccess_serial/Group_policy
=== PAUSE TestAccVerifiedAccess_serial/Group_policy
=== RUN   TestAccVerifiedAccess_serial/Group_updatePolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_updatePolicy
=== RUN   TestAccVerifiedAccess_serial/Group_setPolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_setPolicy
=== RUN   TestAccVerifiedAccess_serial/Group_basic
=== PAUSE TestAccVerifiedAccess_serial/Group_basic
=== RUN   TestAccVerifiedAccess_serial/Group_kms
=== PAUSE TestAccVerifiedAccess_serial/Group_kms
=== RUN   TestAccVerifiedAccess_serial/Group_updateKMS
=== PAUSE TestAccVerifiedAccess_serial/Group_updateKMS
=== RUN   TestAccVerifiedAccess_serial/Group_disappears
=== PAUSE TestAccVerifiedAccess_serial/Group_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_description
=== PAUSE TestAccVerifiedAccess_serial/Instance_description
=== RUN   TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== PAUSE TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== RUN   TestAccVerifiedAccess_serial/Instance_disappears
=== PAUSE TestAccVerifiedAccess_serial/Instance_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_tags
=== PAUSE TestAccVerifiedAccess_serial/Instance_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_basic
=== PAUSE TestAccVerifiedAccess_serial/Instance_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Group_tags
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== CONT  TestAccVerifiedAccess_serial/Instance_description
=== CONT  TestAccVerifiedAccess_serial/Group_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== CONT  TestAccVerifiedAccess_serial/Group_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_tags
=== CONT  TestAccVerifiedAccess_serial/Instance_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== CONT  TestAccVerifiedAccess_serial/Instance_basic
=== CONT  TestAccVerifiedAccess_serial/Group_updateKMS
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Group_kms
=== CONT  TestAccVerifiedAccess_serial/Group_updatePolicy
=== CONT  TestAccVerifiedAccess_serial/Group_setPolicy
=== CONT  TestAccVerifiedAccess_serial/Group_policy
--- PASS: TestAccVerifiedAccess_serial (0.76s)
    --- PASS: TestAccVerifiedAccess_serial/Group_disappears (31.80s)
    --- PASS: TestAccVerifiedAccess_serial/Group_basic (37.97s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_description (56.86s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion (59.91s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (64.85s)
    --- PASS: TestAccVerifiedAccess_serial/Group_tags (80.78s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_disappears (84.45s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_tags (107.91s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_fipsEnabled (116.52s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext (123.69s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (132.36s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears (138.26s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3 (183.30s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3 (278.50s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose (293.48s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_basic (324.79s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs (325.67s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updateKMS (343.68s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1137.16s)
    --- PASS: TestAccVerifiedAccess_serial/Group_kms (1101.10s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1175.56s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updatePolicy (1139.90s)
    --- PASS: TestAccVerifiedAccess_serial/Group_setPolicy (1141.71s)
    --- PASS: TestAccVerifiedAccess_serial/Group_policy (1146.42s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1454.74s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1518.37s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1665.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1737.803s
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/basic\|TestAccClientVPNEndpoint_serial/disappears' PKG=ec2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccClientVPNEndpoint_serial/basic\|TestAccClientVPNEndpoint_serial/disappears -timeout 360m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Route_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Route_basic
=== RUN   TestAccClientVPNEndpoint_serial/Route_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccClientVPNEndpoint_serial/Route_basic
=== CONT  TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
--- PASS: TestAccClientVPNEndpoint_serial (1.13s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_disappears (26.50s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (27.07s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears (60.47s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_basic (62.77s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (84.77s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (111.29s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears (712.44s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_disappears (797.96s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_basic (863.54s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_basic (880.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	892.576s

@ewbankkit
Add 'acctest.RunLimitedConcurrencyTests2Levels'.
8b50e96
@ewbankkit
ec2: Run Verified Access acceptance tests with limited concurrency.
7700e2f
@ewbankkit
r/aws_verifiedaccess_trust_provider: Add sweeper.
28ab706
@ewbankkit
r/aws_verifiedaccess_instance: Add sweeper.
a2d248f
@ewbankkit
Verified Access: Use AWS SDK for Go v2 'tfawserr' package.
da9d4a2
@ewbankkit
'InitializeSemaphore' -> 'GetSemaphore'.
5474d2f
@ewbankkit
Document 'AWS_EC2_VERIFIED_ACCESS_INSTANCE_LIMIT'.
2a26415
@ewbankkit
r/aws_verifiedaccess_instance_trust_provider_attachment: Handle 'Inva…
928a4fd 
…lidParameterValue: Trust provider ... is not attached to instance ...' errors.
@ewbankkit
Add 'ec2.sweepVerifiedAccessTrustProviderAttachments'.
96dbc58
@ewbankkit
Add 'ec2.sweepVerifiedAccessGroups'.
db065e5
@ewbankkit
Add 'ec2.sweepVerifiedAccessEndpoints'.
89ff224
@ewbankkit
Acceptance test output:
f835d94 
% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccess_serial -timeout 360m
=== RUN   TestAccVerifiedAccess_serial
=== PAUSE TestAccVerifiedAccess_serial
=== CONT  TestAccVerifiedAccess_serial
=== RUN   TestAccVerifiedAccess_serial/Group_tags
=== PAUSE TestAccVerifiedAccess_serial/Group_tags
=== RUN   TestAccVerifiedAccess_serial/Group_policy
=== PAUSE TestAccVerifiedAccess_serial/Group_policy
=== RUN   TestAccVerifiedAccess_serial/Group_updatePolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_updatePolicy
=== RUN   TestAccVerifiedAccess_serial/Group_setPolicy
=== PAUSE TestAccVerifiedAccess_serial/Group_setPolicy
=== RUN   TestAccVerifiedAccess_serial/Group_basic
=== PAUSE TestAccVerifiedAccess_serial/Group_basic
=== RUN   TestAccVerifiedAccess_serial/Group_kms
=== PAUSE TestAccVerifiedAccess_serial/Group_kms
=== RUN   TestAccVerifiedAccess_serial/Group_updateKMS
=== PAUSE TestAccVerifiedAccess_serial/Group_updateKMS
=== RUN   TestAccVerifiedAccess_serial/Group_disappears
=== PAUSE TestAccVerifiedAccess_serial/Group_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_description
=== PAUSE TestAccVerifiedAccess_serial/Instance_description
=== RUN   TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== PAUSE TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== RUN   TestAccVerifiedAccess_serial/Instance_disappears
=== PAUSE TestAccVerifiedAccess_serial/Instance_disappears
=== RUN   TestAccVerifiedAccess_serial/Instance_tags
=== PAUSE TestAccVerifiedAccess_serial/Instance_tags
=== RUN   TestAccVerifiedAccess_serial/Instance_basic
=== PAUSE TestAccVerifiedAccess_serial/Instance_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== RUN   TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== RUN   TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_basic
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_basic
=== RUN   TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== RUN   TestAccVerifiedAccess_serial/Endpoint_tags
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_tags
=== RUN   TestAccVerifiedAccess_serial/Endpoint_disappears
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_disappears
=== RUN   TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== PAUSE TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Group_tags
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion
=== CONT  TestAccVerifiedAccess_serial/Instance_description
=== CONT  TestAccVerifiedAccess_serial/Group_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears
=== CONT  TestAccVerifiedAccess_serial/Endpoint_policyDocument
=== CONT  TestAccVerifiedAccess_serial/Endpoint_tags
=== CONT  TestAccVerifiedAccess_serial/Endpoint_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext
=== CONT  TestAccVerifiedAccess_serial/Group_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_tags
=== CONT  TestAccVerifiedAccess_serial/Instance_disappears
=== CONT  TestAccVerifiedAccess_serial/Instance_fipsEnabled
=== CONT  TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose
=== CONT  TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs
=== CONT  TestAccVerifiedAccess_serial/Instance_basic
=== CONT  TestAccVerifiedAccess_serial/Group_updateKMS
=== CONT  TestAccVerifiedAccess_serial/Endpoint_networkInterface
=== CONT  TestAccVerifiedAccess_serial/Endpoint_basic
=== CONT  TestAccVerifiedAccess_serial/Group_kms
=== CONT  TestAccVerifiedAccess_serial/Group_updatePolicy
=== CONT  TestAccVerifiedAccess_serial/Group_setPolicy
=== CONT  TestAccVerifiedAccess_serial/Group_policy
--- PASS: TestAccVerifiedAccess_serial (0.76s)
    --- PASS: TestAccVerifiedAccess_serial/Group_disappears (31.80s)
    --- PASS: TestAccVerifiedAccess_serial/Group_basic (37.97s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_description (56.86s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsLogVersion (59.91s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (64.85s)
    --- PASS: TestAccVerifiedAccess_serial/Group_tags (80.78s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_disappears (84.45s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_tags (107.91s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_fipsEnabled (116.52s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsIncludeTrustContext (123.69s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (132.36s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_disappears (138.26s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsS3 (183.30s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogsKinesisDataFirehoseS3 (278.50s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsKinesisDataFirehose (293.48s)
    --- PASS: TestAccVerifiedAccess_serial/Instance_basic (324.79s)
    --- PASS: TestAccVerifiedAccess_serial/InstanceLoggingConfiguration_accessLogsCloudWatchLogs (325.67s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updateKMS (343.68s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_tags (1137.16s)
    --- PASS: TestAccVerifiedAccess_serial/Group_kms (1101.10s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_policyDocument (1175.56s)
    --- PASS: TestAccVerifiedAccess_serial/Group_updatePolicy (1139.90s)
    --- PASS: TestAccVerifiedAccess_serial/Group_setPolicy (1141.71s)
    --- PASS: TestAccVerifiedAccess_serial/Group_policy (1146.42s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_networkInterface (1454.74s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_disappears (1518.37s)
    --- PASS: TestAccVerifiedAccess_serial/Endpoint_basic (1665.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1737.803s
@ewbankkit
ec2: Run Client VPN acceptance tests with limited concurrency.
f962db7
@ewbankkit
Acceptance test output:
7135dac 
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/basic\|TestAccClientVPNEndpoint_serial/disappears' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccClientVPNEndpoint_serial/basic\|TestAccClientVPNEndpoint_serial/disappears -timeout 360m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== RUN   TestAccClientVPNEndpoint_serial/Route_basic
=== PAUSE TestAccClientVPNEndpoint_serial/Route_basic
=== RUN   TestAccClientVPNEndpoint_serial/Route_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource
=== CONT  TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccClientVPNEndpoint_serial/Route_basic
=== CONT  TestAccClientVPNEndpoint_serial/Route_disappears
=== CONT  TestAccClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
--- PASS: TestAccClientVPNEndpoint_serial (1.13s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_disappears (26.50s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basicDataSource (27.07s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappears (60.47s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_basic (62.77s)
    --- PASS: TestAccClientVPNEndpoint_serial/Endpoint_basic (84.77s)
    --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (111.29s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears (712.44s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_disappears (797.96s)
    --- PASS: TestAccClientVPNEndpoint_serial/Route_basic (863.54s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_basic (880.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	892.576s
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. labels Feb 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 12, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit merged commit 671ed1d into main Feb 12, 2024
80 checks passed
@ewbankkit ewbankkit deleted the td-aws_verifiedaccess_instance-serialize-acctest branch February 12, 2024 17:17
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
Update CHANGELOG.md for #35769
e334dbb
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/vpnclient Issues and PRs that pertain to the vpnclient service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.37.0
Development

Successfully merging this pull request may close these issues.

Add Verified Access sweepers
1 participant
@ewbankkit