Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_iam _role upgrade to framework and inline policy change #35634

Open
wants to merge 128 commits into
base: main
Choose a base branch
from
+1,303 −1,263
Open

aws_iam _role upgrade to framework and inline policy change #35634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
128 commits
Select commit Hold shift + click to select a range
a2c6c14
work so far
teddylear Sep 18, 2023
671450e
more work so far
teddylear Sep 19, 2023
3a41e2d
work so far
teddylear Sep 20, 2023
7f0cebd
more work
teddylear Sep 20, 2023
c360f78
more work so far
teddylear Sep 20, 2023
daff2f3
feat: add arn framework validator
teddylear Sep 20, 2023
d7d6ab3
remove from this branch
teddylear Sep 20, 2023
970eeef
Merge branch 'main' into ken-test-iam-plugin-sdk
teddylear Sep 20, 2023
214c18b
Merge branch 'f-add-arn-framwork-validator' into ken-test-iam-plugin-sdk
teddylear Sep 20, 2023
d223cd3
force new
teddylear Sep 27, 2023
dfb397d
more work
teddylear Sep 27, 2023
6795001
more wokr
teddylear Sep 28, 2023
539b8f2
more steps
teddylear Sep 28, 2023
583fdcf
more
teddylear Sep 28, 2023
c241d14
more
teddylear Sep 28, 2023
090d697
fmt
teddylear Sep 28, 2023
659682f
progress
teddylear Sep 28, 2023
350fb1b
Merge branch 'main' into ken-test-iam-plugin-sdk
teddylear Jan 16, 2024
8082f53
more work
teddylear Jan 17, 2024
e0a75f7
more cleanup
teddylear Jan 17, 2024
29febc6
adding function skeletons for plugin framework resource
teddylear Jan 17, 2024
495bf16
got factory working I think
teddylear Jan 17, 2024
83c71d9
make first test simpler, added delete func
teddylear Jan 18, 2024
ed8f65a
work so far getting read working
teddylear Jan 18, 2024
8f4eaf7
finish read function with basics from first test
teddylear Jan 18, 2024
ec1e3b4
work so far to get first test working
teddylear Jan 18, 2024
566d85e
one more try
teddylear Jan 18, 2024
45f9e92
more
teddylear Jan 18, 2024
afd6801
YES
teddylear Jan 19, 2024
5d054f8
add back sdk resource tags
teddylear Jan 19, 2024
6997ac3
got import test working
teddylear Jan 19, 2024
18bae50
got baseline description test working
teddylear Jan 19, 2024
cb6fbbd
Got part of description test done
teddylear Jan 19, 2024
a977ec8
small improvement
teddylear Jan 19, 2024
02575d1
got description done
teddylear Jan 19, 2024
3814052
work so far
teddylear Jan 20, 2024
0229941
finish name prefix
teddylear Jan 20, 2024
37be5cd
another test
teddylear Jan 20, 2024
8932b99
another test in the books
teddylear Jan 20, 2024
5eaec8f
another test
teddylear Jan 20, 2024
009f850
another test
teddylear Jan 20, 2024
a213636
update another test
teddylear Jan 20, 2024
4235d66
another test
teddylear Jan 20, 2024
5b81f14
force detach policies test
teddylear Jan 20, 2024
36eeca3
small cleanup
teddylear Jan 20, 2024
e8b9ddc
add max session duration test
teddylear Jan 20, 2024
c215f9d
part of permissions boundary done
teddylear Jan 20, 2024
89ba347
rest of permission boundary
teddylear Jan 20, 2024
18292b5
part of tags test done
teddylear Jan 21, 2024
134593f
tags test complete and updated diff test
teddylear Jan 21, 2024
5b41565
work so far to get inline policies working, have someting read in
teddylear Jan 21, 2024
1078c4d
starting inline policy journey
teddylear Jan 21, 2024
4715ef7
work so far to get next steps working
teddylear Jan 21, 2024
e0d2a9e
more work
teddylear Jan 21, 2024
ede4280
another part passing
teddylear Jan 21, 2024
23b014e
finish inline basic
teddylear Jan 21, 2024
23f1db5
finish basic inline test
teddylear Jan 21, 2024
c5249f5
make comment about plan modifier test
teddylear Jan 21, 2024
dc1d2c0
empty inline policy test
teddylear Jan 21, 2024
2820bff
adding unique id and a test for it
teddylear Jan 21, 2024
3bb1726
first part of managed arns
teddylear Jan 22, 2024
2c33470
finish managed policy baseline test
teddylear Jan 22, 2024
f42d87a
refactor for id schema
teddylear Jan 22, 2024
912a9e8
add another inline policy test
teddylear Jan 22, 2024
e634ef4
another managed arn out of band policy test
teddylear Jan 22, 2024
07fff5c
another inline test
teddylear Jan 22, 2024
e2668bf
another test
teddylear Jan 22, 2024
7cae19f
another one
teddylear Jan 22, 2024
893df87
another test
teddylear Jan 22, 2024
597fe48
another test
teddylear Jan 22, 2024
b3551e5
small inline fix
teddylear Jan 23, 2024
8dcdddd
fmt
teddylear Jan 23, 2024
2f368c8
more cleanup changes
teddylear Jan 23, 2024
5fba9f7
cleanup more errors
teddylear Jan 23, 2024
e7f7aae
move managed policies to arn type for set
teddylear Jan 23, 2024
ba1e8c8
fmt
teddylear Jan 23, 2024
dc48303
another improvement wtih validation on iam policies for inline polici…
teddylear Jan 23, 2024
c1f9e64
add minor comment about name validation for inline policies
teddylear Jan 23, 2024
b7ef39e
minor fix for inline policy comparison
teddylear Jan 24, 2024
7d6704e
work with getting inline policy plans clean
teddylear Jan 25, 2024
27b67e6
test helper function changes for ignoreOrder stuff
teddylear Jan 25, 2024
bcc59ab
add comment about failing test case
teddylear Jan 25, 2024
64595b1
Got failing basic migration test working
teddylear Jan 25, 2024
adc7593
work so far to get upgrade working, getting there but made good progress
teddylear Jan 26, 2024
51b21bc
ok got ignore order testing working somehow
teddylear Jan 26, 2024
83202bb
basline upgrade test working
teddylear Jan 27, 2024
28d8bc8
Merge branch 'hashicorp:main' into ken-test-iam-plugin-sdk
teddylear Jan 27, 2024
55049ad
update provider on upgrade tests
teddylear Jan 27, 2024
b57ec16
more upgrade migration checks
teddylear Jan 27, 2024
eebb619
stuck...
teddylear Jan 27, 2024
470c37e
fix test terraform fmt
teddylear Jan 27, 2024
48f6041
remove arn validators
teddylear Jan 27, 2024
f303888
fix semgrep error
teddylear Jan 27, 2024
31c4e17
another fix
teddylear Jan 27, 2024
22502fd
another fix
teddylear Jan 27, 2024
0aebb5e
testing
teddylear Feb 3, 2024
5ad64aa
found workaround
teddylear Feb 4, 2024
299c49d
more tests
teddylear Feb 4, 2024
ea011d4
fix inlinetest
teddylear Feb 4, 2024
a362581
more tests
teddylear Feb 4, 2024
1b8321c
add final tests
teddylear Feb 4, 2024
c715345
remove some tests because of other issues I was seeing with multiple …
teddylear Feb 4, 2024
ad5c905
some cleanup
teddylear Feb 4, 2024
a91a3fe
cleanup
teddylear Feb 4, 2024
8a8ffc8
test fix
teddylear Feb 4, 2024
006b4aa
another test
teddylear Feb 4, 2024
fcabcd4
working on getting cluster role association test working
teddylear Feb 4, 2024
c30adee
more cleanup
teddylear Feb 4, 2024
1db6d75
more updates
teddylear Feb 5, 2024
939e4fe
another update
teddylear Feb 5, 2024
d2c92dc
another validator
teddylear Feb 5, 2024
cdb52f5
more cleanup
teddylear Feb 5, 2024
9122382
more cleanup
teddylear Feb 5, 2024
83d9b62
cleanup test print messages
teddylear Feb 5, 2024
5f8fb30
managed policy test
teddylear Feb 5, 2024
3350161
cleanup
teddylear Feb 5, 2024
553808a
golangci fixies
teddylear Feb 5, 2024
fb9bbc9
update docs
teddylear Feb 5, 2024
b0b38d4
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
teddylear Feb 5, 2024
df74c15
website fix
teddylear Feb 5, 2024
8b18c9e
fmt role markdown
teddylear Feb 5, 2024
dd23697
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
teddylear Feb 10, 2024
fee01ed
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
teddylear Mar 12, 2024
a4bf59b
chore: fix semgrep error with test error check
teddylear Mar 12, 2024
c5ef984
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
teddylear Mar 18, 2024
9d7b8ff
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
teddylear Mar 23, 2024
9277bf2
remove autogen tags
Apr 10, 2024
517bf67
Merge branch 'main' into f-aws_iam_role-upgrade-to-framework-and-inli…
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/service/iam/exports.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ package iam

// Exports for use in other packages.
var (
ResourceRole = resourceRole

ResourceRole = NewResourceRole
DeleteServiceLinkedRole = deleteServiceLinkedRole
FindRoleByName = findRoleByName
ListGroupsForUserPages = listGroupsForUserPages
Expand Down
2 changes: 1 addition & 1 deletion internal/service/iam/instance_profile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func TestAccIAMInstanceProfile_Disappears_role(t *testing.T) {
Config: testAccInstanceProfileConfig_basic(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckInstanceProfileExists(ctx, resourceName, &conf),
acctest.CheckResourceDisappears(ctx, acctest.Provider, tfiam.ResourceRole(), "aws_iam_role.test"),
acctest.CheckFrameworkResourceDisappears(ctx, acctest.Provider, tfiam.ResourceRole, "aws_iam_role.test"),
),
ExpectNonEmptyPlan: true,
},
Expand Down
Loading
Loading