Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ECS service to use AWS SDK Go v2 #35524

Closed

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs commented Jan 28, 2024

Description

Relations

Relates #32917
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jan 28, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 28, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@bryantbiggs bryantbiggs force-pushed the refactor/ecs-aws-sdk-go-v2 branch from 256b6f8 to d264d6d Compare January 28, 2024 20:54
@bryantbiggs bryantbiggs force-pushed the refactor/ecs-aws-sdk-go-v2 branch from ceda123 to 57dfcc3 Compare January 29, 2024 01:37
@bryantbiggs
Copy link
Contributor Author

bryantbiggs commented Jan 29, 2024

make testacc-short PKG=ecs ACCTEST_PARALLELISM=20
==> Checking that code complies with gofmt requirements...
Running acceptance tests with -short flag
TF_ACC=1 go test ./internal/service/ecs/... -v -short -count 1 -parallel 20   -timeout 360m
=== RUN   TestValidPlacementConstraint
=== PAUSE TestValidPlacementConstraint
=== RUN   TestValidPlacementStrategy
=== PAUSE TestValidPlacementStrategy
=== RUN   TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_serviceLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_serviceLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_taskLongARNFormat
=== PAUSE TestAccECSAccountSettingDefault_taskLongARNFormat
=== RUN   TestAccECSAccountSettingDefault_vpcTrunking
=== PAUSE TestAccECSAccountSettingDefault_vpcTrunking
=== RUN   TestAccECSAccountSettingDefault_containerInsights
=== PAUSE TestAccECSAccountSettingDefault_containerInsights
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSClusterCapacityProviders_basic
=== PAUSE TestAccECSClusterCapacityProviders_basic
=== RUN   TestAccECSClusterCapacityProviders_disappears
=== PAUSE TestAccECSClusterCapacityProviders_disappears
=== RUN   TestAccECSClusterCapacityProviders_defaults
=== PAUSE TestAccECSClusterCapacityProviders_defaults
=== RUN   TestAccECSClusterCapacityProviders_destroy
=== PAUSE TestAccECSClusterCapacityProviders_destroy
=== RUN   TestAccECSClusterCapacityProviders_Update_capacityProviders
=== PAUSE TestAccECSClusterCapacityProviders_Update_capacityProviders
=== RUN   TestAccECSClusterCapacityProviders_Update_defaultStrategy
=== PAUSE TestAccECSClusterCapacityProviders_Update_defaultStrategy
=== RUN   TestAccECSClusterDataSource_ecsCluster
=== PAUSE TestAccECSClusterDataSource_ecsCluster
=== RUN   TestAccECSClusterDataSource_ecsClusterContainerInsights
=== PAUSE TestAccECSClusterDataSource_ecsClusterContainerInsights
=== RUN   TestAccECSClusterDataSource_tags
=== PAUSE TestAccECSClusterDataSource_tags
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_disappears
=== PAUSE TestAccECSCluster_disappears
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSCluster_serviceConnectDefaults
=== PAUSE TestAccECSCluster_serviceConnectDefaults
=== RUN   TestAccECSCluster_containerInsights
=== PAUSE TestAccECSCluster_containerInsights
=== RUN   TestAccECSCluster_configuration
=== PAUSE TestAccECSCluster_configuration
=== RUN   TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
=== PAUSE TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== RUN   Test_GetRoleNameFromARN
=== PAUSE Test_GetRoleNameFromARN
=== RUN   Test_GetClustereNameFromARN
=== PAUSE Test_GetClustereNameFromARN
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
    service_test.go:346: skipping long-running test in short mode
--- SKIP: TestAccECSService_healthCheckGracePeriodSeconds (0.00s)
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
    service_test.go:450: skipping long-running test in short mode
--- SKIP: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (0.00s)
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_alarmsAdd
=== PAUSE TestAccECSService_alarmsAdd
=== RUN   TestAccECSService_alarmsUpdate
=== PAUSE TestAccECSService_alarmsUpdate
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
    service_test.go:1146: skipping long-running test in short mode
--- SKIP: TestAccECSService_ServiceRegistries_changes (0.00s)
=== RUN   TestAccECSService_ServiceRegistries_removal
    service_test.go:1181: skipping long-running test in short mode
--- SKIP: TestAccECSService_ServiceRegistries_removal (0.00s)
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== RUN   TestAccECSTag_basic
=== PAUSE TestAccECSTag_basic
=== RUN   TestAccECSTag_disappears
=== PAUSE TestAccECSTag_disappears
=== RUN   TestAccECSTag_ResourceARN_batchComputeEnvironment
=== PAUSE TestAccECSTag_ResourceARN_batchComputeEnvironment
=== RUN   TestAccECSTag_value
=== PAUSE TestAccECSTag_value
=== RUN   TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== PAUSE TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== RUN   Test_StripRevision
=== PAUSE Test_StripRevision
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_scratchVolume
=== PAUSE TestAccECSTaskDefinition_scratchVolume
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_minimal
=== PAUSE TestAccECSTaskDefinition_DockerVolume_minimal
=== RUN   TestAccECSTaskDefinition_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatform
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatform
=== RUN   TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== PAUSE TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
=== RUN   TestAccECSTaskDefinition_EFSVolume_minimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_minimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryption
=== RUN   TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== PAUSE TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== RUN   TestAccECSTaskDefinition_EFSVolume_accessPoint
=== PAUSE TestAccECSTaskDefinition_EFSVolume_accessPoint
=== RUN   TestAccECSTaskDefinition_fsxWinFileSystem
    task_definition_test.go:547: skipping long-running test in short mode
--- SKIP: TestAccECSTaskDefinition_fsxWinFileSystem (0.00s)
=== RUN   TestAccECSTaskDefinition_DockerVolume_taskScoped
=== PAUSE TestAccECSTaskDefinition_DockerVolume_taskScoped
=== RUN   TestAccECSTaskDefinition_service
=== PAUSE TestAccECSTaskDefinition_service
=== RUN   TestAccECSTaskDefinition_taskRoleARN
=== PAUSE TestAccECSTaskDefinition_taskRoleARN
=== RUN   TestAccECSTaskDefinition_networkMode
=== PAUSE TestAccECSTaskDefinition_networkMode
=== RUN   TestAccECSTaskDefinition_ipcMode
=== PAUSE TestAccECSTaskDefinition_ipcMode
=== RUN   TestAccECSTaskDefinition_pidMode
=== PAUSE TestAccECSTaskDefinition_pidMode
=== RUN   TestAccECSTaskDefinition_constraint
=== PAUSE TestAccECSTaskDefinition_constraint
=== RUN   TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccECSTaskDefinition_arrays
=== PAUSE TestAccECSTaskDefinition_arrays
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccECSTaskDefinition_executionRole
=== PAUSE TestAccECSTaskDefinition_executionRole
=== RUN   TestAccECSTaskDefinition_disappears
=== PAUSE TestAccECSTaskDefinition_disappears
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskDefinition_proxy
=== PAUSE TestAccECSTaskDefinition_proxy
=== RUN   TestAccECSTaskDefinition_inferenceAccelerator
=== PAUSE TestAccECSTaskDefinition_inferenceAccelerator
=== RUN   TestAccECSTaskDefinition_invalidContainerDefinition
=== PAUSE TestAccECSTaskDefinition_invalidContainerDefinition
=== RUN   TestValidTaskDefinitionContainerDefinitions
=== PAUSE TestValidTaskDefinitionContainerDefinitions
=== RUN   TestAccECSTaskExecutionDataSource_basic
    task_execution_data_source_test.go:19: skipping long-running test in short mode
--- SKIP: TestAccECSTaskExecutionDataSource_basic (0.00s)
=== RUN   TestAccECSTaskExecutionDataSource_overrides
    task_execution_data_source_test.go:53: skipping long-running test in short mode
--- SKIP: TestAccECSTaskExecutionDataSource_overrides (0.00s)
=== RUN   TestAccECSTaskExecutionDataSource_tags
    task_execution_data_source_test.go:92: skipping long-running test in short mode
--- SKIP: TestAccECSTaskExecutionDataSource_tags (0.00s)
=== RUN   TestAccECSTaskSet_basic
=== PAUSE TestAccECSTaskSet_basic
=== RUN   TestAccECSTaskSet_withExternalId
=== PAUSE TestAccECSTaskSet_withExternalId
=== RUN   TestAccECSTaskSet_withScale
=== PAUSE TestAccECSTaskSet_withScale
=== RUN   TestAccECSTaskSet_disappears
=== PAUSE TestAccECSTaskSet_disappears
=== RUN   TestAccECSTaskSet_withCapacityProviderStrategy
=== PAUSE TestAccECSTaskSet_withCapacityProviderStrategy
=== RUN   TestAccECSTaskSet_withAlb
=== PAUSE TestAccECSTaskSet_withAlb
=== RUN   TestAccECSTaskSet_withLaunchTypeFargate
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargate
=== RUN   TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== PAUSE TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
=== RUN   TestAccECSTaskSet_withServiceRegistries
=== PAUSE TestAccECSTaskSet_withServiceRegistries
=== RUN   TestAccECSTaskSet_tags
=== PAUSE TestAccECSTaskSet_tags
=== CONT  TestValidPlacementConstraint
--- PASS: TestValidPlacementConstraint (0.00s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled
=== CONT  TestAccECSTaskDefinition_EFSVolume_accessPoint
=== CONT  TestAccECSService_DeploymentValues_basic
=== CONT  TestAccECSService_Tags_basic
=== CONT  TestAccECSTaskDefinition_proxy
=== CONT  TestAccECSTaskSet_disappears
=== CONT  TestAccECSCluster_disappears
=== CONT  TestAccECSTaskSet_tags
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
=== CONT  TestAccECSService_alarmsUpdate
=== CONT  TestAccECSTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccECSService_ServiceConnect_remove
=== CONT  TestAccECSTaskSet_basic
=== CONT  TestAccECSTaskSet_withExternalId
=== CONT  TestAccECSTaskDefinition_changeVolumesForcesNewResource
=== CONT  TestAccECSTaskDefinition_tags
=== CONT  TestAccECSTaskDefinition_disappears
=== CONT  TestAccECSTaskDefinition_executionRole
=== CONT  TestAccECSTaskSet_withServiceRegistries
=== CONT  TestAccECSTaskSet_withScale
--- PASS: TestAccECSTaskDefinition_executionRole (78.07s)
=== CONT  TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (80.57s)
=== CONT  TestAccECSTaskSet_withLaunchTypeFargate
--- PASS: TestAccECSCluster_disappears (111.68s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionDisabled (114.83s)
=== CONT  TestAccECSTaskSet_withAlb
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (116.09s)
=== CONT  TestAccECSTaskDefinition_arrays
--- PASS: TestAccECSTaskDefinition_proxy (125.07s)
=== CONT  TestAccECSTaskSet_withCapacityProviderStrategy
--- PASS: TestAccECSTaskSet_disappears (129.80s)
=== CONT  TestAccECSTaskDefinition_networkMode
--- PASS: TestAccECSTaskDefinition_disappears (130.32s)
=== CONT  TestAccECSTaskDefinition_scratchVolume
--- PASS: TestAccECSService_DeploymentValues_basic (139.29s)
=== CONT  TestAccECSTaskDefinition_constraint
--- PASS: TestAccECSTaskSet_basic (142.15s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryption
--- PASS: TestAccECSTaskSet_withExternalId (144.81s)
=== CONT  TestAccECSTaskDefinition_pidMode
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (151.63s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal
--- PASS: TestAccECSService_alarmsUpdate (215.73s)
=== CONT  TestAccECSTaskDefinition_ipcMode
--- PASS: TestAccECSTaskDefinition_arrays (105.27s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskSet_withServiceRegistries (221.68s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (144.14s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_minimal
--- PASS: TestAccECSTaskSet_withScale (234.04s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSTaskDefinition_scratchVolume (105.80s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch
--- PASS: TestAccECSTaskDefinition_networkMode (106.78s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSTaskDefinition_constraint (104.14s)
=== CONT  TestAccECSTaskDefinition_Fargate_runtimePlatform
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (246.26s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSTaskDefinition_Fargate_basic (143.10s)
=== CONT  TestAccECSTaskDefinition_runtimePlatform
--- PASS: TestAccECSTaskDefinition_tags (255.25s)
=== CONT  TestAccECSService_iamRole
--- PASS: TestAccECSTaskDefinition_pidMode (111.35s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_minimal
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (116.22s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryptionMinimal (113.04s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskSet_tags (272.24s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_Tags_basic (294.83s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_ServiceConnect_remove (299.59s)
=== CONT  TestAccECSTaskDefinition_invalidContainerDefinition
--- PASS: TestAccECSTaskDefinition_ipcMode (109.28s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSTaskDefinition_invalidContainerDefinition (34.76s)
=== CONT  TestValidTaskDefinitionContainerDefinitions
--- PASS: TestValidTaskDefinitionContainerDefinitions (0.00s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (263.51s)
=== CONT  TestAccECSTaskDefinition_service
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (111.50s)
=== CONT  TestAccECSTaskDefinition_taskRoleARN
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (104.83s)
=== CONT  TestAccECSCapacityProvider_tags
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (125.77s)
=== CONT  TestAccECSClusterCapacityProviders_Update_defaultStrategy
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (129.62s)
=== CONT  TestAccECSClusterCapacityProviders_Update_capacityProviders
--- PASS: TestAccECSTaskDefinition_runtimePlatform (116.79s)
=== CONT  TestAccECSCluster_basic
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (116.02s)
=== CONT  TestAccECSClusterCapacityProviders_destroy
--- PASS: TestAccECSService_iamRole (117.44s)
=== CONT  TestAccECSService_ServiceConnect_full
--- PASS: TestAccECSService_DeploymentControllerType_external (137.45s)
=== CONT  TestAccECSClusterCapacityProviders_defaults
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (115.01s)
=== CONT  TestAccECSClusterDataSource_tags
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (270.36s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSTaskDefinition_taskRoleARN (86.24s)
=== CONT  TestAccECSClusterCapacityProviders_disappears
--- PASS: TestAccECSTaskSet_withAlb (323.32s)
=== CONT  TestAccECSService_ServiceRegistries_container
    acctest.go:873: skipping tests; partition aws does not support ServiceDiscovery service
--- SKIP: TestAccECSService_ServiceRegistries_container (0.00s)
=== CONT  TestAccECSClusterCapacityProviders_basic
=== NAME  TestAccECSClusterCapacityProviders_destroy
    cluster_capacity_providers_test.go:120: Step 1/2 error: Check failed: Check 2/2 error: RegisteredContainerInstancesCount = 0, want 2
--- PASS: TestAccECSService_alarmsAdd (217.80s)
=== CONT  TestAccECSService_ServiceRegistries_basic
    acctest.go:873: skipping tests; partition aws does not support ServiceDiscovery service
--- SKIP: TestAccECSService_ServiceRegistries_basic (0.00s)
=== CONT  TestAccECSClusterDataSource_ecsClusterContainerInsights
--- PASS: TestAccECSClusterDataSource_tags (75.73s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_familyAndRevision (200.11s)
=== CONT  TestAccECSClusterDataSource_ecsCluster
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (126.01s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSCluster_basic (97.48s)
=== CONT  TestAccECSServiceDataSource_basic
--- PASS: TestAccECSService_disappears (261.79s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSClusterCapacityProviders_defaults (126.25s)
=== CONT  TestAccECSService_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (206.35s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSTaskDefinition_service (186.66s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (87.99s)
=== CONT  Test_GetClustereNameFromARN
=== RUN   Test_GetClustereNameFromARN/empty
=== PAUSE Test_GetClustereNameFromARN/empty
=== RUN   Test_GetClustereNameFromARN/cluster
=== PAUSE Test_GetClustereNameFromARN/cluster
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSClusterDataSource_ecsCluster (88.96s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_taskScoped
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (91.43s)
=== CONT  Test_GetRoleNameFromARN
=== RUN   Test_GetRoleNameFromARN/empty
=== PAUSE Test_GetRoleNameFromARN/empty
=== RUN   Test_GetRoleNameFromARN/role
=== PAUSE Test_GetRoleNameFromARN/role
=== RUN   Test_GetRoleNameFromARN/role_with_path
=== PAUSE Test_GetRoleNameFromARN/role_with_path
=== RUN   Test_GetRoleNameFromARN/role_with_complex_path
=== PAUSE Test_GetRoleNameFromARN/role_with_complex_path
=== CONT  TestAccECSTaskDefinition_inferenceAccelerator
--- PASS: TestAccECSClusterCapacityProviders_disappears (121.85s)
=== CONT  TestAccECSCluster_containerInsights
--- FAIL: TestAccECSClusterCapacityProviders_destroy (184.08s)
=== CONT  TestAccECSContainerDefinitionDataSource_ecsContainerDefinition
--- PASS: TestAccECSClusterCapacityProviders_basic (124.78s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (80.18s)
=== CONT  TestAccECSCluster_configuration
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (266.33s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSCapacityProvider_tags (246.93s)
=== CONT  TestAccECSAccountSettingDefault_containerInsights
--- PASS: TestAccECSService_replicaSchedulingStrategy (140.24s)
=== CONT  TestAccECSCluster_serviceConnectDefaults
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (49.54s)
=== CONT  TestAccECSTag_ResourceARN_batchComputeEnvironment
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (351.02s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSServiceDataSource_basic (132.00s)
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSService_ServiceConnect_full (235.39s)
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSService_ServiceConnect_basic (216.20s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (75.74s)
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSService_basic (165.92s)
=== CONT  TestAccECSAccountSettingDefault_serviceLongARNFormat
--- PASS: TestAccECSAccountSettingDefault_containerInsights (78.79s)
=== CONT  TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSContainerDefinitionDataSource_ecsContainerDefinition (124.12s)
=== CONT  TestAccECSAccountSettingDefault_vpcTrunking
=== CONT  Test_StripRevision
--- PASS: TestAccECSService_LaunchTypeEC2_network (181.26s)
=== RUN   Test_StripRevision/empty
=== PAUSE Test_StripRevision/empty
=== RUN   Test_StripRevision/invalid_arn
=== PAUSE Test_StripRevision/invalid_arn
=== RUN   Test_StripRevision/with_revision
=== PAUSE Test_StripRevision/with_revision
=== RUN   Test_StripRevision/no_revision
=== PAUSE Test_StripRevision/no_revision
=== CONT  TestAccECSService_PlacementStrategy_basic
=== NAME  TestAccECSTag_ResourceARN_batchComputeEnvironment
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: operation error ECS: ListTagsForResource, https response error StatusCode: 400, RequestID: 8710da58-3305-480e-9844-94e4637e8390, InvalidParameterException: The specified cluster is inactive. Specify an active cluster and try again.
--- FAIL: TestAccECSTag_ResourceARN_batchComputeEnvironment (117.68s)
=== CONT  TestAccECSAccountSettingDefault_taskLongARNFormat
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (121.47s)
=== CONT  TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
--- PASS: TestAccECSClusterCapacityProviders_Update_defaultStrategy (375.32s)
=== CONT  TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSClusterCapacityProviders_Update_capacityProviders (375.26s)
=== CONT  TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSCluster_configuration (171.07s)
=== CONT  TestAccECSTag_value
--- PASS: TestAccECSService_CapacityProviderStrategy_update (478.29s)
=== CONT  TestAccECSService_forceNewDeployment
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (191.21s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSTaskDefinition_basic (156.47s)
=== CONT  TestAccECSService_multipleTargetGroups
--- PASS: TestAccECSAccountSettingDefault_serviceLongARNFormat (120.59s)
=== CONT  TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCluster_containerInsights (231.58s)
=== CONT  TestAccECSCluster_tags
--- PASS: TestAccECSAccountSettingDefault_vpcTrunking (112.94s)
=== CONT  TestAccECSService_executeCommand
--- PASS: TestAccECSCapacityProvider_disappears (129.53s)
=== CONT  TestAccECSService_Tags_propagate
--- PASS: TestAccECSService_basicImport (275.87s)
=== CONT  TestAccECSTag_disappears
--- PASS: TestAccECSService_PlacementConstraints_basic (198.56s)
=== CONT  TestAccECSTag_basic
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (96.69s)
=== CONT  TestAccECSAccountSettingDefault_containerInstanceLongARNFormat
--- PASS: TestAccECSAccountSettingDefault_taskLongARNFormat (109.45s)
=== CONT  TestAccECSService_Tags_managed
=== CONT  TestValidPlacementStrategy
--- PASS: TestValidPlacementStrategy (0.00s)
=== CONT  Test_GetClustereNameFromARN/empty
=== CONT  Test_GetClustereNameFromARN/cluster
--- PASS: Test_GetClustereNameFromARN (0.00s)
    --- PASS: Test_GetClustereNameFromARN/empty (0.00s)
    --- PASS: Test_GetClustereNameFromARN/cluster (0.00s)
=== CONT  Test_GetRoleNameFromARN/empty
=== CONT  Test_GetRoleNameFromARN/role
=== CONT  Test_GetRoleNameFromARN/role_with_path
=== CONT  Test_GetRoleNameFromARN/role_with_complex_path
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (311.87s)
--- PASS: Test_GetRoleNameFromARN (0.01s)
    --- PASS: Test_GetRoleNameFromARN/empty (0.00s)
    --- PASS: Test_GetRoleNameFromARN/role (0.00s)
    --- PASS: Test_GetRoleNameFromARN/role_with_path (0.00s)
    --- PASS: Test_GetRoleNameFromARN/role_with_complex_path (0.00s)
=== CONT  Test_StripRevision/empty
=== CONT  Test_StripRevision/invalid_arn
=== CONT  Test_StripRevision/with_revision
=== CONT  Test_StripRevision/no_revision
--- PASS: Test_StripRevision (0.01s)
    --- PASS: Test_StripRevision/empty (0.00s)
    --- PASS: Test_StripRevision/invalid_arn (0.00s)
    --- PASS: Test_StripRevision/with_revision (0.00s)
    --- PASS: Test_StripRevision/no_revision (0.00s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (157.43s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (137.21s)
=== NAME  TestAccECSTag_disappears
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: operation error ECS: ListTagsForResource, https response error StatusCode: 400, RequestID: df196fe3-f9ab-49ad-8859-8d1a794766eb, InvalidParameterException: The specified cluster is inactive. Specify an active cluster and try again.
--- FAIL: TestAccECSTag_disappears (89.81s)
--- PASS: TestAccECSCluster_serviceConnectDefaults (298.81s)
--- PASS: TestAccECSCapacityProvider_managedScaling (271.62s)
--- PASS: TestAccECSAccountSettingDefault_containerInstanceLongARNFormat (82.80s)
=== NAME  TestAccECSTag_basic
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: operation error ECS: ListTagsForResource, https response error StatusCode: 400, RequestID: 080474af-0696-401c-b23a-cf0d6431f53e, InvalidParameterException: The specified cluster is inactive. Specify an active cluster and try again.
--- FAIL: TestAccECSTag_basic (92.18s)
=== NAME  TestAccECSTag_value
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: operation error ECS: ListTagsForResource, https response error StatusCode: 400, RequestID: 566fffe8-a9d6-43f7-8bd1-075f23d74efe, InvalidParameterException: The specified cluster is inactive. Specify an active cluster and try again.
--- FAIL: TestAccECSTag_value (168.00s)
--- PASS: TestAccECSCapacityProvider_basic (128.00s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (325.38s)
--- PASS: TestAccECSCluster_tags (144.45s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (209.30s)
--- PASS: TestAccECSService_Tags_managed (111.23s)
--- PASS: TestAccECSService_forceNewDeployment (184.98s)
--- PASS: TestAccECSService_PlacementStrategy_basic (275.48s)
--- PASS: TestAccECSService_executeCommand (168.51s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (364.69s)
--- PASS: TestAccECSService_Tags_propagate (163.94s)
--- PASS: TestAccECSService_multipleTargetGroups (297.05s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	1071.688s
FAIL
make: *** [testacc-short] Error 1

@justinretzolk justinretzolk added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 29, 2024
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 5, 2024
@bryantbiggs bryantbiggs closed this May 6, 2024
@bryantbiggs bryantbiggs deleted the refactor/ecs-aws-sdk-go-v2 branch May 6, 2024 13:54
Copy link

github-actions bot commented Jun 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. partner Contribution from a partner. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants