Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add sweepers for aws_internet_gateway and aws_nat_gateway #3545

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 27, 2018

Got bit by a lingering NAT Gateway this morning so adding test sweepers. ♻️

This appropriately tags all the existing aws_nat_gateway test resources, but only starts the tagging process for aws_internet_gateway (I don't have time right now to tag and acceptance test the other few dozen test aws_internet_gateway resources).

make testacc TEST=./aws TESTARGS='-run=TestAccAWS\(Internet\|Nat\)Gateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWS\(Internet\|Nat\)Gateway_ -timeout 120m
=== RUN   TestAccAWSInternetGateway_importBasic
--- PASS: TestAccAWSInternetGateway_importBasic (37.75s)
=== RUN   TestAccAWSNatGateway_importBasic
--- PASS: TestAccAWSNatGateway_importBasic (198.62s)
=== RUN   TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_basic (66.11s)
=== RUN   TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_delete (48.25s)
=== RUN   TestAccAWSInternetGateway_tags
--- PASS: TestAccAWSInternetGateway_tags (52.73s)
=== RUN   TestAccAWSNatGateway_basic
--- PASS: TestAccAWSNatGateway_basic (218.29s)
=== RUN   TestAccAWSNatGateway_tags
--- PASS: TestAccAWSNatGateway_tags (203.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	825.628s
make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./... -v -sweep=us-east-1,us-west-2
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
2018/02/27 09:49:08 [DEBUG] Running Sweepers for region (us-east-1):
...
2018/02/27 09:55:52 Sweeper Tests ran:
	- aws_beanstalk_application
	- aws_subnet
	- aws_redshift_cluster
	- aws_iam_server_certificate
	- aws_dynamodb_table
	- aws_beanstalk_environment
	- aws_autoscaling_group
	- aws_nat_gateway
	- aws_vpc
	- aws_kms_key
	- aws_mq_broker
	- aws_db_option_group
	- aws_gamelift_alias
	- aws_gamelift_build
	- aws_security_group
	- aws_lambda_function
	- aws_network_acl
	- aws_db_instance
	- aws_vpn_gateway
	- aws_gamelift_fleet
	- aws_key_pair
	- aws_internet_gateway
	- aws_launch_configuration
	- aws_dax_cluster
ok  	github.com/terraform-providers/terraform-provider-aws/aws	404.036s

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 27, 2018
@bflad bflad added this to the v1.11.0 milestone Feb 27, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 27, 2018
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm going to merge it straight away and kick off tests.

Thanks.

@radeksimko radeksimko merged commit fefe347 into master Feb 28, 2018
@radeksimko radeksimko deleted the t-aws_nat_gateway-tags branch February 28, 2018 07:58
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants