Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds filter to data.aws_eip #3525

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Adds filter to data.aws_eip #3525

merged 3 commits into from
Nov 13, 2018

Commits on Feb 25, 2018

  1. fixes hashicorp#2825 supports classic EIP’s in data.aws_eip

    @www
    www committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    aa8b83f View commit details
    Browse the repository at this point in the history

  2. fixes hashicorp#3423 adds filter to data source aws_eip 

    this addes the ability to search for EIP’s via tags or other attribute that EIP’s can use in a filter.

This did highlight a known issue with regrads to how terraform eval’s data sources before they should if be the resourse is a computed value. This is only an issue if the data block is referencing a resource that is created at the same time. If referencing a pre exiting resource this does not happen.

the test config testAccDataSourceAwsEipFilterConfig makes a interpol ref to force terraform to eval the data block after the resource has either been created or read in `values = ["${aws_eip.test.tags.Name}”]` see the following links

hashicorp/terraform#10603
hashicorp/terraform#17173
    @richardbowden
    richardbowden committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    ec0a43c View commit details
    Browse the repository at this point in the history

  3. updates docs for data aws_eip filter

    @richardbowden
    richardbowden committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    10f42ab View commit details
    Browse the repository at this point in the history