-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_s3_bucket: Migrate to AWS SDK for Go v2 #35035
Conversation
# Conflicts: # internal/service/s3/tags_gen.go # internal/service/s3/tagsv2_gen.go
Community NoteVoting for Prioritization
For Submitters
|
% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_basic' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3Bucket_Basic_basic -timeout 360m === RUN TestAccS3Bucket_Basic_basic === PAUSE TestAccS3Bucket_Basic_basic === CONT TestAccS3Bucket_Basic_basic --- PASS: TestAccS3Bucket_Basic_basic (23.85s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 29.112s
…3_bucket-aws-sdk-go-v2
… and 'website_endpoint'.
…checksum- HTTP header is required for Put Object requests with Object Lock parameters'.
% make testacc TESTARGS='-run=TestAccS3Bucket_Basic' PKG=s3 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2 -run=TestAccS3Bucket_Basic -timeout 360m === RUN TestAccS3Bucket_Basic_basic === PAUSE TestAccS3Bucket_Basic_basic === RUN TestAccS3Bucket_Basic_emptyString === PAUSE TestAccS3Bucket_Basic_emptyString === RUN TestAccS3Bucket_Basic_nameGenerated === PAUSE TestAccS3Bucket_Basic_nameGenerated === RUN TestAccS3Bucket_Basic_namePrefix === PAUSE TestAccS3Bucket_Basic_namePrefix === RUN TestAccS3Bucket_Basic_forceDestroy === PAUSE TestAccS3Bucket_Basic_forceDestroy === RUN TestAccS3Bucket_Basic_forceDestroyWithObjectVersions === PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectVersions === RUN TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes === PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes === RUN TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled === PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled === RUN TestAccS3Bucket_Basic_acceleration === PAUSE TestAccS3Bucket_Basic_acceleration === RUN TestAccS3Bucket_Basic_keyEnabled === PAUSE TestAccS3Bucket_Basic_keyEnabled === RUN TestAccS3Bucket_Basic_requestPayer === PAUSE TestAccS3Bucket_Basic_requestPayer === CONT TestAccS3Bucket_Basic_basic === CONT TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes --- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (22.21s) === CONT TestAccS3Bucket_Basic_namePrefix --- PASS: TestAccS3Bucket_Basic_basic (26.75s) === CONT TestAccS3Bucket_Basic_forceDestroyWithObjectVersions --- PASS: TestAccS3Bucket_Basic_namePrefix (25.25s) === CONT TestAccS3Bucket_Basic_forceDestroy --- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectVersions (25.54s) === CONT TestAccS3Bucket_Basic_nameGenerated --- PASS: TestAccS3Bucket_Basic_forceDestroy (20.70s) === CONT TestAccS3Bucket_Basic_emptyString --- PASS: TestAccS3Bucket_Basic_nameGenerated (25.31s) === CONT TestAccS3Bucket_Basic_keyEnabled --- PASS: TestAccS3Bucket_Basic_emptyString (24.56s) === CONT TestAccS3Bucket_Basic_requestPayer --- PASS: TestAccS3Bucket_Basic_keyEnabled (27.07s) === CONT TestAccS3Bucket_Basic_acceleration --- PASS: TestAccS3Bucket_Basic_requestPayer (42.40s) === CONT TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled --- PASS: TestAccS3Bucket_Basic_acceleration (44.84s) --- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (25.03s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 165.750s
…pes.Permission, not string'.
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Migrates
aws_s3_bucket
to AWS SDK for Go v2, completing this service's migration.Relations
Closes #33654.
Closes #17000.
Closes #17564.
Closes #23291.
Output from Acceptance Testing
Failures are unrelated to this change: #35054.