Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared_accounts parameter to db_snapshot_copy #34843

Merged
merged 32 commits into from
Jul 25, 2024
Merged

Add shared_accounts parameter to db_snapshot_copy #34843

merged 32 commits into from
Jul 25, 2024

Commits on Dec 9, 2023

  1. Add shared_accounts parameter to db_snapshot_copy

    @OpenGLShaders
    OpenGLShaders committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    a081a27 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. formatting

    @OpenGLShaders
    OpenGLShaders committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d72a082 View commit details
    Browse the repository at this point in the history

  2. make it compile

    @OpenGLShaders
    OpenGLShaders committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    624fb61 View commit details
    Browse the repository at this point in the history

  3. adding tests

    @OpenGLShaders
    OpenGLShaders committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    0dac5ca View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'main' into HEAD

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c3e09ef View commit details
    Browse the repository at this point in the history

  2. Run 'make fix-constants PKG=rds'.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    540935a View commit details
    Browse the repository at this point in the history

  3. Correct CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bfb2c0f View commit details
    Browse the repository at this point in the history

  4. Cosmetics.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    550b6a5 View commit details
    Browse the repository at this point in the history

  5. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_ -timeout 360m
=== RUN   TestAccRDSSnapshotCopy_basic
=== PAUSE TestAccRDSSnapshotCopy_basic
=== RUN   TestAccRDSSnapshotCopy_share
=== PAUSE TestAccRDSSnapshotCopy_share
=== RUN   TestAccRDSSnapshotCopy_tags
=== PAUSE TestAccRDSSnapshotCopy_tags
=== RUN   TestAccRDSSnapshotCopy_disappears
=== PAUSE TestAccRDSSnapshotCopy_disappears
=== RUN   TestAccRDSSnapshot_basic
=== PAUSE TestAccRDSSnapshot_basic
=== RUN   TestAccRDSSnapshot_share
=== PAUSE TestAccRDSSnapshot_share
=== RUN   TestAccRDSSnapshot_tags
=== PAUSE TestAccRDSSnapshot_tags
=== RUN   TestAccRDSSnapshot_disappears
=== PAUSE TestAccRDSSnapshot_disappears
=== CONT  TestAccRDSSnapshotCopy_basic
=== CONT  TestAccRDSSnapshot_basic
=== CONT  TestAccRDSSnapshotCopy_tags
--- PASS: TestAccRDSSnapshot_basic (672.32s)
=== CONT  TestAccRDSSnapshotCopy_disappears
--- PASS: TestAccRDSSnapshotCopy_basic (722.32s)
=== CONT  TestAccRDSSnapshot_tags
--- PASS: TestAccRDSSnapshotCopy_tags (750.45s)
=== CONT  TestAccRDSSnapshot_disappears
--- PASS: TestAccRDSSnapshotCopy_disappears (749.22s)
=== CONT  TestAccRDSSnapshot_share
--- PASS: TestAccRDSSnapshot_tags (780.17s)
=== CONT  TestAccRDSSnapshotCopy_share
--- PASS: TestAccRDSSnapshot_disappears (880.85s)
--- PASS: TestAccRDSSnapshot_share (745.66s)
--- PASS: TestAccRDSSnapshotCopy_share (920.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2427.826s
    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    369eb17 View commit details
    Browse the repository at this point in the history

  6. Add 'tfslices.PredicateValue'.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2bd3fd3 View commit details
    Browse the repository at this point in the history

  7. r/aws_db_snapshot: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e386006 View commit details
    Browse the repository at this point in the history

  8. d/aws_db_snapshot: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b0c847e View commit details
    Browse the repository at this point in the history

  9. r/aws_db_snapshot_copy: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6451df9 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_ -timeout 360m
=== RUN   TestAccRDSSnapshotCopy_basic
=== PAUSE TestAccRDSSnapshotCopy_basic
=== RUN   TestAccRDSSnapshotCopy_share
=== PAUSE TestAccRDSSnapshotCopy_share
=== RUN   TestAccRDSSnapshotCopy_tags
=== PAUSE TestAccRDSSnapshotCopy_tags
=== RUN   TestAccRDSSnapshotCopy_disappears
=== PAUSE TestAccRDSSnapshotCopy_disappears
=== RUN   TestAccRDSSnapshot_basic
=== PAUSE TestAccRDSSnapshot_basic
=== RUN   TestAccRDSSnapshot_share
=== PAUSE TestAccRDSSnapshot_share
=== RUN   TestAccRDSSnapshot_tags
=== PAUSE TestAccRDSSnapshot_tags
=== RUN   TestAccRDSSnapshot_disappears
=== PAUSE TestAccRDSSnapshot_disappears
=== CONT  TestAccRDSSnapshotCopy_basic
=== CONT  TestAccRDSSnapshot_basic
=== CONT  TestAccRDSSnapshotCopy_tags
--- PASS: TestAccRDSSnapshot_basic (663.28s)
=== CONT  TestAccRDSSnapshotCopy_share
--- PASS: TestAccRDSSnapshotCopy_tags (665.45s)
=== CONT  TestAccRDSSnapshotCopy_disappears
--- PASS: TestAccRDSSnapshotCopy_basic (857.90s)
=== CONT  TestAccRDSSnapshot_tags
--- PASS: TestAccRDSSnapshotCopy_disappears (485.91s)
=== CONT  TestAccRDSSnapshot_disappears
--- PASS: TestAccRDSSnapshotCopy_share (507.17s)
=== CONT  TestAccRDSSnapshot_share
--- PASS: TestAccRDSSnapshot_tags (468.80s)
--- PASS: TestAccRDSSnapshot_disappears (231.80s)
--- PASS: TestAccRDSSnapshot_share (228.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1403.830s
    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f061e67 View commit details
    Browse the repository at this point in the history

  2. Add 'TestAccRDSSnapshotCopy_destinationRegion'.

    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4c72379 View commit details
    Browse the repository at this point in the history

  3. Acceptance test output: 

    % make testacc TESTARGS='-run=TestAccRDSSnapshotCopy_destinationRegion' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSSnapshotCopy_destinationRegion -timeout 360m
=== RUN   TestAccRDSSnapshotCopy_destinationRegion
=== PAUSE TestAccRDSSnapshotCopy_destinationRegion
=== CONT  TestAccRDSSnapshotCopy_destinationRegion
--- PASS: TestAccRDSSnapshotCopy_destinationRegion (768.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	772.855s
    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    09e90c5 View commit details
    Browse the repository at this point in the history

  4. r/aws_db_snapshot: Add '% progress' to 'waitDBSnapshotCreated'.

    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    917a7e9 View commit details
    Browse the repository at this point in the history

  5. r/aws_db_snapshot_copy: Migrate 'destination_region' functionality to… 

    … AWS SDK for Go v2.
    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d5a480c View commit details
    Browse the repository at this point in the history

  6. d/aws_rds_reserved_instance_offering: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    86dd6f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. r/aws_db_parameter_group: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4a62b96 View commit details
    Browse the repository at this point in the history

  2. Fix 'TestAccRDSParameterGroup_caseParameters'.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    24a397b View commit details
    Browse the repository at this point in the history

  3. r/aws_rds_cluster_parameter_group: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    18f2da3 View commit details
    Browse the repository at this point in the history

  4. rds: Move flatteners and expanders around.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6826612 View commit details
    Browse the repository at this point in the history

  5. r/aws_rds_cluster_endpoint: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9606c59 View commit details
    Browse the repository at this point in the history

  6. r/aws_rds_cluster_endpoint: Fix acceptance tests.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    95815c3 View commit details
    Browse the repository at this point in the history

  7. r/aws_rds_cluster_role_association: Migrate to AWS SDK for Go v2.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ee1b5ad View commit details
    Browse the repository at this point in the history

  8. Fix semgrep 'ci.semgrep.pluginsdk.append-Read-to-diags'.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8df8631 View commit details
    Browse the repository at this point in the history

  9. Fix golangci-lint 'whitespace'.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    07d29de View commit details
    Browse the repository at this point in the history

  10. Fix golangci-lint 'unparam'.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    008a0f1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into HEAD

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ab5629 View commit details
    Browse the repository at this point in the history

  12. Fix terrafmt error.

    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    336d2c0 View commit details
    Browse the repository at this point in the history

  13. rds: Skip 'no matching RDS Reserved Instance Offering found' acceptan… 

    …ce test failures.
    @ewbankkit
    ewbankkit committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    446ff1b View commit details
    Browse the repository at this point in the history