Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finspace: Increase kx_cluster create/update and kx_environment delete timeouts #34398

Merged
merged 5 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changelog/34398.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
```release-note:enhancement
resource/aws_finspace_kx_cluster: Increase default create and update timeouts to 4 hours to allow for increased startup times with large volumes of cached data
```
```release-note:enhancement
resource/aws_finspace_kx_environment: Increase default delete timeout to 75 minutes
```
4 changes: 2 additions & 2 deletions internal/service/finspace/kx_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ func ResourceKxCluster() *schema.Resource {
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(45 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Create: schema.DefaultTimeout(4 * time.Hour),
Update: schema.DefaultTimeout(4 * time.Hour),
Delete: schema.DefaultTimeout(60 * time.Minute),
},

Expand Down
2 changes: 1 addition & 1 deletion internal/service/finspace/kx_environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func ResourceKxEnvironment() *schema.Resource {
Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(30 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Delete: schema.DefaultTimeout(45 * time.Minute),
Delete: schema.DefaultTimeout(75 * time.Minute),
},

Schema: map[string]*schema.Schema{
Expand Down
14 changes: 12 additions & 2 deletions website/docs/r/finspace_kx_cluster.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ resource "aws_finspace_kx_cluster" "example" {
s3_bucket = aws_s3_bucket.test.id
s3_key = aws_s3_object.object.key
}

# Depending on the amount of data cached, create/update timeouts
# may need to be increased up to a potential maximum of 18 hours.
timeouts {
create = "18h"
update = "18h"
}
}
```

Expand Down Expand Up @@ -123,6 +130,9 @@ The cache_storage_configuration block supports the following arguments:
* CACHE_12 - This type provides 12 MB/s disk access throughput.
* `size` - (Required) Size of cache in Gigabytes.

Please note that create/update timeouts may have to be adjusted from the default 4 hours depending upon the
volume of data being cached, as noted in the example configuration.

### code

The code block supports the following arguments:
Expand Down Expand Up @@ -177,8 +187,8 @@ This resource exports the following attributes in addition to the arguments abov

[Configuration options](https://developer.hashicorp.com/terraform/language/resources/syntax#operation-timeouts):

* `create` - (Default `45m`)
* `update` - (Default `30m`)
* `create` - (Default `4h`)
* `update` - (Default `4h`)
* `delete` - (Default `60m`)

## Import
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/finspace_kx_environment.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ This resource exports the following attributes in addition to the arguments abov

* `create` - (Default `30m`)
* `update` - (Default `30m`)
* `delete` - (Default `45m`)
* `delete` - (Default `75m`)

## Import

Expand Down
Loading