-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GPG key sourced from GitHub #34301
base: main
Are you sure you want to change the base?
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @chomatdam 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
e931d73
to
9f57db4
Compare
@justinretzolk is there anything else I should add to this PR or just about being patient until it gets reviewed/merged? 🙂 |
@justinretzolk it has been a couple of months, is there anything on my end to get it merged, or you take over this PR when you have time? |
Hey @chomatdam 👋 Thank you for your contribution, and for checking in here! Sorry to have missed your last ping. I can't speak to when this will be prioritized just yet -- we base our prioritization on the count of 👍 reactions and a few other considerations. We have a document (found here) with a bit more information if you're interested. In short, there's nothing that you need to do at this time 🙂. |
Update doc and changelog Move around code for unit testing Fix unit test Add acceptance test 1/2 Add acceptance test 2/2 Signed-off-by: Damien Chomat <[email protected]>
fab3365
to
773dc75
Compare
commits squashed + conflicts resolved |
Description
The
pgp_key
property is used by a few resources to encrypt outputs containing sensitive data around user credentials. Currently, two ways are supported:keybase:chomatdam
This pull request improves the existing feature by pulling the latest GPG public key associated with a GitHub username.
Resources
aws_iam_access_key
aws_iam_user_login_profile
Example
Added Dependencies
Unit Tests
TestFetchLatestGitHubPublicKey
Acceptance Tests
Build
✅ Provider built and real-life tested 🙂