Add support for GPG key sourced from GitHub

[chomatdam]

Description

The pgp_key property is used by a few resources to encrypt outputs containing sensitive data around user credentials. Currently, two ways are supported:

• inline GPG public key
• Keybase username, e.g. keybase:chomatdam

This pull request improves the existing feature by pulling the latest GPG public key associated with a GitHub username.

Resources

• aws_iam_access_key
• aws_iam_user_login_profile

Example

resource "aws_iam_access_key" "chomatdam" {
  user    = aws_iam_user.chomatdam.name
  pgp_key = "github:chomatdam"
}

Added Dependencies

• protonmail/gopenpgp: added to get support for ed25519 key type, golang.org/x/crypto/openpgp being now unmaintained

Unit Tests

TestFetchLatestGitHubPublicKey

Acceptance Tests

% make testacc TESTS=TestAccIAMUserLoginProfile_github PKG=iam
% make testacc TESTS=TestAccIAMAccessKey_encryptedByGitHubGPGKey PKG=iam

Build

✅ Provider built and real-life tested 🙂

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @chomatdam 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[chomatdam]

@justinretzolk is there anything else I should add to this PR or just about being patient until it gets reviewed/merged? 🙂

[chomatdam]

@justinretzolk it has been a couple of months, is there anything on my end to get it merged, or you take over this PR when you have time?

[justinretzolk]

Hey @chomatdam 👋 Thank you for your contribution, and for checking in here! Sorry to have missed your last ping. I can't speak to when this will be prioritized just yet -- we base our prioritization on the count of 👍 reactions and a few other considerations. We have a document (found here) with a bit more information if you're interested. In short, there's nothing that you need to do at this time 🙂.

[chomatdam]

commits squashed + conflicts resolved