Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws_dms_s3_endpoint] Remove the default value of false for add_trailing_padding_character #34048

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[aws_dms_s3_endpoint] Remove the default value of false for add_trailing_padding_character #34048

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32536b5
[aws_dms_s3_endpoint] Remove the default value of `false` for `add_tr…
sodle Oct 21, 2023
13aada9
Tweak CHANGELOG entry.
ewbankkit Oct 23, 2023
eefd725
fix typo
sodle Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/32698.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_dms_s3_endpoint: Don't send the default value of `false` for `add_trailing_padding_character` to maintain compatability with older ((pre-3.4.7)[https://docs.aws.amazon.com/dms/latest/userguide/CHAP_ReleaseNotes.html#CHAP_ReleaseNotes.DMS347]) DMS engine versions
```
4 changes: 2 additions & 2 deletions internal/service/dms/s3_endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,8 @@ func s3Settings(d *schema.ResourceData, target bool) *dms.S3Settings {
s3s.AddColumnName = aws.Bool(v)
}

if v, ok := d.Get("add_trailing_padding_character").(bool); ok && target { // target
s3s.AddTrailingPaddingCharacter = aws.Bool(v)
if v, ok := d.GetOk("add_trailing_padding_character"); ok && target { // target
s3s.AddTrailingPaddingCharacter = aws.Bool(v.(bool))
}

if v, ok := d.GetOk("bucket_folder"); ok {
Expand Down
Loading