Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSource AWS Apigatewayv2 Vpc Link #33975

Merged

Conversation

hunttom
Copy link
Contributor

@hunttom hunttom commented Oct 17, 2023

Description

Feature request: New data source for API Gateway V2 VPC Link

Relations

Closes #12958

References

AWS API Gateway V2 API Documentation

Output from Acceptance Testing

 $ make testacc TESTS=TestAccAPIGatewayV2VPCLinkData_basic PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2VPCLinkData_basic'  -timeout 360m
=== RUN   TestAccAPIGatewayV2VPCLinkData_basic
=== PAUSE TestAccAPIGatewayV2VPCLinkData_basic
=== CONT  TestAccAPIGatewayV2VPCLinkData_basic
--- PASS: TestAccAPIGatewayV2VPCLinkData_basic (441.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       444.667s

### Relations
Closes #12958

### References
[AWS API Gateway V2 API Documentation](https://docs.aws.amazon.com/apigatewayv2/latest/api-reference/vpclinks-vpclinkid.html)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. generators Relates to code generators. labels Oct 17, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 17, 2023
@hunttom hunttom changed the title DataSource AWS Apigatewayv2 Vpc Link [WIP] DataSource AWS Apigatewayv2 Vpc Link Oct 18, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 23, 2023
@hunttom hunttom changed the title [WIP] DataSource AWS Apigatewayv2 Vpc Link DataSource AWS Apigatewayv2 Vpc Link Nov 3, 2023
@hunttom hunttom changed the title DataSource AWS Apigatewayv2 Vpc Link [WIP] DataSource AWS Apigatewayv2 Vpc Link Nov 3, 2023
@kpena027
Copy link
Contributor

kpena027 commented Nov 3, 2023

LGTM 🚀

@hunttom hunttom changed the title [WIP] DataSource AWS Apigatewayv2 Vpc Link DataSource AWS Apigatewayv2 Vpc Link Nov 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayV2VPCLink' PKG=apigatewayv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 2  -run=TestAccAPIGatewayV2VPCLink -timeout 360m
=== RUN   TestAccAPIGatewayV2VPCLinkDataSource_basic
=== PAUSE TestAccAPIGatewayV2VPCLinkDataSource_basic
=== RUN   TestAccAPIGatewayV2VPCLink_basic
=== PAUSE TestAccAPIGatewayV2VPCLink_basic
=== RUN   TestAccAPIGatewayV2VPCLink_disappears
=== PAUSE TestAccAPIGatewayV2VPCLink_disappears
=== RUN   TestAccAPIGatewayV2VPCLink_tags
=== PAUSE TestAccAPIGatewayV2VPCLink_tags
=== CONT  TestAccAPIGatewayV2VPCLinkDataSource_basic
=== CONT  TestAccAPIGatewayV2VPCLink_disappears
--- PASS: TestAccAPIGatewayV2VPCLink_disappears (166.53s)
=== CONT  TestAccAPIGatewayV2VPCLink_tags
--- PASS: TestAccAPIGatewayV2VPCLinkDataSource_basic (187.87s)
=== CONT  TestAccAPIGatewayV2VPCLink_basic
--- PASS: TestAccAPIGatewayV2VPCLink_basic (333.63s)
--- PASS: TestAccAPIGatewayV2VPCLink_tags (393.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	566.275s
% make testacc TESTARGS='-run=TestAccAPIGatewayV2Deployment_' PKG=apigatewayv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 2  -run=TestAccAPIGatewayV2Deployment_ -timeout 360m
=== RUN   TestAccAPIGatewayV2Deployment_basic
=== PAUSE TestAccAPIGatewayV2Deployment_basic
=== RUN   TestAccAPIGatewayV2Deployment_disappears
=== PAUSE TestAccAPIGatewayV2Deployment_disappears
=== RUN   TestAccAPIGatewayV2Deployment_triggers
=== PAUSE TestAccAPIGatewayV2Deployment_triggers
=== CONT  TestAccAPIGatewayV2Deployment_basic
=== CONT  TestAccAPIGatewayV2Deployment_triggers
--- PASS: TestAccAPIGatewayV2Deployment_basic (51.25s)
=== CONT  TestAccAPIGatewayV2Deployment_disappears
--- PASS: TestAccAPIGatewayV2Deployment_disappears (26.92s)
--- PASS: TestAccAPIGatewayV2Deployment_triggers (88.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	94.702s

@ewbankkit
Copy link
Contributor

@hunttom Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ec5d398 into hashicorp:main Nov 9, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 9, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New data source: aws_apigatewayv2_vpc_link
5 participants