Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] F amazon bedrock #33816

Closed
wants to merge 50 commits into from
Closed

Conversation

skyscrapr
Copy link
Contributor

@skyscrapr skyscrapr commented Oct 9, 2023

Description

Amazon Bedrock New Service Implementation

Relations

Closes #33809.
Closes #33738.
Closes #33737.
Closes #33718.

References

Amazon Bedrock API

Output from Acceptance Testing

TBD

% make testacc TESTS=TestAccXXX PKG=ec2

...

@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 9, 2023
@skyscrapr
Copy link
Contributor Author

There are a number of areas that need design discussion:

resource_aws_bedrock_custom_model:
-- I chose to not export the model customisation job as a resource since this cannot be managed or deleted.
-- Instead I chose to create a custom model resource and wrap the customisation job in that handling.
-- This has a couple of implications for tag handling.
-- What is the best way to handle failures for resources with long creation times? I've chosen to save the ID's in state as early as possible to facilitate destroy/create by the built-in taint behaviour. Is that a good approach?
-- I'll upload the test output if the current implementation is approved.

@wellsiau-aws feel free to loop in anyone that might be interested in reviewing.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 9, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Oct 9, 2023
@ewbankkit ewbankkit added the service/bedrock Issues and PRs that pertain to the bedrock service. label Oct 9, 2023
@breathingdust
Copy link
Member

Hi @skyscrapr! 👋 Thanks for the contribution, I know it’s WIP but I noticed a few things at first glance

This week we are finally making a policy change to require that net new resources are based on AWS Go SDK v2 and terraform-plugin-framework rather than terraform-plugin-sdk. These resources will need to be updated to confirm as a result. It should not be complex to do, but do reach out if you have any questions.

Additionally, if possible we also like to see one PR per resource/data source when ready for final review. It can be very difficult/inefficient for maintainers to review PR’s with multiple additions.

Thank you!

@skyscrapr
Copy link
Contributor Author

I'm opening a bunch of new ones PRs to cover the recommendation above.
Please close.

@AdamTylerLynch
Copy link
Collaborator

I'm opening a bunch of new ones PRs to cover the recommendation above. Please close.

@skyscrapr do you want us to close this PR without any merge? Do you new PRs #34042 and #34043 supersede this PR?

@skyscrapr
Copy link
Contributor Author

@AdamTylerLynch

This PR is against sdk v1.
New PRs are against sdk v2.

As soon as the current open PRs are approved, I'll raise the remaining PRs for the other data sources and resources.

This one can be closed 👍. Thanks

@skyscrapr
Copy link
Contributor Author

I'm closing this as the new PRs have all been raised. Thanks!

@skyscrapr skyscrapr closed this Nov 10, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/bedrock Issues and PRs that pertain to the bedrock service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
4 participants