-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] F amazon bedrock #33816
[WIP] F amazon bedrock #33816
Conversation
There are a number of areas that need design discussion: resource_aws_bedrock_custom_model: @wellsiau-aws feel free to loop in anyone that might be interested in reviewing. |
Hi @skyscrapr! 👋 Thanks for the contribution, I know it’s WIP but I noticed a few things at first glance This week we are finally making a policy change to require that net new resources are based on AWS Go SDK v2 and terraform-plugin-framework rather than terraform-plugin-sdk. These resources will need to be updated to confirm as a result. It should not be complex to do, but do reach out if you have any questions. Additionally, if possible we also like to see one PR per resource/data source when ready for final review. It can be very difficult/inefficient for maintainers to review PR’s with multiple additions. Thank you! |
I'm opening a bunch of new ones PRs to cover the recommendation above. |
@skyscrapr do you want us to close this PR without any merge? Do you new PRs #34042 and #34043 supersede this PR? |
This PR is against sdk v1. As soon as the current open PRs are approved, I'll raise the remaining PRs for the other data sources and resources. This one can be closed 👍. Thanks |
I'm closing this as the new PRs have all been raised. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Amazon Bedrock New Service Implementation
Relations
Closes #33809.
Closes #33738.
Closes #33737.
Closes #33718.
References
Amazon Bedrock API
Output from Acceptance Testing
TBD