Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_object: Test access through a multi-region access point #33677

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 28, 2023

Description

Tests the aws_s3_object using an MRAP.

Relations

Relates #33358.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPoint_putAndGetObject' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlMultiRegionAccessPoint_putAndGetObject -timeout 360m
=== RUN   TestAccS3ControlMultiRegionAccessPoint_putAndGetObject
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_putAndGetObject
=== CONT  TestAccS3ControlMultiRegionAccessPoint_putAndGetObject
--- PASS: TestAccS3ControlMultiRegionAccessPoint_putAndGetObject (257.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	262.784s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3control Issues and PRs that pertain to the s3control service. labels Sep 28, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 28, 2023
@ewbankkit ewbankkit merged commit dbf42d7 into main Sep 28, 2023
31 of 33 checks passed
@ewbankkit ewbankkit deleted the t-aws_s3control_multi_region_access_point-put-and-get-object branch September 28, 2023 20:39
@github-actions github-actions bot added this to the v5.19.0 milestone Sep 28, 2023
@github-actions
Copy link

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/s3control Issues and PRs that pertain to the s3control service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant