-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3: Enable use of AWS SDK for Go v2 #33304
Conversation
% make testacc TESTARGS='-run=TestAccS3CanonicalUserIDDataSource_' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3CanonicalUserIDDataSource_ -timeout 180m === RUN TestAccS3CanonicalUserIDDataSource_basic === PAUSE TestAccS3CanonicalUserIDDataSource_basic === CONT TestAccS3CanonicalUserIDDataSource_basic --- PASS: TestAccS3CanonicalUserIDDataSource_basic (31.20s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 37.281s
% make testacc TESTARGS='-run=TestAccS3ObjectsDataSource_' PKG=s3 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3ObjectsDataSource_ -timeout 180m === RUN TestAccS3ObjectsDataSource_basic === PAUSE TestAccS3ObjectsDataSource_basic === RUN TestAccS3ObjectsDataSource_basicViaAccessPoint === PAUSE TestAccS3ObjectsDataSource_basicViaAccessPoint === RUN TestAccS3ObjectsDataSource_prefixes === PAUSE TestAccS3ObjectsDataSource_prefixes === RUN TestAccS3ObjectsDataSource_encoded === PAUSE TestAccS3ObjectsDataSource_encoded === RUN TestAccS3ObjectsDataSource_maxKeys === PAUSE TestAccS3ObjectsDataSource_maxKeys === RUN TestAccS3ObjectsDataSource_startAfter === PAUSE TestAccS3ObjectsDataSource_startAfter === RUN TestAccS3ObjectsDataSource_fetchOwner === PAUSE TestAccS3ObjectsDataSource_fetchOwner === CONT TestAccS3ObjectsDataSource_basic === CONT TestAccS3ObjectsDataSource_maxKeys === CONT TestAccS3ObjectsDataSource_fetchOwner --- PASS: TestAccS3ObjectsDataSource_basic (48.69s) === CONT TestAccS3ObjectsDataSource_startAfter --- PASS: TestAccS3ObjectsDataSource_fetchOwner (48.82s) === CONT TestAccS3ObjectsDataSource_prefixes --- PASS: TestAccS3ObjectsDataSource_maxKeys (87.02s) === CONT TestAccS3ObjectsDataSource_encoded --- PASS: TestAccS3ObjectsDataSource_startAfter (46.36s) === CONT TestAccS3ObjectsDataSource_basicViaAccessPoint --- PASS: TestAccS3ObjectsDataSource_prefixes (46.24s) --- PASS: TestAccS3ObjectsDataSource_encoded (43.09s) --- PASS: TestAccS3ObjectsDataSource_basicViaAccessPoint (43.34s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 145.202s
… than `1000`. Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ObjectsDataSource_maxKeys' PKG=s3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run=TestAccS3ObjectsDataSource_maxKeys -timeout 180m === RUN TestAccS3ObjectsDataSource_maxKeysSmall === PAUSE TestAccS3ObjectsDataSource_maxKeysSmall === RUN TestAccS3ObjectsDataSource_maxKeysLarge === PAUSE TestAccS3ObjectsDataSource_maxKeysLarge === CONT TestAccS3ObjectsDataSource_maxKeysSmall === CONT TestAccS3ObjectsDataSource_maxKeysLarge --- PASS: TestAccS3ObjectsDataSource_maxKeysSmall (76.54s) --- PASS: TestAccS3ObjectsDataSource_maxKeysLarge (232.58s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 238.411s
Community NoteVoting for Prioritization
For Submitters
|
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Enable use of AWS SDK for Go v2 for S3 resources.
Migrate the
aws_canonical_user_id
andaws_s3_objects
data sources.Relations
Closes #26569.
Relates #33028.
Output from Acceptance Testing
Verified (using the
aws_canonical_user_id
data source) that the defaults for S3 API endpoints have not changed: