Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to add subnets/-mappings to a Network LoadBalancer #33205

Merged
merged 20 commits into from
Dec 12, 2023

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    525b02a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    fe68d86 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Configuration menu
    Copy the full SHA
    7d43256 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Revert "feat: updating security groups for NLBs doesn't trigger a rep…

    …lacement"
    
    This reverts commit 7d43256.
    ewbankkit committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    12991b0 View commit details
    Browse the repository at this point in the history
  2. Revert "add test case for adding / deleting subnets"

    This reverts commit fe68d86.
    ewbankkit committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9ffab68 View commit details
    Browse the repository at this point in the history
  3. Revert "allow to add subnets/ mappings to a lb"

    This reverts commit 525b02a.
    ewbankkit committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c921939 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    51fd5a4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    96f9c5b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d4014b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. r/aws_lb: Allow the number of subnets to be be increased without re…

    …creating the resource.
    ewbankkit committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    33becdb View commit details
    Browse the repository at this point in the history
  2. r/aws_lb: Add plan-time validation that exactly one of either `subnet…

    …s` or `subnet_mapping` is configured.
    ewbankkit committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d397036 View commit details
    Browse the repository at this point in the history
  3. r/aws_lb: Allow the number of subnet_mappings for Network Load Bala…

    …ncers to be be increased without recreating the resource.
    ewbankkit committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    eec932d View commit details
    Browse the repository at this point in the history
  4. Add 'TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMappin…

    …g' and 'TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping'.
    ewbankkit committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    2511323 View commit details
    Browse the repository at this point in the history
  5. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet\|TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet' PKG=elbv2 ACCTEST_PARALLELISM=3
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet\|TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet -timeout 360m
    === RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
    === PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
    === RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
    === PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
    === RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
    === PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
    === RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
    === PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
    === CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
    === CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
    === CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
    --- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet (239.58s)
    === CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
    --- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping (257.80s)
    --- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet (258.07s)
    --- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping (254.97s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	499.680s
    ewbankkit committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5523eee View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Add 'TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping' a…

    …nd 'TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping'.
    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    47d0d31 View commit details
    Browse the repository at this point in the history
  2. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet' PKG=elbv2 ACCTEST_PARALLELISM=3
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet -timeout 360m
    === RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
    === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
    === RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
    === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
    === RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
    === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
    === RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
    === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
    === CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
    === CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
    === CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
    --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping (323.53s)
    === CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
    --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet (323.54s)
    --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet (450.07s)
    --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping (443.14s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	771.964s
    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2d7e13a View commit details
    Browse the repository at this point in the history
  3. r/aws_lb: Correct in-place update of security_groups for Network Lo…

    …ad Balancers when the new value is Computed.
    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e2f1d4b View commit details
    Browse the repository at this point in the history
  4. Fix spelling mistake.

    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6277115 View commit details
    Browse the repository at this point in the history
  5. Fix typo.

    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    abff416 View commit details
    Browse the repository at this point in the history
  6. Tweak CHANGELOG entries.

    ewbankkit committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    fbf19f1 View commit details
    Browse the repository at this point in the history