-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource] DMS Serverless Replication resource #32908
[New Resource] DMS Serverless Replication resource #32908
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hi @DanielRieske I was really wanting to test this MR (i.e. get early access) , could you possibly point me to any instructions on compiling and using this within terraform? cheers |
Hiya @csbain 👋 , you should be able to clone my fork and checkout the branch. Keep in mind that this feature isn't final and might be changed during code review. |
It's impressive to see your involvement in this 👏🏼 , @DanielRieske. Since we are direct colleagues, I'm more than willing to review it and provide feedback, but I would recommend having someone like @ewbankkit formally review and approve this. |
Hi @DanielRieske ! |
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_' PKG=dms ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSReplicationConfig_ -timeout 360m === RUN TestAccDMSReplicationConfig_basic === PAUSE TestAccDMSReplicationConfig_basic === RUN TestAccDMSReplicationConfig_update === PAUSE TestAccDMSReplicationConfig_update === RUN TestAccDMSReplicationConfig_startReplication === PAUSE TestAccDMSReplicationConfig_startReplication === CONT TestAccDMSReplicationConfig_basic === CONT TestAccDMSReplicationConfig_startReplication --- PASS: TestAccDMSReplicationConfig_basic (1492.04s) === CONT TestAccDMSReplicationConfig_update --- PASS: TestAccDMSReplicationConfig_update (1532.52s) --- PASS: TestAccDMSReplicationConfig_startReplication (3206.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 3212.085s
@DanielRieske Thanks for the contribution 🎉 👏. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_disappears\|TestAccDMSReplicationConfig_tags' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSReplicationConfig_disappears\|TestAccDMSReplicationConfig_tags -timeout 360m
=== RUN TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== CONT TestAccDMSReplicationConfig_disappears
=== CONT TestAccDMSReplicationConfig_tags
--- PASS: TestAccDMSReplicationConfig_tags (1644.31s)
--- PASS: TestAccDMSReplicationConfig_disappears (1599.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 1687.788s
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_basic\|TestAccDMSReplicationConfig_update\|TestAccDMSReplicationConfig_startReplication' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSReplicationConfig_basic\|TestAccDMSReplicationConfig_update\|TestAccDMSReplicationConfig_startReplication -timeout 360m
=== RUN TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT TestAccDMSReplicationConfig_basic
=== CONT TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationConfig_basic (1503.43s)
=== CONT TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationConfig_startReplication (3061.71s)
--- PASS: TestAccDMSReplicationConfig_update (1562.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 3097.219s
I see this was completed. Was the registry documentation updated for this provider on the Terraform website? |
Will be released tomorrow, September 28th in Terraform AWS Provider v5.19.0. Registry documentation is updated as part of the release. |
This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
aws_dms_serverless_replication
resource.This resource is a serverless option in DMS that automatically sets up, scales, and manages the migration of resources for your database migrations.
Relations
Closes #32162
Closes #32920
References
Output from Acceptance Testing