Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sfn_state_machine: Always set publish in resource Read #32844

Merged
merged 6 commits into from
Aug 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 3, 2023

Description

Ensure that publish is set in Terraform state.

Relations

Closes #32826.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSFNStateMachineVersionsDataSource_' PKG=sfn ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 2  -run=TestAccSFNStateMachineVersionsDataSource_ -timeout 180m
=== RUN   TestAccSFNStateMachineVersionsDataSource_basic
=== PAUSE TestAccSFNStateMachineVersionsDataSource_basic
=== CONT  TestAccSFNStateMachineVersionsDataSource_basic
--- PASS: TestAccSFNStateMachineVersionsDataSource_basic (121.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	126.533s
% make testacc TESTARGS='-run=TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 2  -run=TestAccSFNStateMachine_ -timeout 180m
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN   TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN   TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_createUpdate
=== CONT  TestAccSFNStateMachine_publish
--- PASS: TestAccSFNStateMachine_publish (133.35s)
=== CONT  TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNStateMachine_createUpdate (136.08s)
=== CONT  TestAccSFNStateMachine_namePrefix
--- PASS: TestAccSFNStateMachine_namePrefix (69.10s)
=== CONT  TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNStateMachine_nameGenerated (96.11s)
=== CONT  TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_standardUpdate (78.56s)
=== CONT  TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_expressUpdate (59.00s)
=== CONT  TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_disappears (89.79s)
=== CONT  TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNStateMachine_expressLogging (100.03s)
=== CONT  TestAccSFNStateMachine_tags
--- PASS: TestAccSFNStateMachine_tracing (72.45s)
--- PASS: TestAccSFNStateMachine_tags (141.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	535.204s

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sfn Issues and PRs that pertain to the sfn service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 3, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 3, 2023
@ewbankkit ewbankkit merged commit c00070c into main Aug 3, 2023
@ewbankkit ewbankkit deleted the b-aws_sfn_state_machine.publish branch August 3, 2023 17:32
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 3, 2023
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sfn Issues and PRs that pertain to the sfn service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_sfn_state_machine - Produced an invalid new value for .publish
2 participants