Don't mangle DNS aliases: Trim{Prefix,Suffix} not Trim{Left,Right}.

[handlerbot]

Description

A bug in Route 53 alias processing (where the leading string "dualstack." is removed, if present) will strip off all leading characters from a DNS alias name that are in the set of "dualstack." (or "acdklstu.", when sorted and de-duplicated), until it reaches a character that is not in that set. So, "dualstack.listenapi" becomes "istenapi" (instead of "listenapi") because "l" is in the set to trim, but "i" is not.

source

Fixes #3185

[Ninir]

Hi @handlerbot

Thanks for the fix. Added the link to your comment explaining the bug, and added and abstract to it.

Could you just add a unit test for this one, so that we ensure the output is all ok?

Thanks!

[handlerbot]

@Ninir @bflad OK, added two test cases to the existing test.

(Since I fixed this bug, can I put in a vote for getting a review and merge on #2625, which has been waiting patiently for a while now? Going to need it to turn up a lot of S3 buckets soon. :-))

[bflad]

Thank you for the quick submission and adding the additional test! Very sorry about the regression that was introduced.

I see your note about the S3 SSE PR and unfortunately I cannot give an exact time when that will get reviewed by myself personally. 🙁 I know a lot of people are waiting on it at the moment and it'll be awesome when it lands.

[bflad]

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!