Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws elasticache redis - support redis v7 #31264

Merged

Conversation

elrob
Copy link
Contributor

@elrob elrob commented May 8, 2023

Description

Support 7+ versions of AWS elasticache redis which require engine_version values which do not support the .x syntax introduced in version 6 (e.g. 6.x). Details are in the issue discussion linked below.

Relations

Closes #27918

@github-actions
Copy link

github-actions bot commented May 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 8, 2023
@elrob elrob force-pushed the f-aws_elasticache_redis-support_redis_v7 branch from 8201a0a to a8f501d Compare May 8, 2023 14:30
@elrob elrob force-pushed the f-aws_elasticache_redis-support_redis_v7 branch from a8f501d to d27500d Compare May 9, 2023 02:39
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 9, 2023
@gdavison gdavison self-assigned this Jun 8, 2023
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @elrob 🚀

--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_v7 (796.83s)

@gdavison gdavison merged commit e982255 into hashicorp:main Jun 13, 2023
@github-actions github-actions bot added this to the v5.3.0 milestone Jun 13, 2023
@elrob elrob deleted the f-aws_elasticache_redis-support_redis_v7 branch June 13, 2023 04:14
@github-actions
Copy link

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_elasticache_replication_group redis 7 support
3 participants