-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New VPCLattice resource for Access log subscription: aws_vpclattice_access_log_subscription #30896
New VPCLattice resource for Access log subscription: aws_vpclattice_access_log_subscription #30896
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @C123R 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCLatticeAccessLogSubscription_' PKG=vpclattice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2 -run=TestAccVPCLatticeAccessLogSubscription_ -timeout 180m
=== RUN TestAccVPCLatticeAccessLogSubscription_basic
=== PAUSE TestAccVPCLatticeAccessLogSubscription_basic
=== RUN TestAccVPCLatticeAccessLogSubscription_disappears
=== PAUSE TestAccVPCLatticeAccessLogSubscription_disappears
=== RUN TestAccVPCLatticeAccessLogSubscription_tags
=== PAUSE TestAccVPCLatticeAccessLogSubscription_tags
=== CONT TestAccVPCLatticeAccessLogSubscription_basic
=== CONT TestAccVPCLatticeAccessLogSubscription_tags
--- PASS: TestAccVPCLatticeAccessLogSubscription_basic (29.68s)
=== CONT TestAccVPCLatticeAccessLogSubscription_disappears
--- PASS: TestAccVPCLatticeAccessLogSubscription_disappears (18.51s)
--- PASS: TestAccVPCLatticeAccessLogSubscription_tags (52.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 58.239s
@C123R Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for AWS VPC Lattice Service Network or Services Access log subscription
Relations
Relates #30380
Closes #30807
References
API Reference: https://docs.aws.amazon.com/vpc-lattice/latest/APIReference/API_CreateAccessLogSubscription.html
API Docs: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/vpclattice
User Guide: https://docs.aws.amazon.com/vpc-lattice/latest/ug/
Output from Acceptance Testing