Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Reduce tags boilerplate code - Plugin SDK resources serverlessrepo (Phase 3c) #30642

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.
Relates #30512.
Relates #30516.
Relates #30517.
Relates #30533.
Relates #30534.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccServerlessRepoCloudFormationStack_' PKG=serverlessrepo ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/serverlessrepo/... -v -count 1 -parallel 3  -run=TestAccServerlessRepoCloudFormationStack_ -timeout 180m
=== RUN   TestAccServerlessRepoCloudFormationStack_basic
=== PAUSE TestAccServerlessRepoCloudFormationStack_basic
=== RUN   TestAccServerlessRepoCloudFormationStack_disappears
=== PAUSE TestAccServerlessRepoCloudFormationStack_disappears
=== RUN   TestAccServerlessRepoCloudFormationStack_versioned
=== PAUSE TestAccServerlessRepoCloudFormationStack_versioned
=== RUN   TestAccServerlessRepoCloudFormationStack_paired
=== PAUSE TestAccServerlessRepoCloudFormationStack_paired
=== RUN   TestAccServerlessRepoCloudFormationStack_tags
=== PAUSE TestAccServerlessRepoCloudFormationStack_tags
=== RUN   TestAccServerlessRepoCloudFormationStack_update
=== PAUSE TestAccServerlessRepoCloudFormationStack_update
=== CONT  TestAccServerlessRepoCloudFormationStack_basic
=== CONT  TestAccServerlessRepoCloudFormationStack_paired
=== CONT  TestAccServerlessRepoCloudFormationStack_versioned
--- PASS: TestAccServerlessRepoCloudFormationStack_paired (106.97s)
=== CONT  TestAccServerlessRepoCloudFormationStack_disappears
--- PASS: TestAccServerlessRepoCloudFormationStack_basic (127.41s)
=== CONT  TestAccServerlessRepoCloudFormationStack_update
--- PASS: TestAccServerlessRepoCloudFormationStack_disappears (97.65s)
=== CONT  TestAccServerlessRepoCloudFormationStack_tags
--- PASS: TestAccServerlessRepoCloudFormationStack_versioned (271.20s)
--- PASS: TestAccServerlessRepoCloudFormationStack_update (207.18s)
--- PASS: TestAccServerlessRepoCloudFormationStack_tags (234.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo	444.445s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. size/S Managed by automation to categorize the size of a PR. labels Apr 11, 2023
@ewbankkit ewbankkit merged commit df5be22 into main Apr 11, 2023
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-serverlessrepo branch April 11, 2023 14:39
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 11, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. service/serverlessrepo Issues and PRs that pertain to the serverlessrepo service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant