Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sweepers: Add Custom Routing Accelerator and VPC Lattice sweepers #30514

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Sweepers: Add Custom Routing Accelerator and VPC Lattice sweepers #30514

merged 4 commits into from
Apr 6, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 6, 2023 •
edited
Loading

Description

Adds test sweepers for Global Accelerator custom routing and VPC Lattice.

Relations

Relates #28922.
Relates #30380.

Output from Acceptance Testing

% make sweep SWEEPARGS=-sweep-run=aws_globalaccelerator_custom_routing_accelerator
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_globalaccelerator_custom_routing_accelerator -timeout 60m
2023/04/06 12:28:39 [DEBUG] Running Sweepers for region (us-west-2):
2023/04/06 12:28:39 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-west-2)
2023/04/06 12:28:40 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-west-2) in 835.967664ms
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_accelerator) has dependency (aws_globalaccelerator_custom_routing_listener), running..
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-west-2)
2023/04/06 12:28:40 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-west-2)
2023/04/06 12:28:40 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-west-2) in 133.759013ms
2023/04/06 12:28:40 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-west-2)
2023/04/06 12:28:40 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-west-2) in 126.040119ms
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-west-2)
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) already ran in region (us-west-2)
2023/04/06 12:28:40 Completed Sweepers for region (us-west-2) in 1.095988496s
2023/04/06 12:28:40 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_globalaccelerator_custom_routing_endpoint_group
	- aws_globalaccelerator_custom_routing_listener
	- aws_globalaccelerator_custom_routing_accelerator
2023/04/06 12:28:40 [DEBUG] Running Sweepers for region (us-east-1):
2023/04/06 12:28:40 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-east-1)
2023/04/06 12:28:40 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-east-1) in 493.724806ms
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_accelerator) has dependency (aws_globalaccelerator_custom_routing_listener), running..
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:40 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-east-1)
2023/04/06 12:28:40 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-east-1)
2023/04/06 12:28:41 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-east-1) in 122.429517ms
2023/04/06 12:28:41 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-east-1)
2023/04/06 12:28:41 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-east-1) in 141.607175ms
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-east-1)
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) already ran in region (us-east-1)
2023/04/06 12:28:41 Completed Sweepers for region (us-east-1) in 757.839293ms
2023/04/06 12:28:41 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_globalaccelerator_custom_routing_endpoint_group
	- aws_globalaccelerator_custom_routing_listener
	- aws_globalaccelerator_custom_routing_accelerator
2023/04/06 12:28:41 [DEBUG] Running Sweepers for region (us-east-2):
2023/04/06 12:28:41 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-east-2)
2023/04/06 12:28:41 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) in region (us-east-2) in 525.829736ms
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_accelerator) has dependency (aws_globalaccelerator_custom_routing_listener), running..
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-east-2)
2023/04/06 12:28:41 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-east-2)
2023/04/06 12:28:41 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_listener) in region (us-east-2) in 117.766212ms
2023/04/06 12:28:41 [DEBUG] Running Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-east-2)
2023/04/06 12:28:41 [DEBUG] Completed Sweeper (aws_globalaccelerator_custom_routing_accelerator) in region (us-east-2) in 125.341672ms
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) has dependency (aws_globalaccelerator_custom_routing_endpoint_group), running..
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_endpoint_group) already ran in region (us-east-2)
2023/04/06 12:28:41 [DEBUG] Sweeper (aws_globalaccelerator_custom_routing_listener) already ran in region (us-east-2)
2023/04/06 12:28:41 Completed Sweepers for region (us-east-2) in 769.002258ms
2023/04/06 12:28:41 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_globalaccelerator_custom_routing_endpoint_group
	- aws_globalaccelerator_custom_routing_listener
	- aws_globalaccelerator_custom_routing_accelerator
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.507s
% make sweep SWEEPARGS=-sweep-run=aws_vpclattice_service_network
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_vpclattice_service_network -timeout 60m
2023/04/06 14:11:01 [DEBUG] Running Sweepers for region (us-west-2):
2023/04/06 14:11:01 [DEBUG] Sweeper (aws_vpclattice_service_network) has dependency (aws_vpclattice_service), running..
2023/04/06 14:11:01 [DEBUG] Running Sweeper (aws_vpclattice_service) in region (us-west-2)
2023/04/06 14:11:02 [DEBUG] Completed Sweeper (aws_vpclattice_service) in region (us-west-2) in 905.218144ms
2023/04/06 14:11:02 [DEBUG] Running Sweeper (aws_vpclattice_service_network) in region (us-west-2)
2023/04/06 14:11:02 [DEBUG] Completed Sweeper (aws_vpclattice_service_network) in region (us-west-2) in 148.854371ms
2023/04/06 14:11:02 [DEBUG] Sweeper (aws_vpclattice_service) already ran in region (us-west-2)
2023/04/06 14:11:02 Completed Sweepers for region (us-west-2) in 1.054271911s
2023/04/06 14:11:02 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_vpclattice_service
	- aws_vpclattice_service_network
2023/04/06 14:11:02 [DEBUG] Running Sweepers for region (us-east-1):
2023/04/06 14:11:02 [DEBUG] Sweeper (aws_vpclattice_service_network) has dependency (aws_vpclattice_service), running..
2023/04/06 14:11:02 [DEBUG] Running Sweeper (aws_vpclattice_service) in region (us-east-1)
2023/04/06 14:11:02 [DEBUG] Completed Sweeper (aws_vpclattice_service) in region (us-east-1) in 315.702014ms
2023/04/06 14:11:02 [DEBUG] Running Sweeper (aws_vpclattice_service_network) in region (us-east-1)
2023/04/06 14:11:02 [DEBUG] Completed Sweeper (aws_vpclattice_service_network) in region (us-east-1) in 89.235793ms
2023/04/06 14:11:02 [DEBUG] Sweeper (aws_vpclattice_service) already ran in region (us-east-1)
2023/04/06 14:11:02 Completed Sweepers for region (us-east-1) in 404.984443ms
2023/04/06 14:11:02 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_vpclattice_service
	- aws_vpclattice_service_network
2023/04/06 14:11:02 [DEBUG] Running Sweepers for region (us-east-2):
2023/04/06 14:11:02 [DEBUG] Sweeper (aws_vpclattice_service_network) has dependency (aws_vpclattice_service), running..
2023/04/06 14:11:02 [DEBUG] Running Sweeper (aws_vpclattice_service) in region (us-east-2)
2023/04/06 14:11:02 [DEBUG] Completed Sweeper (aws_vpclattice_service) in region (us-east-2) in 375.263352ms
2023/04/06 14:11:02 [DEBUG] Running Sweeper (aws_vpclattice_service_network) in region (us-east-2)
2023/04/06 14:11:03 [DEBUG] Completed Sweeper (aws_vpclattice_service_network) in region (us-east-2) in 88.480103ms
2023/04/06 14:11:03 [DEBUG] Sweeper (aws_vpclattice_service) already ran in region (us-east-2)
2023/04/06 14:11:03 Completed Sweepers for region (us-east-2) in 463.799392ms
2023/04/06 14:11:03 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_vpclattice_service
	- aws_vpclattice_service_network
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.196s

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/vpclattice Issues and PRs that pertain to the vpclattice service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 6, 2023
@ewbankkit ewbankkit merged commit c025eab into main Apr 6, 2023
@ewbankkit ewbankkit deleted the s-globalaccelerator+vpclattice branch April 6, 2023 18:43
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit