New resource: aws_vpclattice_service_network_service_association

[meetreks]

Description

This change is to add a new resource for VPC Lattice Service Network Association. You can see this issue for more details - #30410

Relations

Closes #30410.
Relates #30380.

References

The API reference can be found here -- https://docs.aws.amazon.com/vpc-lattice/latest/APIReference/API_CreateServiceNetworkServiceAssociation.html

Output from Acceptance Testing

:~/terraform-provider-aws (f-aws_vpclattice_service) $ make testacc PKG=vpclattice TESTS=TestAccVPCLatticeServiceNetworkAsc_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccVPCLatticeServiceNetworkAsc_'  -timeout 180m
=== RUN   TestAccVPCLatticeServiceNetworkAsc_basic
=== PAUSE TestAccVPCLatticeServiceNetworkAsc_basic
=== RUN   TestAccVPCLatticeServiceNetworkAsc_disappears
=== PAUSE TestAccVPCLatticeServiceNetworkAsc_disappears
=== RUN   TestAccVPCLatticeServiceNetworkAsc_tags
=== PAUSE TestAccVPCLatticeServiceNetworkAsc_tags
=== CONT  TestAccVPCLatticeServiceNetworkAsc_basic
=== CONT  TestAccVPCLatticeServiceNetworkAsc_tags
=== CONT  TestAccVPCLatticeServiceNetworkAsc_disappears
--- PASS: TestAccVPCLatticeServiceNetworkAsc_basic (24.11s)
--- PASS: TestAccVPCLatticeServiceNetworkAsc_disappears (28.82s)
--- PASS: TestAccVPCLatticeServiceNetworkAsc_tags (70.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 70.497s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeServiceNetworkServiceAssociation_' PKG=vpclattice ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 2  -run=TestAccVPCLatticeServiceNetworkServiceAssociation_ -timeout 180m
=== RUN   TestAccVPCLatticeServiceNetworkServiceAssociation_basic
=== PAUSE TestAccVPCLatticeServiceNetworkServiceAssociation_basic
=== RUN   TestAccVPCLatticeServiceNetworkServiceAssociation_disappears
=== PAUSE TestAccVPCLatticeServiceNetworkServiceAssociation_disappears
=== RUN   TestAccVPCLatticeServiceNetworkServiceAssociation_tags
=== PAUSE TestAccVPCLatticeServiceNetworkServiceAssociation_tags
=== CONT  TestAccVPCLatticeServiceNetworkServiceAssociation_basic
=== CONT  TestAccVPCLatticeServiceNetworkServiceAssociation_tags
--- PASS: TestAccVPCLatticeServiceNetworkServiceAssociation_basic (39.19s)
=== CONT  TestAccVPCLatticeServiceNetworkServiceAssociation_disappears
--- PASS: TestAccVPCLatticeServiceNetworkServiceAssociation_disappears (33.08s)
--- PASS: TestAccVPCLatticeServiceNetworkServiceAssociation_tags (84.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	97.572s
``

[ewbankkit]

@meetreks Thanks for the contribution 🎉 👏.
In general, everything was great.
I renamed the resource to aws_vpclattice_service_network_service_association to match the underlying AWS APIs.
The documentation needs completion before I can merge.

[meetreks]

@meetreks Thanks for the contribution 🎉 👏. In general, everything was great. I renamed the resource to aws_vpclattice_service_network_service_association to match the underlying AWS APIs. The documentation needs completion before I can merge.

Thanks @ewbankkit as always. You mean the docs html completed right?

[ewbankkit]

@meetreks Correct.

[meetreks]

@ewbankkit fixed the webdocs, kindly review and let me know.

[github-actions]

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.