resource/aws_lb+aws_elb: Fix regression with undefined 'name'

[radeksimko]

Fixes #2498

This also addresses the following test failure:

=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer
--- FAIL: TestAccAWSAutoScalingGroup_WithLoadBalancer (2.67s)
    testing.go:513: Step 0 error: Error planning: 1 error(s) occurred:
        
        * aws_autoscaling_group.bar: 1 error(s) occurred:
        
        * aws_autoscaling_group.bar: Resource 'aws_elb.bar' does not have attribute 'name' for variable 'aws_elb.bar.name'
FAIL

and basically reverts #2314 which was (wrongly) based on the assumption that the new schema behaviour is desired. The upstream regression was already fixed and merged in #2348

Test results

=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (526.14s)
=== RUN   TestAccAWSELB_generatesNameForZeroValue
--- PASS: TestAccAWSELB_generatesNameForZeroValue (52.35s)
=== RUN   TestAccAWSLB_generatesNameForZeroValue
--- PASS: TestAccAWSLB_generatesNameForZeroValue (307.74s)

[bflad]

Did you mean to include these outputs in the test configurations? Only other place I see one is: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_emr_cluster_test.go#L636-L638

[radeksimko]

Yes, that was the intention - to reference it somewhere to make the test fail if someone gets the idea of re-implementing #2314 in the future 😄

[bflad]

LGTM, verified locally (outputs in test configuration are nitpicks)

 make testacc TEST=./aws TESTARGS='-run=\(TestAccAWSAutoScalingGroup_WithLoadBalancer\|TestAccAWSELB_generatesNameForZeroValue\|TestAccAWSLB_generatesNameForZeroValue\)'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=\(TestAccAWSAutoScalingGroup_WithLoadBalancer\|TestAccAWSELB_generatesNameForZeroValue\|TestAccAWSLB_generatesNameForZeroValue\) -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (342.57s)
=== RUN   TestAccAWSELB_generatesNameForZeroValue
--- PASS: TestAccAWSELB_generatesNameForZeroValue (21.17s)
=== RUN   TestAccAWSLB_generatesNameForZeroValue
--- PASS: TestAccAWSLB_generatesNameForZeroValue (241.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	605.316s

[bflad]

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[tonygyerr]

Has there been any update on this issue?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!