Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/aws_lambda_function: Fix failing tests related to 'runtime' #2938

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

radeksimko
Copy link
Member

This is to address the following test failure:

=== RUN   TestAccAWSLambdaFunction_runtimeValidation_noRuntime
--- FAIL: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (64.36s)
    testing.go:494: Step 0, no error received, but expected a match to:
        
        \\"runtime\\": required field is not set

and remove the following test (as nodejs runtime was deprecated for a while and more importantly we're really testing the API here, not the code):

=== RUN   TestAccAWSLambdaFunction_runtimeValidation_nodeJs
--- FAIL: TestAccAWSLambdaFunction_runtimeValidation_nodeJs (54.41s)
    testing.go:494: Step 0, no error received, but expected a match to:
        
        nodejs has reached end of life since October 2016 and has been deprecated in favor of nodejs4.3
        

They both most likely emerged after merging #2348

@radeksimko radeksimko added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 11, 2018
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radeksimko radeksimko merged commit 2932732 into master Jan 11, 2018
@radeksimko radeksimko deleted the t-lambda-func-runtime branch January 11, 2018 12:00
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants