Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts AWS API calls to and provider CRUD calls to Context-aware versions #29005

Merged
merged 222 commits into from
Jan 20, 2023
Merged

Converts AWS API calls to and provider CRUD calls to Context-aware versions #29005

merged 222 commits into from
Jan 20, 2023

Conversation

gdavison
Copy link
Contributor

Converts AWS API calls to and provider CRUD calls to Context-aware versions.

Required for #26029 implementation

@gdavison
Moves errs.AppendErrorf and errs.AppendWarningf to errs.sdkdiag
994a7e3
@gdavison
Adds support for generating only Context-aware tags functions
9aea3dd
@gdavison
Adds support for Context-aware functions without WithContext in g…
05e3377 
…enerated tag resources
@gdavison
Fixes error return
fd3fdb3
@gdavison
Fixes error returns
7cca29f
@gdavison
Adds stub Context for sweepers and adds Context parameter to `swe…
621087d 
…ep.DeleteResource`
@gdavison
Adds support for Context-aware functions without WithContext in g…
11382cc 
…enerated paginated list functions
@gdavison
Removes direct callls to schema.Resource.Delete() from sweepers
73bc7e6
@gdavison
Fixes bare error returns
048320e
@gdavison
Use default Go version and skip-dirs for golangci-lint. Pass both gol…
bfefff1 
…angci-lint configurations in one invocation
@gdavison
Adds stub acctest.Context()
eac06ef
@gdavison
Adds context calls to accessanalyzer
a6c2876
@gdavison
Adds context calls to account
b1b494c
@gdavison
Adds context calls to acm
c8e4a3f
@gdavison
Adds context calls to acmpca
ba821ce
@gdavison
Adds context calls to amp
5973e1b
@gdavison
Adds context calls to amplify
7c79468
@gdavison
Adds context calls to apigateway
4224236
@gdavison
Adds context calls to apigatewayv2
3db5571
@gdavison
Adds context calls to appautoscaling
8ea6799
@gdavison
Adds context calls to appconfig
6491065
@gdavison
Adds context calls to appflow
159b300
@gdavison
Adds context calls to appintegrations
034bcb2
@gdavison
Adds context calls to applicationinsights
f24ee75
@gdavison
Adds context calls to appmesh
002c872
@gdavison
Adds context calls to apprunner
1a1240d
@gdavison
Adds context calls to appstream
40d0cc5
@gdavison
Adds context calls to appsync
4465f22
@gdavison
Adds context calls to athena
7d148d1
@gdavison
Removes nosemgrep
0f23f0c
@gdavison
Adds context calls to transfer
fdb8f0e
@gdavison
Adds context calls to waf
08ee4bf
@gdavison
Adds context calls to wafregional
124c0c9
@gdavison
Adds context calls to wafv2
af2f6b9
@gdavison
Adds context calls to worklink
9d7d08a
@gdavison
Adds context calls to workspaces
9056410
@gdavison
Adds context calls to xray
d7133d1
@gdavison
Documents new format for testAccCheck...Destroy and `testAccCheck..…
46e5d04 
….Exists` functions
@gdavison
Adds Context parameter to acctest.PreCheckOrganizationsAccount
d9a97c5
@gdavison
Adds Context parameter to acctest.PreCheckOrganizationsEnabled
d4c77c4
@gdavison
Adds Context parameter to PreCheckOrganizationManagementAccount
3f5ddb3
@gdavison
Adds Context parameter to acctest.CheckResourceDisappears and `ac…
e3c6743 
…ctest.DeleteResource`
@gdavison
updates skaff test templates
26f786e
@gdavison
Updates Semgrep rules for non-context calls and use of context.TODO
599dc56
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jan 20, 2023
jar-b
jar-b approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Reviewed all changes outside internal/service)

Should we update skaff to use context aware functions as well?

@gdavison
Copy link
Contributor Author

I made some changes to the skaff templates in 26f786e

@gdavison gdavison merged commit 5857c14 into main Jan 20, 2023
@gdavison gdavison deleted the td-context-everywhere branch January 20, 2023 16:56
@github-actions github-actions bot added this to the v4.52.0 milestone Jan 20, 2023
@jar-b
Copy link
Member

jar-b commented Jan 20, 2023

I made some changes to the skaff templates in 26f786e

🤦 github cut off the changes at 3000 files. thanks for clarifying.

@kamilturek
Copy link
Collaborator

kamilturek commented Jan 20, 2023 •
edited
Loading

Hey, @gdavison 👋 Impressive work!

Is there a plan to update the docs section about acceptance tests and sweepers to reflect the changes there?

terraform-provider-aws/docs/running-and-writing-acceptance-tests.md

Line 200 in 04fddaa

CheckDestroy: testAccCheckDashboardDestroy,

Sorry if I missed it!

@gdavison gdavison mentioned this pull request Jan 20, 2023
Merged
@github-actions
Copy link

This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gdavison gdavison mentioned this pull request Feb 6, 2023
Closed
@ewbankkit ewbankkit mentioned this pull request Feb 22, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.52.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @jar-b @kamilturek