Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_rds_export_task #28831

Merged
merged 5 commits into from
Jan 19, 2023
Merged

New Resource: aws_rds_export_task #28831

merged 5 commits into from
Jan 19, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jan 11, 2023

Description

aws_rds_export_task will allow practitioners to trigger RDS snapshot exports to S3 via terraform.

Relations

Closes #16181

References

Proposed behavior is documented in this comment: #16181 (comment)

Output from Acceptance Testing

$ make testacc PKG=rds TESTS=TestAccRDSExportTask_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSExportTask_'  -timeout 180m
=== RUN   TestAccRDSExportTask_basic
=== PAUSE TestAccRDSExportTask_basic
=== RUN   TestAccRDSExportTask_optional
=== PAUSE TestAccRDSExportTask_optional
=== CONT  TestAccRDSExportTask_basic
=== CONT  TestAccRDSExportTask_optional
--- PASS: TestAccRDSExportTask_optional (1881.94s)
--- PASS: TestAccRDSExportTask_basic (2004.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2007.875s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 11, 2023
@jar-b jar-b force-pushed the f-aws_db_export_task branch from c7ed00c to 1e8ec16 Compare January 11, 2023 19:33
@jar-b jar-b marked this pull request as ready for review January 11, 2023 20:43
@ewbankkit
Copy link
Contributor

Should help with #13391.

@jar-b jar-b marked this pull request as draft January 18, 2023 16:40
@jar-b jar-b force-pushed the f-aws_db_export_task branch from 1e8ec16 to 0647843 Compare January 19, 2023 18:00
@jar-b jar-b marked this pull request as ready for review January 19, 2023 18:00
@jar-b jar-b merged commit 8899a99 into main Jan 19, 2023
@jar-b jar-b deleted the f-aws_db_export_task branch January 19, 2023 18:43
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 19, 2023
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds: export db snapshot data to S3
2 participants