Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auditmanager sweepers #28274

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Add auditmanager sweepers #28274

merged 1 commit into from
Dec 9, 2022

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Dec 9, 2022

Description

Adding sweepers for the auditmanager service. Currently this includes the control and framework resources.

Relations

Relates #17981

Output from Acceptance Testing

$ SWEEPARGS=-sweep-run=aws_auditmanager_ make sweep
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_auditmanager_ -timeout 60m
<snip>
2022/12/09 10:31:49 [DEBUG] Completed Sweeper (aws_auditmanager_framework) in region (us-east-2) in 122.288625ms
2022/12/09 10:31:49 Completed Sweepers for region (us-east-2) in 474.862791ms
2022/12/09 10:31:49 Sweeper Tests for region (us-east-2) ran successfully:
        - aws_auditmanager_control
        - aws_auditmanager_framework
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      4.628s

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/auditmanager Issues and PRs that pertain to the auditmanager service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Dec 9, 2022
@jar-b jar-b force-pushed the f-auditmanager-sweepers branch from c68e838 to c01a596 Compare December 9, 2022 15:41
@jar-b jar-b merged commit ce165a9 into main Dec 9, 2022
@jar-b jar-b deleted the f-auditmanager-sweepers branch December 9, 2022 16:12
@github-actions github-actions bot added this to the v4.47.0 milestone Dec 9, 2022
@github-actions
Copy link

This functionality has been released in v4.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/auditmanager Issues and PRs that pertain to the auditmanager service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant