Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_resourcegroups_group: Make configuration.parameters optional #27985

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 23, 2022

Description

Makes the aws_resourcegroups_group configuration.parameters attribute optional, as indicated in both the AWS Terraform Provider and AWS documentation.

Relations

Closes #16803

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/resourcegroups_group#parameters
https://docs.aws.amazon.com/ARG/latest/APIReference/API_GroupConfigurationItem.html

Output from Acceptance Testing

$ make testacc PKG=resourcegroups TESTS=TestAccResourceGroupsGroup_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 20 -run='TestAccResourceGroupsGroup_'  -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== RUN   TestAccResourceGroupsGroup_configurationParametersOptional
=== PAUSE TestAccResourceGroupsGroup_configurationParametersOptional
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_configurationParametersOptional
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_configurationParametersOptional (20.16s)
--- PASS: TestAccResourceGroupsGroup_basic (31.83s)
--- PASS: TestAccResourceGroupsGroup_tags (43.88s)
--- PASS: TestAccResourceGroupsGroup_Configuration (52.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups     54.729s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2022
@jar-b jar-b force-pushed the b-resourcegroup-params branch from c6caa86 to 9502949 Compare November 23, 2022 17:14
@jar-b jar-b marked this pull request as ready for review November 23, 2022 17:48
@jar-b jar-b added the bug Addresses a defect in current functionality. label Nov 23, 2022
@jar-b jar-b merged commit 4eef36f into main Nov 23, 2022
@jar-b jar-b deleted the b-resourcegroup-params branch November 23, 2022 18:13
@github-actions github-actions bot added this to the v4.41.0 milestone Nov 23, 2022
github-actions bot pushed a commit that referenced this pull request Nov 23, 2022
@github-actions
Copy link

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support configuration attribute of create-group action for aws_resourcegroups_group
1 participant