Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_service: support resource import #2764

Merged
merged 3 commits into from
Feb 8, 2018
Merged

r/aws_ecs_service: support resource import #2764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b824b7
r/aws_ecs_service: support resource import
Dec 24, 2017
83e4d07
add acceptance test
Jan 12, 2018
793c03b
merge master
Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions aws/resource_aws_ecs_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ func resourceAwsEcsService() *schema.Resource {
Read: resourceAwsEcsServiceRead,
Update: resourceAwsEcsServiceUpdate,
Delete: resourceAwsEcsServiceDelete,
Importer: &schema.ResourceImporter{
State: resourceAwsEcsServiceImport,
},

Schema: map[string]*schema.Schema{
"name": {
Expand Down Expand Up @@ -195,6 +198,19 @@ func resourceAwsEcsService() *schema.Resource {
}
}

func resourceAwsEcsServiceImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
if len(strings.Split(d.Id(), "/")) != 2 {
return []*schema.ResourceData{}, fmt.Errorf("[ERR] Wrong format of resource: %s. Please follow 'cluster-name/service-name'", d.Id())
}
cluster := strings.Split(d.Id(), "/")[0]
name := strings.Split(d.Id(), "/")[1]
log.Printf("[DEBUG] Importing ECS service %s from cluster %s", name, cluster)

d.SetId(name)
d.Set("cluster", cluster)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind setting both ID and cluster to ARNs here to keep expectations aligned with what's documented?

Thanks.

return []*schema.ResourceData{d}, nil
}

func resourceAwsEcsServiceCreate(d *schema.ResourceData, meta interface{}) error {
conn := meta.(*AWSClient).ecsconn

Expand Down
8 changes: 8 additions & 0 deletions website/docs/r/ecs_service.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,11 @@ The following attributes are exported:
* `cluster` - The Amazon Resource Name (ARN) of cluster which the service runs on
* `iam_role` - The ARN of IAM role used for ELB
* `desired_count` - The number of instances of the task definition

## Import

ECS services can be imported using the `name` together with ecs cluster `name`, e.g.

```
$ terraform import aws_ecs_service.imported cluster-name/service-name
```