Downsize ES domains to save money

[radeksimko]

There's no need to use such expensive instance types in our tests, so I downgraded these to save some money. 💰

t2.micro.elasticsearch is $0.018 per Hour (the cheapest available w/out EBS)
m3.medium.elasticsearch is $0.094 per Hour (the cheapest available w/ EBS)

r3.large.elasticsearch was $0.245 per Hour

https://aws.amazon.com/elasticsearch-service/pricing/

ES is an expensive leak otherwise and was the most expensive part of our bill - so I'm just picking the low hanging fruit - there's a few other places where we can cut the unnecessary costs.

Test results

=== RUN   TestAccAWSElasticSearchDomain_duplicate
--- PASS: TestAccAWSElasticSearchDomain_duplicate (595.89s)
=== RUN   TestAccAWSElasticSearchDomain_v23
--- PASS: TestAccAWSElasticSearchDomain_v23 (739.38s)
=== RUN   TestAccAWSElasticSearchDomain_policy
--- PASS: TestAccAWSElasticSearchDomain_policy (945.22s)
=== RUN   TestAccAWSElasticSearchDomain_tags
--- PASS: TestAccAWSElasticSearchDomain_tags (997.97s)
=== RUN   TestAccAWSElasticSearchDomain_importBasic
--- PASS: TestAccAWSElasticSearchDomain_importBasic (1029.03s)
=== RUN   TestAccAWSElasticSearchDomain_complex
--- PASS: TestAccAWSElasticSearchDomain_complex (1037.62s)
=== RUN   TestAccAWSElasticSearchDomain_vpc
--- PASS: TestAccAWSElasticSearchDomain_vpc (1373.16s)
=== RUN   TestAccAWSElasticSearchDomain_basic
--- PASS: TestAccAWSElasticSearchDomain_basic (1531.54s)
=== RUN   TestAccAWSElasticSearchDomain_update
--- PASS: TestAccAWSElasticSearchDomain_update (2129.23s)
=== RUN   TestAccAWSElasticSearchDomain_internetToVpcEndpoint
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2160.52s)
=== RUN   TestAccAWSElasticSearchDomainPolicy_basic
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (2765.69s)
=== RUN   TestAccAWSElasticSearchDomain_vpc_update
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (2766.88s)

[Ninir]

💸 💸 💸 💸 ! 👍

[tomelliff]

@radeksimko not sure if it matters much but a lot of the test resources don't explicitly state the instance type and so get defaulted to m4.larges. For the majority of things these could probably be set to t2.micros I think.

I would expect there to only need a single test case that doesn't set the instance type so you can test that path works nicely and maybe a test case for a different instance type than a t2.micro as well just to test that path is working properly.

I did notice (currently working on the resource in #2632) that the tests just check that the ES domain has been created rather than checking attributes of the resource like I'd expect. Is there a reason behind that or has this just been left off by previous contributors?

[radeksimko]

not sure if it matters much but a lot of the test resources don't explicitly state the instance type and so get defaulted to m4.larges. For the majority of things these could probably be set to t2.micros I think.

Agreed, I was just collecting the low hanging fruit, I didn't notice/realize that.

I did notice (currently working on the resource in #2632) that the tests just check that the ES domain has been created rather than checking attributes of the resource like I'd expect. Is there a reason behind that or has this just been left off by previous contributors?

There is no particular reason I'm aware of. It was most likely just forgotten.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!