-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_dx_connection_association #2360
Merged
radeksimko
merged 6 commits into
hashicorp:master
from
atsushi-ishibashi:aws_dx_connection_association
Dec 4, 2017
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
159e21f
New Resource: aws_dx_connection_association
atsushi-ishibashi 87dd343
Reflect reviews
atsushi-ishibashi e8fad39
fix
atsushi-ishibashi 52fcd8b
fix
atsushi-ishibashi 67ea88a
Reflect 2nd reviews
atsushi-ishibashi 53df933
Add acctest
atsushi-ishibashi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/directconnect" | ||
"github.com/hashicorp/terraform/helper/schema" | ||
) | ||
|
||
func resourceAwsDxConnectionAssociation() *schema.Resource { | ||
return &schema.Resource{ | ||
Create: resourceAwsDxConnectionAssociationCreate, | ||
Read: resourceAwsDxConnectionAssociationRead, | ||
Delete: resourceAwsDxConnectionAssociationDelete, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"connection_id": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, | ||
"lag_id": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func resourceAwsDxConnectionAssociationCreate(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).dxconn | ||
|
||
input := &directconnect.AssociateConnectionWithLagInput{ | ||
ConnectionId: aws.String(d.Get("connection_id").(string)), | ||
LagId: aws.String(d.Get("lag_id").(string)), | ||
} | ||
resp, err := conn.AssociateConnectionWithLag(input) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
d.SetId(*resp.ConnectionId) | ||
return nil | ||
} | ||
|
||
func resourceAwsDxConnectionAssociationRead(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).dxconn | ||
|
||
input := &directconnect.DescribeConnectionsInput{ | ||
ConnectionId: aws.String(d.Id()), | ||
} | ||
|
||
resp, err := conn.DescribeConnections(input) | ||
if err != nil { | ||
return err | ||
} | ||
if len(resp.Connections) < 1 { | ||
d.SetId("") | ||
return nil | ||
} | ||
if len(resp.Connections) != 1 { | ||
return fmt.Errorf("Found %d DX connections for %s, expected 1", len(resp.Connections), d.Id()) | ||
} | ||
if *resp.Connections[0].LagId != d.Get("lag_id").(string) { | ||
d.SetId("") | ||
return nil | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func resourceAwsDxConnectionAssociationDelete(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).dxconn | ||
|
||
input := &directconnect.DisassociateConnectionFromLagInput{ | ||
ConnectionId: aws.String(d.Id()), | ||
LagId: aws.String(d.Get("lag_id").(string)), | ||
} | ||
|
||
_, err := conn.DisassociateConnectionFromLag(input) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
d.SetId("") | ||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,138 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/directconnect" | ||
"github.com/hashicorp/terraform/helper/acctest" | ||
"github.com/hashicorp/terraform/helper/resource" | ||
"github.com/hashicorp/terraform/terraform" | ||
) | ||
|
||
func TestAccAwsDxConnectionAssociation_basic(t *testing.T) { | ||
resource.Test(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccCheckAwsDxConnectionAssociationDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccDxConnectionAssociationConfig(acctest.RandString(5)), | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckAwsDxConnectionAssociationExists("aws_dx_connection_association.test"), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func TestAccAwsDxConnectionAssociation_multiConns(t *testing.T) { | ||
resource.Test(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccCheckAwsDxConnectionAssociationDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccDxConnectionAssociationConfig_multiConns(acctest.RandString(5)), | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckAwsDxConnectionAssociationExists("aws_dx_connection_association.test1"), | ||
testAccCheckAwsDxConnectionAssociationExists("aws_dx_connection_association.test2"), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testAccCheckAwsDxConnectionAssociationDestroy(s *terraform.State) error { | ||
conn := testAccProvider.Meta().(*AWSClient).dxconn | ||
|
||
for _, rs := range s.RootModule().Resources { | ||
if rs.Type != "aws_dx_connection_association" { | ||
continue | ||
} | ||
|
||
input := &directconnect.DescribeConnectionsInput{ | ||
ConnectionId: aws.String(rs.Primary.ID), | ||
} | ||
|
||
resp, err := conn.DescribeConnections(input) | ||
if err != nil { | ||
return err | ||
} | ||
for _, v := range resp.Connections { | ||
if *v.ConnectionId == rs.Primary.ID && v.LagId != nil { | ||
return fmt.Errorf("Dx Connection (%s) is not dissociated with Lag", rs.Primary.ID) | ||
} | ||
} | ||
} | ||
return nil | ||
} | ||
|
||
func testAccCheckAwsDxConnectionAssociationExists(name string) resource.TestCheckFunc { | ||
return func(s *terraform.State) error { | ||
_, ok := s.RootModule().Resources[name] | ||
if !ok { | ||
return fmt.Errorf("Not found: %s", name) | ||
} | ||
|
||
return nil | ||
} | ||
} | ||
|
||
func testAccDxConnectionAssociationConfig(rName string) string { | ||
return fmt.Sprintf(` | ||
resource "aws_dx_connection" "test" { | ||
name = "tf-dx-%s" | ||
bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
} | ||
|
||
resource "aws_dx_lag" "test" { | ||
name = "tf-dx-%s" | ||
connections_bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
number_of_connections = 1 | ||
force_destroy = true | ||
} | ||
|
||
resource "aws_dx_connection_association" "test" { | ||
connection_id = "${aws_dx_connection.test.id}" | ||
lag_id = "${aws_dx_lag.test.id}" | ||
} | ||
`, rName, rName) | ||
} | ||
|
||
func testAccDxConnectionAssociationConfig_multiConns(rName string) string { | ||
return fmt.Sprintf(` | ||
resource "aws_dx_connection" "test1" { | ||
name = "tf-dxconn1-%s" | ||
bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
} | ||
|
||
resource "aws_dx_connection" "test2" { | ||
name = "tf-dxconn2-%s" | ||
bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
} | ||
|
||
resource "aws_dx_lag" "test" { | ||
name = "tf-dx-%s" | ||
connections_bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
number_of_connections = 1 | ||
force_destroy = true | ||
} | ||
|
||
resource "aws_dx_connection_association" "test1" { | ||
connection_id = "${aws_dx_connection.test1.id}" | ||
lag_id = "${aws_dx_lag.test.id}" | ||
} | ||
|
||
resource "aws_dx_connection_association" "test2" { | ||
connection_id = "${aws_dx_connection.test2.id}" | ||
lag_id = "${aws_dx_lag.test.id}" | ||
} | ||
`, rName, rName, rName) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
--- | ||
layout: "aws" | ||
page_title: "AWS: aws_dx_connection_association" | ||
sidebar_current: "docs-aws-resource-dx-connection-association" | ||
description: |- | ||
Associates a Direct Connect Connection with a LAG. | ||
--- | ||
|
||
# aws_dx_connection_association | ||
|
||
Associates a Direct Connect Connection with a LAG. | ||
|
||
## Example Usage | ||
|
||
```hcl | ||
resource "aws_dx_connection" "example" { | ||
name = "example" | ||
bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
} | ||
|
||
resource "aws_dx_lag" "example" { | ||
name = "example" | ||
connections_bandwidth = "1Gbps" | ||
location = "EqSe2" | ||
number_of_connections = 1 | ||
} | ||
|
||
resource "aws_dx_connection_association" "example" { | ||
connection_id = "${aws_dx_connection.example.id}" | ||
lag_id = "${aws_dx_lag.example.id}" | ||
} | ||
``` | ||
|
||
## Argument Reference | ||
|
||
The following arguments are supported: | ||
|
||
* `connection_id` - (Required) The ID of the connection. | ||
* `lag_id` - (Required) The ID of the LAG with which to associate the connection. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a bit of misunderstanding about what I meant by my question about LAG ID mismatch - I wasn't implying it should be removed. I meant we should treat it the same way as if there is no connection - i.e.
d.SetId(""); return nil
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I got it👍